Validate monitoring_location_id format in waterdata functions#229

Merged

thodson-usgs merged 21 commits into

DOI-USGS:mainfrom

thodson-usgs:validate-monitoring-location-id

May 13, 2026

Commits on May 13, 2026

Validate monitoring_location_id format in waterdata functions

thodson-usgs
and
claude
committed
Widen _check_monitoring_location_id to accept iterables of strings

thodson-usgs
and
claude
committed
Tidy _check_monitoring_location_id (clearer dispatch, helper, type hints)

thodson-usgs
and
claude
committed
Address Copilot review on PR #229

thodson-usgs
and
claude
committed
Apply _normalize_str_iterable to every multi-value string parameter

thodson-usgs
and
claude
committed
Polish from /simplify review

thodson-usgs
and
claude
committed
Centralize string-iterable normalization in _get_args (-153 LOC)

thodson-usgs
and
claude
committed
_format_api_dates: materialize iterable inputs (Copilot #4)

thodson-usgs
and
claude
committed
Extract _DATE_RANGE_PARAMS; trim docstrings/comments from /simplify

thodson-usgs
and
claude
committed
Add StringFilter/StringList aliases; fix Copilot bugs

thodson-usgs
and
claude
committed
Revert StringFilter/StringList aliases; use inline PEP 604 unions
thodson-usgs
committed
Reject list-of-non-strings at boundary instead of silently passing through
thodson-usgs
committed
Allow int-valued list filters in _get_args (water_year, year, month, day, peak_since)
thodson-usgs
committed
Close Copilot review gaps: extend AGENCY-ID check + iterable normalization to all OGC functions
thodson-usgs
committed
Centralize monitoring_location_id check in _get_args; trim narration
thodson-usgs
committed
Widen string-filter annotations on get_combined_metadata / get_field_measurements_metadata / get_peaks
thodson-usgs
committed
Fix CI and reject Mapping inputs to _format_api_dates
thodson-usgs
committed
Update parameter docstrings to "string or iterable of strings"
thodson-usgs
committed
Widen properties annotation to Iterable[str] for consistency
thodson-usgs
committed
Validate monitoring_location_id in get_ratings and widen annotations in nearest
thodson-usgs
committed
Drop dead `monitoring_location_id` entry from _NO_NORMALIZE_PARAMS; trim _check branching
thodson-usgs
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate monitoring_location_id format in waterdata functions#229

Validate monitoring_location_id format in waterdata functions#229
thodson-usgs merged 21 commits into
DOI-USGS:mainfrom
thodson-usgs:validate-monitoring-location-id

Commits on May 13, 2026

Validate monitoring_location_id format in waterdata functions

Widen _check_monitoring_location_id to accept iterables of strings

Tidy _check_monitoring_location_id (clearer dispatch, helper, type hints)

Address Copilot review on PR #229

Apply _normalize_str_iterable to every multi-value string parameter

Polish from /simplify review

Centralize string-iterable normalization in _get_args (-153 LOC)

_format_api_dates: materialize iterable inputs (Copilot #4)

Extract _DATE_RANGE_PARAMS; trim docstrings/comments from /simplify

Add StringFilter/StringList aliases; fix Copilot bugs

Revert StringFilter/StringList aliases; use inline PEP 604 unions

Reject list-of-non-strings at boundary instead of silently passing through

Allow int-valued list filters in _get_args (water_year, year, month, day, peak_since)

Close Copilot review gaps: extend AGENCY-ID check + iterable normalization to all OGC functions

Centralize monitoring_location_id check in _get_args; trim narration

Widen string-filter annotations on get_combined_metadata / get_field_measurements_metadata / get_peaks

Fix CI and reject Mapping inputs to _format_api_dates

Update parameter docstrings to "string or iterable of strings"

Widen properties annotation to Iterable[str] for consistency

Validate monitoring_location_id in get_ratings and widen annotations in nearest

Drop dead `monitoring_location_id` entry from _NO_NORMALIZE_PARAMS; trim _check branching