Repository navigation
Create fallback html page when code coverage workflow fails - #576
Draft
andrewmogan wants to merge 11 commits into
Draft
andrewmogan wants to merge 11 commits into
andrewmogan wants to merge 11 commits into
Conversation
This was intended to reset the automatic disabling of workflows in public repositories that have had no activity in over 60 days. However, I've learned that this command requires elevated write permissions which I'm not comfortable implementing in a workflow which could write to so many repos at once.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last week, the nightly CI dashboard workflow failed multiple times because the weekly code coverage workflow failed. The CI dashboard workflow attempts to download an artifact from the most recent code coverage workflow which contains the html page showing the code coverage results. If it can't find that artifact, the CI dashboard publication fails. This PR allows the code coverage workflow to upload a default html page that says "there was an issue, contact Software Coordination." Note that this does not cause an obvious failure in the CI dashboard publication workflow, but we will still see that the code coverage workflow failed.
TODO: Update test runs to use latest commits.
While working on this, I also noticed that the
collect-ci-metrics.shscript that runs as part of the CI dashboard workflow was showing a bunch of 403 errors due to insufficient permissions. This has apparently been happening for some time; see here under the "Copy artifacts and generate dashboard" step. It turns out that thegh api -X PUTcommand we run incollect-ci-metrics.shto reset workflow inactivity timers requires write permissions, where the CI dashboard workflow is set to read-only for security reasons. For now, I've removed that command fromcollect-ci-metrics.sh. We should figure out if we need to work around this. GitHub disables scheduled workflows in repos that have had no activity for 60 days.