Skip to content

Fixing Ci Erro - #56

Merged
Daniel-iel merged 5 commits into
mainfrom
bugfix/ficing-ci-error
Apr 11, 2026
Merged

Fixing Ci Erro#56
Daniel-iel merged 5 commits into
mainfrom
bugfix/ficing-ci-error

Conversation

@Daniel-iel

Copy link
Copy Markdown
Owner

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • ⚡ Performance improvement
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

Related Issues

Fixes #

Changes Made

Testing

  • All existing tests pass (dotnet test)
  • Added new tests for the changes
  • Manually tested the functionality
  • Ran benchmarks (for performance-related changes)
  • Checked for memory leaks or performance regressions

Checklist

  • My code follows the project's code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

Performance Impact

Before:

Method: ReadFromString
Mean: X ns
Allocated: X B

After:

Method: ReadFromString
Mean: Y ns
Allocated: Y B

By submitting this PR, I confirm that my contribution is made under the terms of the MIT license.

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (1835e62) to head (f8bfd4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files           6        6           
  Lines         188      188           
  Branches       32       32           
=======================================
  Hits          184      184           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Daniel-iel
Daniel-iel merged commit 2bc380c into main Apr 11, 2026
9 checks passed
@Daniel-iel
Daniel-iel deleted the bugfix/ficing-ci-error branch April 11, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant