Skip to content

DT-3598: Remove unused schema api, docs, and tests#2949

Open
rushtong wants to merge 2 commits into
developfrom
gr-DT-3598-rm-unused-schema-api
Open

DT-3598: Remove unused schema api, docs, and tests#2949
rushtong wants to merge 2 commits into
developfrom
gr-DT-3598-rm-unused-schema-api

Conversation

@rushtong

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-3598

Summary

Fully remove deprecated API and supporting code.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong changed the title feat: remove unused schema api, docs, and tests DT-3598: Remove unused schema api, docs, and tests Jun 23, 2026
@rushtong rushtong marked this pull request as ready for review June 23, 2026 15:08
@rushtong rushtong requested a review from a team as a code owner June 23, 2026 15:08
@rushtong rushtong requested review from Copilot, fboulnois and otchet-broad and removed request for a team June 23, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated schema endpoint /schemas/dataset-registration/v1 from the Dropwizard service and prunes its associated OpenAPI path entry and test, aligning the codebase with DT-3598’s goal of fully removing unused schema API surface area.

Changes:

  • Deleted SchemaResource and unregistered it from ConsentApplication.
  • Removed the OpenAPI path definition file and the corresponding api-docs.yaml path reference.
  • Deleted the resource-level unit test for the removed endpoint.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/test/java/org/broadinstitute/consent/http/resources/SchemaResourceTest.java Removes the unit test for the deleted schema endpoint.
src/main/resources/assets/paths/schemaDatasetRegistrationV1.yaml Removes the OpenAPI path fragment for the deprecated endpoint.
src/main/resources/assets/api-docs.yaml Removes the /schemas/dataset-registration/v1 path registration from the root OpenAPI document.
src/main/java/org/broadinstitute/consent/http/resources/SchemaResource.java Deletes the JAX-RS resource that served the deprecated schema.
src/main/java/org/broadinstitute/consent/http/ConsentApplication.java Unregisters the removed resource from Jersey and drops its import.

Comment thread src/main/resources/assets/api-docs.yaml
@sonarqubecloud

Copy link
Copy Markdown

@fboulnois fboulnois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants