DT-3598: Remove unused schema api, docs, and tests#2949
Open
rushtong wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated schema endpoint /schemas/dataset-registration/v1 from the Dropwizard service and prunes its associated OpenAPI path entry and test, aligning the codebase with DT-3598’s goal of fully removing unused schema API surface area.
Changes:
- Deleted
SchemaResourceand unregistered it fromConsentApplication. - Removed the OpenAPI path definition file and the corresponding
api-docs.yamlpath reference. - Deleted the resource-level unit test for the removed endpoint.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/broadinstitute/consent/http/resources/SchemaResourceTest.java | Removes the unit test for the deleted schema endpoint. |
| src/main/resources/assets/paths/schemaDatasetRegistrationV1.yaml | Removes the OpenAPI path fragment for the deprecated endpoint. |
| src/main/resources/assets/api-docs.yaml | Removes the /schemas/dataset-registration/v1 path registration from the root OpenAPI document. |
| src/main/java/org/broadinstitute/consent/http/resources/SchemaResource.java | Deletes the JAX-RS resource that served the deprecated schema. |
| src/main/java/org/broadinstitute/consent/http/ConsentApplication.java | Unregisters the removed resource from Jersey and drops its import. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses
https://broadworkbench.atlassian.net/browse/DT-3598
Summary
Fully remove deprecated API and supporting code.
Have you read CONTRIBUTING.md lately? If not, do that first.