feat: atlas source studies page: filter by integrated object (filter-only, no column) (#3084)#3086
Draft
frano-m wants to merge 3 commits into
Draft
feat: atlas source studies page: filter by integrated object (filter-only, no column) (#3084)#3086frano-m wants to merge 3 commits into
frano-m wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Integrated Object filter (hidden/filter-only column) to the Atlas Source Studies tracker table, wiring a new integratedObjects field from the tracker API into the table’s faceted filtering system.
Changes:
- Adds
integratedObjectstoTrackerSourceStudyand introduces an accessor (buildIntegratedObjects) that extracts integrated-object names. - Adds a filterable, hidden
integratedObjectcolumn to the Source Studies table usingfilterFn: "arrIncludesSome". - Extends the table’s
columnVisibilitystate to keep the new filter-only column hidden (matching thejournal/referenceAuthorpattern).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/hook.ts |
Hides the new filter-only column via columnVisibility. |
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/columns.ts |
Adds the integratedObject filterable column definition to COLUMNS. |
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/accessor.ts |
Adds buildIntegratedObjects accessor to extract integrated-object names safely. |
@types/network.ts |
Extends TrackerSourceStudy with the integratedObjects field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…only, no column) (#3084) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
74a6c2d to
9dd2a1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integratedObjects: { id: string; name: string }[]toTrackerSourceStudy.columnVisibilitywithintegratedObject: false, mirroring the existingjournal/referenceAuthorfilter-only pattern.accessor.tsasbuildIntegratedObjects(matchesbuildSourceStudyco-location).Closes #3084
Depends on
clevercanary/hca-atlas-tracker#1321(backend exposesintegratedObjectsas a pass-through). Verified against the live tracker API — the field is not present yet, so the accessor null-safes (?? []) until the backend ships.Test plan
npm run build-dev:data-portal) succeeds locally/hca-bio-networks/gut/atlases/gut-v1-0/source-studies— "Integrated Object" filter appears in the sidebar