Skip to content

feat: atlas source studies page: filter by integrated object (filter-only, no column) (#3084)#3086

Draft
frano-m wants to merge 3 commits into
mainfrom
fran/3084-atlas-source-studies-filter-integrated-object
Draft

feat: atlas source studies page: filter by integrated object (filter-only, no column) (#3084)#3086
frano-m wants to merge 3 commits into
mainfrom
fran/3084-atlas-source-studies-filter-integrated-object

Conversation

@frano-m

@frano-m frano-m commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds an Integrated Object filter to the atlas Source Studies table — filter-only, no visible column.
  • Adds integratedObjects: { id: string; name: string }[] to TrackerSourceStudy.
  • Extends columnVisibility with integratedObject: false, mirroring the existing journal / referenceAuthor filter-only pattern.
  • Extracts the names accessor into accessor.ts as buildIntegratedObjects (matches buildSourceStudy co-location).

Closes #3084

Depends on clevercanary/hca-atlas-tracker#1321 (backend exposes integratedObjects as a pass-through). Verified against the live tracker API — the field is not present yet, so the accessor null-safes (?? []) until the backend ships.

Test plan

  • Build (npm run build-dev:data-portal) succeeds locally
  • After backend deploy: visit /hca-bio-networks/gut/atlases/gut-v1-0/source-studies — "Integrated Object" filter appears in the sidebar
  • Filter applies correctly and narrows the table to rows that include the selected integrated object(s)
  • No new column is rendered in the table
image

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Integrated Object filter (hidden/filter-only column) to the Atlas Source Studies tracker table, wiring a new integratedObjects field from the tracker API into the table’s faceted filtering system.

Changes:

  • Adds integratedObjects to TrackerSourceStudy and introduces an accessor (buildIntegratedObjects) that extracts integrated-object names.
  • Adds a filterable, hidden integratedObject column to the Source Studies table using filterFn: "arrIncludesSome".
  • Extends the table’s columnVisibility state to keep the new filter-only column hidden (matching the journal / referenceAuthor pattern).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/hook.ts Hides the new filter-only column via columnVisibility.
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/columns.ts Adds the integratedObject filterable column definition to COLUMNS.
components/HCABioNetworks/Network/Atlas/components/SourceStudies/components/MainColumn/tracker/components/table/accessor.ts Adds buildIntegratedObjects accessor to extract integrated-object names safely.
@types/network.ts Extends TrackerSourceStudy with the integratedObjects field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread @types/network.ts Outdated
@frano-m frano-m marked this pull request as ready for review June 5, 2026 02:50
frano-m and others added 3 commits June 10, 2026 19:06
…only, no column) (#3084)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@frano-m frano-m force-pushed the fran/3084-atlas-source-studies-filter-integrated-object branch from 74a6c2d to 9dd2a1b Compare June 10, 2026 09:06
@NoopDog NoopDog marked this pull request as draft June 10, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atlas source studies page: filter by Integrated Object (filter-only, no column)

3 participants