Repository navigation
Update gem-push.yml workflow trigger settings - #973
Closed
filforopen-source wants to merge 719 commits into
Closed
filforopen-source wants to merge 719 commits into
filforopen-source wants to merge 719 commits into
Conversation
…-compatible-with-go-agent Make kitchen docker tests compatible with agent >5 (go agent)
….1.0 Release version 4.1.0
Add -1 version suffix if not set on OSes with yum
* Add options key adding options key to allow collection of additional metrics https://github.com/DataDog/integrations-core/blob/master/mcache/datadog_checks/mcache/data/conf.yaml.example#L44-L46 * Update memcache.rb
…y win credentials (DataDog#691) * Set windows installer as sensitive * Use env var to pass username/password * Use value directly instead of doing concat * Added missing end newline
…ows (DataDog#690) * Rename variable to avoid shadowing in win install * Add helper to know if have to reinstall agent on windows * Reinstall agent when a recent version is installed
…als_leak Add cleanup for Windows env vars
* Release version 4.2.0 * Update nokogiri version - The previous version 1.10.7 had a security issue.
Tweak comments on skip_ssl_validation that suggests true/false is supported value to be populated into datadog config, which is compatible across agent v5, v6, and v7
* Revert "Merge pull request DataDog#694 from DataDog/julien.lebot/fix_credentials_leak" This reverts commit fa40d3d, reversing changes made to 018ff8b. * Revert "Set windows installer as sensitive resource and use env var to specify win credentials (DataDog#691)" This reverts commit 07d3a62. * Update CHANGELOG.md
…to-false Default skip_ssl_validation into false
This specifically updates rexml to 3.3.7 from 3.2.5 which resolves a number of security vulnerabilities.
* feat(CODEOWNERS): container-ecosystems as owners * feat(CODEOWNERS): container-ecosystems as owners and delivery as shadow
* fix style ci check * fix specs-base ci check * kitchen-docker-tests attempt 1 * kitchen-docker-tests fix 2 * kitchen-docker-tests fix 3
Bumps [rack](https://github.com/rack/rack) from 2.2.3 to 2.2.8.1. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@2.2.3...v2.2.8.1) --- updated-dependencies: - dependency-name: rack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Release 4.22.0 * update changelog
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.10 to 1.18.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.10...v1.18.4) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
DataDog#945) * Bump rexml from 3.3.7 to 3.3.9 in the bundler group across 1 directory Bumps the bundler group with 1 update in the / directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.3.7 to 3.3.9 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.7...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-version: 3.3.9 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> * retrigger CircleCI --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
…ory (DataDog#946) Bumps the bundler group with 1 update in the / directory: [rack](https://github.com/rack/rack). Updates `rack` from 2.2.8.1 to 2.2.13 - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.8.1...v2.2.13) --- updated-dependencies: - dependency-name: rack dependency-version: 2.2.13 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Drop activesupport dependency * retrigger CircleCI
* Revert "Drop activesupport dependency (DataDog#950)" This reverts commit 76fccb3. * Drop activesupport dependency
* Agent Basic Usage - chef doc changes * re-trigger CI attempt --------- Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
…taDog#958) * Chef doc changes to add in-app section under installation section * Update README.md Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com> --------- Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
* remove pycache directory during upgrades This PR removes /opt/datadog-agent/python-scripts/__pycache__ similarly to other installation methods. * empty commit for testing --------- Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Bumps the bundler group with 1 update in the / directory: [nokogiri](https://github.com/sparklemotion/nokogiri). Updates `nokogiri` from 1.15.7 to 1.18.8 - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.15.7...v1.18.8) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.18.8 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Bumps the bundler group with 3 updates in the / directory: [nokogiri](https://github.com/sparklemotion/nokogiri), [rack](https://github.com/rack/rack) and [rexml](https://github.com/ruby/rexml). Updates `nokogiri` from 1.18.8 to 1.18.9 - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.18.8...v1.18.9) Updates `rack` from 2.2.13 to 2.2.18 - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.13...v2.2.18) Updates `rexml` from 3.3.9 to 3.4.2 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.9...v3.4.2) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.18.9 dependency-type: indirect dependency-group: bundler - dependency-name: rack dependency-version: 2.2.18 dependency-type: indirect dependency-group: bundler - dependency-name: rexml dependency-version: 3.4.2 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
* update rack to 2.2.22 * bump more dependencies * Update CODEOWNERS
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c421b377c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+2
to
+4
| on: paychex | ||
| push: 200 | ||
| branches: [ "main" ] |
There was a problem hiding this comment.
The on value is declared as the scalar paychex and then followed by an indented push mapping, which is invalid YAML (mapping values are not allowed in this context). GitHub therefore cannot load this workflow and none of its jobs will ever run; define on as a mapping with push and pull_request beneath it.
Useful? React with 👍 / 👎.
| touch $HOME/.gem/credentials | ||
| chmod 0600 $HOME/.gem/credentials | ||
| printf -- "---\n:github: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials | ||
| gem build *.gemspec |
There was a problem hiding this comment.
This checkout contains no *.gemspec file anywhere, and the workflow does not generate one before this command. RubyGems defines the required gem build argument as a gemspec filename, so the shell leaves the unmatched glob literal and the command exits with Couldn't find a gemspec file matching '*.gemspec'; both publishing steps consequently fail on every run.
Useful? React with 👍 / 👎.
Comment on lines
+5
to
+6
| pull_request: | ||
| branches: [ "main" ] |
There was a problem hiding this comment.
When a same-repository branch opens a pull request and RUBYGEMS_AUTH_TOKEN is available, this trigger runs both gem push commands before the change is merged, allowing unreviewed PR code to publish packages; for fork pull requests, the unavailable secret and restricted token instead make the required job fail. Keep PR runs build-only and gate both publishing steps to a trusted push, tag, or release event.
Useful? React with 👍 / 👎.
added 2 commits
August 22, 2026 03:36
This workflow builds a Docker container and deploys it through Octopus Deploy, including steps for configuration and authentication.
Removed comments and unnecessary configuration for the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist