Skip to content

Conversation

@jchrostek-dd
Copy link
Contributor

Overview

  • Add debug log for flush strategy.
  • Add debug log for incoming telemetry records. This excludes Extension telemetry since that would lead to an infinite loop.

Testing

  • Deployed and invoked function. Confirm we see flush strategy and incoming telemetry records.

Comment on lines +91 to +96

// Log all non-Extension telemetry events to avoid infinite loop
if !matches!(event.record, TelemetryRecord::Extension(_)) {
debug!("LOGS | Incoming telemetry event: {:?}", event.record);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already logging telemetry events here:

debug!("Telemetry event received: {:?}", event);

Is the new log added to help debug what happens in between?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, helpful for what happens in between. When I was looking at logs for Durable Functions, it seemed like we were missing some things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably revert this. If we’re missing something for durable functions then let’s find out why it’s not being captured and sent to Datadog or via a Datadog flare. This will cause us to double log everything the user sends if debug logs are enabled, which will more than 2x the cost for no value.

@jchrostek-dd jchrostek-dd marked this pull request as ready for review December 31, 2025 16:31
@jchrostek-dd jchrostek-dd requested a review from a team as a code owner December 31, 2025 16:31
@jchrostek-dd jchrostek-dd merged commit 46e9e9c into main Dec 31, 2025
50 checks passed
@jchrostek-dd jchrostek-dd deleted the john/add-debug-logs branch December 31, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants