Skip to content

Update Asm Blocked Response #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rithikanarayan merged 6 commits into from
Dec 12, 2025
Merged

Update Asm Blocked Response #681

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6338a02
use block config for block id
rithikanarayan Nov 21, 2025
c04c1e3
linting
rithikanarayan Nov 21, 2025
63d5655
Using existing block config
rithikanarayan Nov 24, 2025
63c4439
Update dd-trace-py version
rithikanarayan Nov 24, 2025
6edde05
update to ddtracepy v3.19.1
rithikanarayan Dec 2, 2025
e16aa66
Merge branch 'main' into rithika.narayan/update-asm-blocked-response
rithikanarayan Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datadog_lambda/asm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,9 @@ def get_asm_blocked_response(
content = ""
else:
content_type = blocked.get("content-type", "application/json")
content = http_utils._get_blocked_template(content_type)
content = http_utils._get_blocked_template(
content_type, blocked.get("block_id", "default")
)
Copy link
Contributor

@purple4reina purple4reina Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should have a test. Something to confirm that we're passing the correct values to the _get_blocked_template method.


response = {
"statusCode": blocked.get("status_code", 403),
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ classifiers = [
python = ">=3.8.0,<4"
datadog = ">=0.51.0,<1.0.0"
wrapt = "^1.11.2"
ddtrace = ">=3.16.2,<4"
ddtrace = ">=3.19.1,<4"
ujson = ">=5.9.0"
botocore = { version = "^1.34.0", optional = true }
requests = { version ="^2.22.0", optional = true }
Expand Down