Skip to content

fix(renovate): Ignore unresolvable dependencies#2859

Merged
levan-m merged 1 commit intomainfrom
fix/renovate-ignore-unresolvable-deps
Apr 3, 2026
Merged

fix(renovate): Ignore unresolvable dependencies#2859
levan-m merged 1 commit intomainfrom
fix/renovate-ignore-unresolvable-deps

Conversation

@chouetz
Copy link
Copy Markdown
Member

@chouetz chouetz commented Apr 2, 2026

What does this PR do?

Adds mstksg/get-package and github.com/aws/smithy-go to Renovate's ignoreDeps list to suppress lookup errors on the Renovate dashboard.

Motivation

Renovate reports two dependency lookup failures:

  • mstksg/get-package (github-actions): Tag v1.0.0 cannot be resolved to a commit, causing "Could not determine new digest for update"
  • github.com/aws/smithy-go (gomod): Go proxy returns no results, causing "Failed to look up go package"

Neither dependency needs Renovate management:

  • mstksg/get-package is already pinned to a specific commit SHA and has no newer versions
  • aws/smithy-go is an indirect Go dependency whose version is controlled by direct dependencies via go mod tidy

Additional Notes

N/A

Minimum Agent Versions

N/A

Describe your test plan

  • Verify the Renovate dashboard no longer reports these two lookup errors after the next Renovate run

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

Ignore mstksg/get-package (tag v1.0.0 not found) and
github.com/aws/smithy-go (no-result from Go proxy) to
clear Renovate dashboard lookup errors.
@chouetz chouetz marked this pull request as ready for review April 2, 2026 16:01
@chouetz chouetz requested a review from a team April 2, 2026 16:01
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d00d3ab8df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"extends": ["config:recommended"],
"enabledManagers": ["github-actions", "gomod"],
"minimumReleaseAge": "7 days",
"ignoreDeps": ["mstksg/get-package", "github.com/aws/smithy-go"],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not ignore smithy-go in Renovate

Adding github.com/aws/smithy-go to top-level ignoreDeps disables Renovate updates for that module everywhere, but this repo depends on it directly (go.mod line 56) and uses it in runtime code. This means future bugfix/security releases for a direct dependency will be silently skipped rather than proposed, which is a real regression beyond suppressing dashboard noise.

Useful? React with 👍 / 👎.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.24%. Comparing base (a350a29) to head (d00d3ab).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2859   +/-   ##
=======================================
  Coverage   39.24%   39.24%           
=======================================
  Files         314      314           
  Lines       27288    27288           
=======================================
  Hits        10708    10708           
  Misses      15792    15792           
  Partials      788      788           
Flag Coverage Δ
unittests 39.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a350a29...d00d3ab. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@levan-m levan-m merged commit cd1a28a into main Apr 3, 2026
58 checks passed
@levan-m levan-m deleted the fix/renovate-ignore-unresolvable-deps branch April 3, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants