fix(renovate): Ignore unresolvable dependencies#2859
Conversation
Ignore mstksg/get-package (tag v1.0.0 not found) and github.com/aws/smithy-go (no-result from Go proxy) to clear Renovate dashboard lookup errors.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d00d3ab8df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "extends": ["config:recommended"], | ||
| "enabledManagers": ["github-actions", "gomod"], | ||
| "minimumReleaseAge": "7 days", | ||
| "ignoreDeps": ["mstksg/get-package", "github.com/aws/smithy-go"], |
There was a problem hiding this comment.
Do not ignore smithy-go in Renovate
Adding github.com/aws/smithy-go to top-level ignoreDeps disables Renovate updates for that module everywhere, but this repo depends on it directly (go.mod line 56) and uses it in runtime code. This means future bugfix/security releases for a direct dependency will be silently skipped rather than proposed, which is a real regression beyond suppressing dashboard noise.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
=======================================
Coverage 39.24% 39.24%
=======================================
Files 314 314
Lines 27288 27288
=======================================
Hits 10708 10708
Misses 15792 15792
Partials 788 788
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What does this PR do?
Adds
mstksg/get-packageandgithub.com/aws/smithy-goto Renovate'signoreDepslist to suppress lookup errors on the Renovate dashboard.Motivation
Renovate reports two dependency lookup failures:
mstksg/get-package(github-actions): Tagv1.0.0cannot be resolved to a commit, causing "Could not determine new digest for update"github.com/aws/smithy-go(gomod): Go proxy returns no results, causing "Failed to look up go package"Neither dependency needs Renovate management:
mstksg/get-packageis already pinned to a specific commit SHA and has no newer versionsaws/smithy-gois an indirect Go dependency whose version is controlled by direct dependencies viago mod tidyAdditional Notes
N/A
Minimum Agent Versions
N/A
Describe your test plan
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel