fix(web): Use JS types in TracingUrl closure - #1128
Open
fuzzybinary wants to merge 1 commit into
Open
Conversation
kikoveiga
previously approved these changes
Aug 24, 2026
This comment has been minimized.
This comment has been minimized.
Not using JS types was breaking WASM builds. Re-enable WASM unit and integration tests now that they don't stall on macOS. refs: #1127
fuzzybinary
force-pushed
the
jward/1127-wasm-compilation
branch
from
August 24, 2026 16:06
41c1168 to
f1cd9f3
Compare
kikoveiga
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Not using JS types was breaking WASM builds.
Re-enable WASM unit and integration tests now that they don't stall on macOS.
refs: #1127
Review checklist