[RUM-13371] Fix incorrect babel plugin's component handler override operations #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdn34dd
force-pushed
the
carlosnogueira/RUM-13371/fix-babel-incorrect-handler-override
branch
from
c5e4928 to
8103c46
Compare
sbarrio
approved these changes
Jan 8, 2026
- Prevent overriding handlers on custom components without proper configuration - Prevent overriding handlers when spread props are present - Prevent adding 'Mandatory' handlers on custom components
cdn34dd
force-pushed
the
carlosnogueira/RUM-13371/fix-babel-incorrect-handler-override
branch
from
8103c46 to
f7dcf5c
Compare
cdn34dd
deleted the
carlosnogueira/RUM-13371/fix-babel-incorrect-handler-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a few issues related to 'Mandatory' props the plugin adds to react-native components. These 'Mandatory' props are props that can be omited on the user side, but will greatly improve the interaction tracking of the SDK, so the plugin adds them. With this PR we keep the same functionality, but fix some issues that could cause incorrect behaviors.
Motivation
Issue raised by user: @datadog/mobile-react-native-babel-plugin overwrites event handler props with noops
Review checklist (to be filled by reviewers)