-
Notifications
You must be signed in to change notification settings - Fork 151
Bump InlineIL.Fody from 1.8.0 to 1.10.0 in /tracer/src/Datadog.Trace.BenchmarkDotNet #6306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [InlineIL.Fody](https://github.com/ltrzesniewski/InlineIL.Fody) from 1.8.0 to 1.10.0. - [Release notes](https://github.com/ltrzesniewski/InlineIL.Fody/releases) - [Commits](ltrzesniewski/InlineIL.Fody@v1.8.0...v1.10.0) --- updated-dependencies: - dependency-name: InlineIL.Fody dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 212105 Passed, 1443 Skipped, 13h 18m 57.29s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (72ms) : 64, 79
. : milestone, 72,
master - mean (72ms) : 64, 80
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (1,113ms) : 1093, 1133
. : milestone, 1113,
master - mean (1,110ms) : 1087, 1133
. : milestone, 1110,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (109ms) : 106, 111
. : milestone, 109,
master - mean (109ms) : 106, 111
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (771ms) : 747, 795
. : milestone, 771,
master - mean (771ms) : 754, 789
. : milestone, 771,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (726ms) : 710, 743
. : milestone, 726,
master - mean (726ms) : 713, 740
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (192ms) : 184, 200
. : milestone, 192,
master - mean (191ms) : 185, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (1,213ms) : 1190, 1236
. : milestone, 1213,
master - mean (1,212ms) : 1185, 1238
. : milestone, 1212,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (949ms) : 929, 970
. : milestone, 949,
master - mean (946ms) : 925, 967
. : milestone, 946,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6306) - mean (266ms) : 262, 271
. : milestone, 266,
master - mean (267ms) : 263, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6306) - mean (934ms) : 919, 949
. : milestone, 934,
master - mean (931ms) : 907, 954
. : milestone, 931,
|
Benchmarks Report for tracer 🐌Benchmarks for #6306 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.128 | 1,262.56 | 1,423.85 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.26μs | 0.788ns | 2.95ns | 0.0145 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 1.73μs | 0.872ns | 3.38ns | 0.0138 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.02μs | 2.01ns | 7.51ns | 0.157 | 0.001 | 0 | 987 B |
| #6306 | ExecuteNonQuery |
net6.0 | 1.42μs | 1.01ns | 3.92ns | 0.0142 | 0 | 0 | 1.02 KB |
| #6306 | ExecuteNonQuery |
netcoreapp3.1 | 1.81μs | 1.24ns | 4.78ns | 0.0136 | 0 | 0 | 1.02 KB |
| #6306 | ExecuteNonQuery |
net472 | 2.1μs | 1.2ns | 4.48ns | 0.156 | 0.00104 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.19μs | 0.664ns | 2.49ns | 0.0137 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.5μs | 1.48ns | 5.72ns | 0.0128 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.49μs | 1.43ns | 5.35ns | 0.158 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.35μs | 6.79ns | 29.6ns | 0.013 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.72μs | 0.733ns | 2.54ns | 0.0138 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.71μs | 1.38ns | 5.34ns | 0.167 | 0 | 0 | 1.05 KB |
| #6306 | CallElasticsearch |
net6.0 | 1.29μs | 1.09ns | 4.08ns | 0.0137 | 0 | 0 | 976 B |
| #6306 | CallElasticsearch |
netcoreapp3.1 | 1.49μs | 1.27ns | 4.75ns | 0.0127 | 0 | 0 | 976 B |
| #6306 | CallElasticsearch |
net472 | 2.58μs | 1.03ns | 3.84ns | 0.157 | 0 | 0 | 995 B |
| #6306 | CallElasticsearchAsync |
net6.0 | 1.3μs | 0.345ns | 1.2ns | 0.0131 | 0 | 0 | 952 B |
| #6306 | CallElasticsearchAsync |
netcoreapp3.1 | 1.63μs | 0.841ns | 3.26ns | 0.0132 | 0 | 0 | 1.02 KB |
| #6306 | CallElasticsearchAsync |
net472 | 2.59μs | 0.815ns | 3.05ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.23μs | 0.598ns | 2.24ns | 0.0134 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.74μs | 0.446ns | 1.67ns | 0.013 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.87μs | 0.823ns | 3.19ns | 0.145 | 0 | 0 | 915 B |
| #6306 | ExecuteAsync |
net6.0 | 1.21μs | 0.385ns | 1.49ns | 0.0134 | 0 | 0 | 952 B |
| #6306 | ExecuteAsync |
netcoreapp3.1 | 1.59μs | 0.907ns | 3.39ns | 0.0126 | 0 | 0 | 952 B |
| #6306 | ExecuteAsync |
net472 | 1.88μs | 0.878ns | 3.29ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.44μs | 3.04ns | 11.8ns | 0.0311 | 0 | 0 | 2.31 KB |
| master | SendAsync |
netcoreapp3.1 | 5.26μs | 2.5ns | 9.37ns | 0.0368 | 0 | 0 | 2.85 KB |
| master | SendAsync |
net472 | 7.4μs | 2ns | 7.75ns | 0.494 | 0 | 0 | 3.12 KB |
| #6306 | SendAsync |
net6.0 | 4.53μs | 2.49ns | 9.32ns | 0.0317 | 0 | 0 | 2.31 KB |
| #6306 | SendAsync |
netcoreapp3.1 | 5.32μs | 3.07ns | 11.9ns | 0.0374 | 0 | 0 | 2.85 KB |
| #6306 | SendAsync |
net472 | 7.27μs | 1.84ns | 7.12ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.46μs | 0.883ns | 3.42ns | 0.0233 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.29μs | 1.76ns | 6.8ns | 0.0217 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.59μs | 0.789ns | 3.06ns | 0.25 | 0 | 0 | 1.57 KB |
| #6306 | EnrichedLog |
net6.0 | 1.46μs | 0.855ns | 3.08ns | 0.0227 | 0 | 0 | 1.64 KB |
| #6306 | EnrichedLog |
netcoreapp3.1 | 2.36μs | 1.42ns | 5.11ns | 0.0213 | 0 | 0 | 1.64 KB |
| #6306 | EnrichedLog |
net472 | 2.58μs | 1.15ns | 4.3ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 121μs | 141ns | 546ns | 0.0608 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 124μs | 149ns | 558ns | 0 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 151μs | 158ns | 610ns | 0.679 | 0.226 | 0 | 4.46 KB |
| #6306 | EnrichedLog |
net6.0 | 119μs | 161ns | 625ns | 0.0603 | 0 | 0 | 4.28 KB |
| #6306 | EnrichedLog |
netcoreapp3.1 | 124μs | 192ns | 743ns | 0 | 0 | 0 | 4.28 KB |
| #6306 | EnrichedLog |
net472 | 152μs | 132ns | 511ns | 0.68 | 0.227 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 3.11μs | 1.33ns | 5.17ns | 0.031 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.07μs | 3.54ns | 13.2ns | 0.029 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 4.83μs | 1.34ns | 4.84ns | 0.32 | 0 | 0 | 2.02 KB |
| #6306 | EnrichedLog |
net6.0 | 3.2μs | 1.46ns | 5.46ns | 0.0305 | 0 | 0 | 2.2 KB |
| #6306 | EnrichedLog |
netcoreapp3.1 | 4.07μs | 1.99ns | 7.45ns | 0.0285 | 0 | 0 | 2.2 KB |
| #6306 | EnrichedLog |
net472 | 4.94μs | 1.61ns | 6.22ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.36μs | 0.618ns | 2.39ns | 0.0156 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.72μs | 0.694ns | 2.6ns | 0.0154 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.06μs | 1.37ns | 5.29ns | 0.183 | 0 | 0 | 1.16 KB |
| #6306 | SendReceive |
net6.0 | 1.38μs | 0.638ns | 2.47ns | 0.0158 | 0 | 0 | 1.14 KB |
| #6306 | SendReceive |
netcoreapp3.1 | 1.76μs | 0.788ns | 3.05ns | 0.0151 | 0 | 0 | 1.14 KB |
| #6306 | SendReceive |
net472 | 2.11μs | 1.03ns | 3.99ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.61μs | 1.05ns | 4.08ns | 0.0222 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.86μs | 1.51ns | 5.85ns | 0.0212 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.46μs | 9.76ns | 37.8ns | 0.323 | 0 | 0 | 2.04 KB |
| #6306 | EnrichedLog |
net6.0 | 2.67μs | 0.667ns | 2.49ns | 0.0226 | 0 | 0 | 1.6 KB |
| #6306 | EnrichedLog |
netcoreapp3.1 | 3.98μs | 2.68ns | 10.4ns | 0.022 | 0 | 0 | 1.65 KB |
| #6306 | EnrichedLog |
net472 | 4.28μs | 1.73ns | 6.46ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6306
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
1.158
684.12
590.88
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.158 | 684.12 | 590.88 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 409ns | 0.34ns | 1.27ns | 0.00809 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 592ns | 0.712ns | 2.57ns | 0.00787 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 683ns | 1.31ns | 5.08ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 498ns | 0.668ns | 2.59ns | 0.00975 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 800ns | 0.939ns | 3.64ns | 0.00933 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 865ns | 0.693ns | 2.68ns | 0.104 | 0 | 0 | 658 B |
| #6306 | StartFinishSpan |
net6.0 | 417ns | 0.351ns | 1.26ns | 0.00816 | 0 | 0 | 576 B |
| #6306 | StartFinishSpan |
netcoreapp3.1 | 596ns | 1.03ns | 3.98ns | 0.00776 | 0 | 0 | 576 B |
| #6306 | StartFinishSpan |
net472 | 590ns | 0.287ns | 1.11ns | 0.0915 | 0 | 0 | 578 B |
| #6306 | StartFinishScope |
net6.0 | 543ns | 0.407ns | 1.58ns | 0.00985 | 0 | 0 | 696 B |
| #6306 | StartFinishScope |
netcoreapp3.1 | 745ns | 0.798ns | 3.09ns | 0.00929 | 0 | 0 | 696 B |
| #6306 | StartFinishScope |
net472 | 884ns | 0.71ns | 2.75ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 651ns | 0.553ns | 2.07ns | 0.00982 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 957ns | 1.03ns | 4ns | 0.00904 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.15μs | 1.35ns | 5.21ns | 0.104 | 0 | 0 | 658 B |
| #6306 | RunOnMethodBegin |
net6.0 | 648ns | 0.395ns | 1.53ns | 0.00976 | 0 | 0 | 696 B |
| #6306 | RunOnMethodBegin |
netcoreapp3.1 | 926ns | 1.1ns | 4.26ns | 0.00932 | 0 | 0 | 696 B |
| #6306 | RunOnMethodBegin |
net472 | 1.14μs | 1.17ns | 4.37ns | 0.104 | 0 | 0 | 658 B |
|
Closing as stale, bot can always reopen the next time |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps InlineIL.Fody from 1.8.0 to 1.10.0.
Release notes
Sourced from InlineIL.Fody's releases.
Commits
feb854ev1.10.0baecf8fFix opcode typos in xml docsa7bd763Use Fody 6.9.02f9851fAdd allows ref structc672114net9.0a9dce13Update packagesa1d7d3aFix build for netstandard1.150ec036v1.9.022fdf3eAdd testd6e9c46Update packagesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)