Skip to content

[Dynamic Instrumentation] DEBUG-3695 Return correct RC apply details #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2025
Merged

[Dynamic Instrumentation] DEBUG-3695 Return correct RC apply details #6890

merged 4 commits into from
Oct 16, 2025

Conversation

@dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Apr 24, 2025

Summary of changes

The debugger does not return correct appy details to RC, what cause to all request to display status of unacknowledge and make it hard to debug errors. This PR fix that and now we are returning the correct status.

@dudikeleti dudikeleti requested a review from a team as a code owner April 24, 2025 08:40
@dudikeleti dudikeleti requested a review from GreenMatan April 24, 2025 08:41
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 24, 2025 •
edited
Loading

Datadog Report

All test runs 24bae08 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
⌛ 1 with Regressions

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Performance Regressions Test Service View
dd-trace-dotnet 0 0 0 258311 3354 44h 53m 57.5s 1 Link
exploration_tests 0 0 0 7433 0 10m 14.12s 0 Link

⌛ Performance Regressions vs Default Branch (1)

  • CallTarget+Inlining+NGEN - Samples.HttpMessageHandler.windows.net462.json.scenarios 1.16s (+51.1ms, +5%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6890 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.143
  • 2 benchmarks are slower, with geometric mean 2.416
  • 8 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.74 KB 5.68 KB -60 B -1.04%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.9μs 58.4ns 330ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 14.8μs 71.5ns 286ns 0 0 0 5.74 KB
master StartStopWithChild net472 21.9μs 109ns 511ns 0.958 0.426 0.106 6 KB
#6890 StartStopWithChild net6.0 11.1μs 55.2ns 253ns 0 0 0 5.52 KB
#6890 StartStopWithChild netcoreapp3.1 13.6μs 70.5ns 331ns 0 0 0 5.68 KB
#6890 StartStopWithChild net472 22.7μs 108ns 443ns 1.01 0.337 0.112 6.01 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 943μs 144ns 558ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 45.9ns 172ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 82.2ns 318ns 0 0 0 3.31 KB
#6890 WriteAndFlushEnrichedTraces net6.0 923μs 66ns 238ns 0 0 0 2.71 KB
#6890 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 184ns 689ns 0 0 0 2.7 KB
#6890 WriteAndFlushEnrichedTraces net472 1.19ms 58ns 217ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 355μs 1.84μs 8.63μs 0 0 0 180.01 KB
master AllCycleSimpleBody netcoreapp3.1 523μs 1.68μs 7.7μs 0 0 0 185.8 KB
master AllCycleSimpleBody net472 469μs 157ns 607ns 32.4 0 0 206.3 KB
master AllCycleMoreComplexBody net6.0 367μs 1.23μs 4.78μs 0 0 0 183.53 KB
master AllCycleMoreComplexBody netcoreapp3.1 552μs 636ns 2.46μs 0 0 0 189.23 KB
master AllCycleMoreComplexBody net472 480μs 74.7ns 269ns 31.2 0 0 209.83 KB
master ObjectExtractorSimpleBody net6.0 330ns 1.62ns 7.08ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 1.97ns 8.57ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0313ns 0.117ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.24μs 33.6ns 121ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 39.5ns 185ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.68μs 3.02ns 11.7ns 0.6 0 0 3.8 KB
#6890 AllCycleSimpleBody net6.0 356μs 1.48μs 5.13μs 0 0 0 180.01 KB
#6890 AllCycleSimpleBody netcoreapp3.1 534μs 285ns 1.03μs 0 0 0 185.8 KB
#6890 AllCycleSimpleBody net472 469μs 245ns 949ns 32.4 0 0 206.3 KB
#6890 AllCycleMoreComplexBody net6.0 366μs 1.44μs 5.56μs 0 0 0 183.53 KB
#6890 AllCycleMoreComplexBody netcoreapp3.1 549μs 1.49μs 5.36μs 0 0 0 189.23 KB
#6890 AllCycleMoreComplexBody net472 481μs 127ns 476ns 31.2 0 0 209.83 KB
#6890 ObjectExtractorSimpleBody net6.0 324ns 0.193ns 0.746ns 0 0 0 280 B
#6890 ObjectExtractorSimpleBody netcoreapp3.1 402ns 1.97ns 8.34ns 0 0 0 272 B
#6890 ObjectExtractorSimpleBody net472 299ns 0.0529ns 0.205ns 0.0437 0 0 281 B
#6890 ObjectExtractorMoreComplexBody net6.0 6.3μs 31.8ns 149ns 0 0 0 3.78 KB
#6890 ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 36.9ns 147ns 0 0 0 3.69 KB
#6890 ObjectExtractorMoreComplexBody net472 6.63μs 4.12ns 16ns 0.599 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 209ns 808ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.1μs 327ns 1.27μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 14.2ns 55.1ns 4.93 0 0 32.5 KB
master EncodeLegacyArgs net6.0 146μs 36.9ns 138ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 196μs 172ns 666ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 262μs 23.9ns 89.4ns 0 0 0 2.16 KB
#6890 EncodeArgs net6.0 76.4μs 211ns 761ns 0 0 0 32.4 KB
#6890 EncodeArgs netcoreapp3.1 97.2μs 246ns 951ns 0 0 0 32.4 KB
#6890 EncodeArgs net472 109μs 46.4ns 180ns 4.91 0 0 32.51 KB
#6890 EncodeLegacyArgs net6.0 147μs 283ns 1.1μs 0 0 0 2.15 KB
#6890 EncodeLegacyArgs netcoreapp3.1 199μs 249ns 931ns 0 0 0 2.14 KB
#6890 EncodeLegacyArgs net472 263μs 88.6ns 343ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #6890

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.398 300,639.79 720,791.15

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.3 KB 2.29 KB -13 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 405μs 45.1ns 175ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 845μs 7.21μs 71.4μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 45.4ns 176ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 288μs 34.7ns 125ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 301μs 45.7ns 177ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 312μs 35.2ns 136ns 0 0 0 2.3 KB
#6890 RunWafRealisticBenchmark net6.0 397μs 89.2ns 334ns 0 0 0 4.56 KB
#6890 RunWafRealisticBenchmark netcoreapp3.1 801μs 15.2μs 142μs 0 0 0 4.48 KB
#6890 RunWafRealisticBenchmark net472 426μs 43.3ns 168ns 0 0 0 4.66 KB
#6890 RunWafRealisticBenchmarkWithAttack net6.0 286μs 55.8ns 209ns 0 0 0 2.24 KB
#6890 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 718μs 3.35μs 13μs 0 0 0 2.22 KB
#6890 RunWafRealisticBenchmarkWithAttack net472 316μs 29.2ns 113ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 97.1ns 388ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.3μs 72.5ns 271ns 0 0 0 17.42 KB
master SendRequest net472 0.000824ns 0.000615ns 0.00238ns 0 0 0 0 b
#6890 SendRequest net6.0 60.8μs 51.6ns 200ns 0 0 0 14.52 KB
#6890 SendRequest netcoreapp3.1 70.8μs 89.4ns 322ns 0 0 0 17.42 KB
#6890 SendRequest net472 0.00746ns 0.00179ns 0.00693ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 462ns 1.67μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.12ms 919ns 3.18μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 403ns 1.51μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.34ms 469ns 1.82μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 794ns 2.97μs 0 0 0 1 B
master OptimizedCharSlice net472 1.96ms 303ns 1.17μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 799μs 66.6ns 258ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 828μs 94.8ns 367ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 98.4ns 381ns 0 0 0 47 B
#6890 OriginalCharSlice net6.0 1.87ms 248ns 928ns 0 0 0 640 KB
#6890 OriginalCharSlice netcoreapp3.1 2.22ms 671ns 2.42μs 0 0 0 640 KB
#6890 OriginalCharSlice net472 2.62ms 205ns 769ns 100 0 0 641.95 KB
#6890 OptimizedCharSlice net6.0 1.47ms 155ns 600ns 0 0 0 4 B
#6890 OptimizedCharSlice netcoreapp3.1 1.65ms 358ns 1.39μs 0 0 0 1 B
#6890 OptimizedCharSlice net472 2.13ms 190ns 709ns 0 0 0 0 b
#6890 OptimizedCharSliceWithPool net6.0 861μs 104ns 401ns 0 0 0 3 B
#6890 OptimizedCharSliceWithPool netcoreapp3.1 892μs 39.9ns 144ns 0 0 0 1 B
#6890 OptimizedCharSliceWithPool net472 1.13ms 67.1ns 251ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6890

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.143 724,798.75 634,114.90

More allocations ⚠️ in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.86 KB 42.15 KB 284 B 0.68%

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.63 KB 56.08 KB -547 B -0.97%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 671μs 2.44μs 9.44μs 0 0 0 42.04 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 1.26μs 4.54μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 878μs 3.99μs 14.9μs 8.33 0 0 56.63 KB
#6890 WriteAndFlushEnrichedTraces net6.0 696μs 3.57μs 16.3μs 0 0 0 42.07 KB
#6890 WriteAndFlushEnrichedTraces netcoreapp3.1 649μs 3.42μs 31.4μs 0 0 0 42.15 KB
#6890 WriteAndFlushEnrichedTraces net472 942μs 2.11μs 8.18μs 8.33 0 0 56.08 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 1.41ns 5.47ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.54μs 5.69ns 22ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.79μs 3.37ns 12.2ns 0.153 0.0139 0 987 B
#6890 ExecuteNonQuery net6.0 1.94μs 2.65ns 10.3ns 0 0 0 1.02 KB
#6890 ExecuteNonQuery netcoreapp3.1 2.6μs 2.82ns 10.5ns 0 0 0 1.02 KB
#6890 ExecuteNonQuery net472 3μs 5.22ns 18.8ns 0.149 0.0149 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 0.913ns 3.42ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.7ns 53.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.63μs 5.43ns 21ns 0.163 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.97μs 9.43ns 40ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 9.88ns 38.3ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.89μs 4.99ns 18.7ns 0.155 0 0 1.1 KB
#6890 CallElasticsearch net6.0 1.79μs 8.6ns 35.5ns 0 0 0 1.03 KB
#6890 CallElasticsearch netcoreapp3.1 2.31μs 10.3ns 38.5ns 0 0 0 1.03 KB
#6890 CallElasticsearch net472 3.65μs 5.16ns 20ns 0.164 0 0 1.04 KB
#6890 CallElasticsearchAsync net6.0 1.86μs 1.52ns 5.9ns 0 0 0 1.01 KB
#6890 CallElasticsearchAsync netcoreapp3.1 2.38μs 11.5ns 44.4ns 0 0 0 1.08 KB
#6890 CallElasticsearchAsync net472 3.8μs 8.45ns 32.7ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.92μs 8.88ns 35.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.35μs 3.63ns 13.6ns 0 0 0 952 B
master ExecuteAsync net472 2.6μs 3.82ns 14.8ns 0.142 0 0 915 B
#6890 ExecuteAsync net6.0 1.83μs 4.09ns 15.9ns 0 0 0 952 B
#6890 ExecuteAsync netcoreapp3.1 2.34μs 11.1ns 47.3ns 0 0 0 952 B
#6890 ExecuteAsync net472 2.55μs 3.87ns 15ns 0.139 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.87μs 6.27ns 24.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 19.2ns 74.3ns 0 0 0 2.9 KB
master SendAsync net472 12.7μs 10ns 37.5ns 0.444 0 0 3.18 KB
#6890 SendAsync net6.0 6.8μs 6.99ns 25.2ns 0 0 0 2.36 KB
#6890 SendAsync netcoreapp3.1 8.31μs 20ns 77.3ns 0 0 0 2.9 KB
#6890 SendAsync net472 12.5μs 11.2ns 43.2ns 0.499 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #6890

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 2.434 542,200.00 1,319,900.00

More allocations ⚠️ in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 279.94 KB 319.57 KB 39.63 KB 14.16%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.93 KB 273.11 KB 13.18 KB 5.07%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.72 KB 8.19 KB 2.94%

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 43.28 KB 42.78 KB -496 B -1.15%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 46.09 KB 44.05 KB -2.04 KB -4.43%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45μs 244ns 1.86μs 0 0 0 46.09 KB
master StringConcatBenchmark netcoreapp3.1 51μs 271ns 1.84μs 0 0 0 43.28 KB
master StringConcatBenchmark net472 56.2μs 239ns 893ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 462μs 1.42μs 4.92μs 0 0 0 259.93 KB
master StringConcatAspectBenchmark netcoreapp3.1 542μs 1.79μs 6.68μs 0 0 0 279.94 KB
master StringConcatAspectBenchmark net472 406μs 2.33μs 17.8μs 0 0 0 278.53 KB
#6890 StringConcatBenchmark net6.0 42μs 205ns 1.28μs 0 0 0 44.05 KB
#6890 StringConcatBenchmark netcoreapp3.1 51.7μs 391ns 3.77μs 0 0 0 42.78 KB
#6890 StringConcatBenchmark net472 55.7μs 264ns 1.09μs 0 0 0 57.34 KB
#6890 StringConcatAspectBenchmark net6.0 502μs 1.3μs 6.08μs 0 0 0 273.11 KB
#6890 StringConcatAspectBenchmark netcoreapp3.1 1.32ms 1.9μs 7.34μs 0 0 0 319.57 KB
#6890 StringConcatAspectBenchmark net472 409μs 2.11μs 9.88μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 7.61ns 28.5ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.61μs 4.24ns 16.4ns 0 0 0 1.7 KB
master EnrichedLog net472 3.75μs 3.22ns 12.5ns 0.243 0 0 1.64 KB
#6890 EnrichedLog net6.0 2.55μs 2.94ns 11.4ns 0 0 0 1.7 KB
#6890 EnrichedLog netcoreapp3.1 3.56μs 17.8ns 79.6ns 0 0 0 1.7 KB
#6890 EnrichedLog net472 3.77μs 4.41ns 17.1ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 31.2ns 117ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 133ns 480ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 47.7ns 178ns 0 0 0 4.52 KB
#6890 EnrichedLog net6.0 124μs 381ns 1.48μs 0 0 0 4.31 KB
#6890 EnrichedLog netcoreapp3.1 127μs 216ns 836ns 0 0 0 4.31 KB
#6890 EnrichedLog net472 165μs 79ns 274ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 24.6ns 116ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.74μs 20ns 77.5ns 0 0 0 2.26 KB
master EnrichedLog net472 7.35μs 7.72ns 29.9ns 0.294 0 0 2.08 KB
#6890 EnrichedLog net6.0 5.07μs 5.22ns 20.2ns 0 0 0 2.26 KB
#6890 EnrichedLog netcoreapp3.1 6.91μs 13.9ns 54ns 0 0 0 2.26 KB
#6890 EnrichedLog net472 7.45μs 8.28ns 32.1ns 0.296 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.96μs 10.5ns 57.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.63μs 12ns 45ns 0 0 0 1.2 KB
master SendReceive net472 3.17μs 2.85ns 11ns 0.189 0 0 1.2 KB
#6890 SendReceive net6.0 1.99μs 1.3ns 5.04ns 0 0 0 1.2 KB
#6890 SendReceive netcoreapp3.1 2.65μs 6.47ns 25ns 0 0 0 1.2 KB
#6890 SendReceive net472 3.21μs 3.18ns 12.3ns 0.191 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.27μs 14.5ns 56.2ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.72μs 7.47ns 28ns 0 0 0 1.63 KB
master EnrichedLog net472 6.44μs 3.42ns 13.2ns 0.291 0 0 2.03 KB
#6890 EnrichedLog net6.0 4.31μs 19.9ns 79.6ns 0 0 0 1.58 KB
#6890 EnrichedLog netcoreapp3.1 5.79μs 6.03ns 22.6ns 0 0 0 1.63 KB
#6890 EnrichedLog net472 6.56μs 8.94ns 34.6ns 0.294 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 767ns 0.551ns 2.13ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 964ns 4.96ns 23.3ns 0 0 0 576 B
master StartFinishSpan net472 905ns 0.375ns 1.4ns 0.0905 0 0 578 B
master StartFinishScope net6.0 909ns 4.68ns 23ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 5.81ns 23.2ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 0.0482ns 0.174ns 0.102 0 0 658 B
#6890 StartFinishSpan net6.0 777ns 0.295ns 1.14ns 0 0 0 576 B
#6890 StartFinishSpan netcoreapp3.1 952ns 4.83ns 22.1ns 0 0 0 576 B
#6890 StartFinishSpan net472 914ns 0.31ns 1.2ns 0.0916 0 0 578 B
#6890 StartFinishScope net6.0 911ns 0.274ns 1.03ns 0 0 0 696 B
#6890 StartFinishScope netcoreapp3.1 1.21μs 5.88ns 23.5ns 0 0 0 696 B
#6890 StartFinishScope net472 1.16μs 0.128ns 0.496ns 0.0991 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 5.67ns 34.9ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.93ns 31ns 0 0 0 696 B
master RunOnMethodBegin net472 1.41μs 0.647ns 2.42ns 0.101 0 0 658 B
#6890 RunOnMethodBegin net6.0 1.05μs 4.37ns 16.9ns 0 0 0 696 B
#6890 RunOnMethodBegin netcoreapp3.1 1.42μs 7.2ns 31.4ns 0 0 0 696 B
#6890 RunOnMethodBegin net472 1.4μs 0.561ns 2.17ns 0.0983 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Apr 24, 2025

Benchmarks Report for tracer 🐌

Benchmarks for #6890 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.127
  • 1 benchmarks are slower, with geometric mean 1.131
  • 1 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.13 KB 6.19 KB 61 B 0.99%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.57 KB 5.62 KB 54 B 0.97%

Fewer allocations 🎉 in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.73 KB 5.7 KB -32 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.74μs 90.1ns 896ns 0 0 0 5.57 KB
master StartStopWithChild netcoreapp3.1 10.1μs 148ns 1.48μs 0 0 0 5.73 KB
master StartStopWithChild net472 15.3μs 87.8ns 697ns 1.04 0.297 0.0741 6.13 KB
#6890 StartStopWithChild net6.0 8.01μs 120ns 1.2μs 0 0 0 5.62 KB
#6890 StartStopWithChild netcoreapp3.1 10.4μs 168ns 1.68μs 0 0 0 5.7 KB
#6890 StartStopWithChild net472 15.1μs 84.9ns 569ns 1.01 0.337 0.135 6.19 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6890

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 34 B 1.03%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 513μs 5.69μs 50.6μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 854ns 3.19μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 841μs 2.7μs 10.1μs 0 0 0 3.31 KB
#6890 WriteAndFlushEnrichedTraces net6.0 523μs 388ns 1.4μs 0 0 0 2.7 KB
#6890 WriteAndFlushEnrichedTraces netcoreapp3.1 667μs 2.79μs 10.1μs 0 0 0 2.7 KB
#6890 WriteAndFlushEnrichedTraces net472 873μs 3.68μs 14.7μs 0 0 0 3.35 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 127μs 626ns 2.66μs 0 0 0 14.48 KB
master SendRequest netcoreapp3.1 141μs 821ns 7.15μs 0 0 0 17.28 KB
master SendRequest net472 0.00158ns 0.000518ns 0.00201ns 0 0 0 0 b
#6890 SendRequest net6.0 131μs 748ns 5.5μs 0 0 0 14.48 KB
#6890 SendRequest netcoreapp3.1 148μs 677ns 2.62μs 0 0 0 17.28 KB
#6890 SendRequest net472 0.00569ns 0.00139ns 0.00539ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 653μs 7.16μs 70.9μs 0 0 0 41.81 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 745μs 8.26μs 80.5μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 871μs 4.95μs 46.7μs 7.35 3.68 0 53.37 KB
#6890 WriteAndFlushEnrichedTraces net6.0 582μs 3.38μs 32.1μs 0 0 0 41.64 KB
#6890 WriteAndFlushEnrichedTraces netcoreapp3.1 729μs 7.7μs 75.4μs 0 0 0 41.86 KB
#6890 WriteAndFlushEnrichedTraces net472 873μs 5.91μs 58.8μs 4.46 0 0 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 3.03ns 11.3ns 0.0129 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 3.2ns 11.1ns 0.00901 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 1.56ns 5.83ns 0.153 0.0109 0 995 B
#6890 ExecuteNonQuery net6.0 1.3μs 1.66ns 6.22ns 0.0131 0 0 1.03 KB
#6890 ExecuteNonQuery netcoreapp3.1 1.75μs 5.25ns 20.3ns 0.00862 0 0 1.02 KB
#6890 ExecuteNonQuery net472 1.98μs 2.43ns 9.41ns 0.149 0.00991 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 1.17ns 4.53ns 0.0133 0 0 984 B
master CallElasticsearch netcoreapp3.1 1.6μs 1.34ns 4.83ns 0.00809 0 0 984 B
master CallElasticsearch net472 2.58μs 1.38ns 4.98ns 0.154 0 0 1 KB
master CallElasticsearchAsync net6.0 1.28μs 1.58ns 6.13ns 0.0126 0 0 960 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 1.34ns 5.17ns 0.00864 0 0 1.03 KB
master CallElasticsearchAsync net472 2.6μs 1.17ns 4.53ns 0.156 0 0 1.06 KB
#6890 CallElasticsearch net6.0 1.22μs 2.13ns 7.68ns 0.0122 0 0 984 B
#6890 CallElasticsearch netcoreapp3.1 1.57μs 3.15ns 11.8ns 0.00791 0 0 984 B
#6890 CallElasticsearch net472 2.46μs 1.86ns 6.95ns 0.148 0 0 1 KB
#6890 CallElasticsearchAsync net6.0 1.27μs 1.53ns 5.74ns 0.0128 0 0 960 B
#6890 CallElasticsearchAsync netcoreapp3.1 1.63μs 1.08ns 3.75ns 0.00819 0 0 1.03 KB
#6890 CallElasticsearchAsync net472 2.65μs 2.43ns 9.42ns 0.159 0 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 0.862ns 3.23ns 0.0135 0 0 960 B
master ExecuteAsync netcoreapp3.1 1.62μs 1.7ns 6.12ns 0.00819 0 0 960 B
master ExecuteAsync net472 1.81μs 0.999ns 3.74ns 0.145 0 0 923 B
#6890 ExecuteAsync net6.0 1.39μs 1.76ns 6.8ns 0.0139 0 0 960 B
#6890 ExecuteAsync netcoreapp3.1 1.58μs 0.982ns 3.8ns 0.00791 0 0 960 B
#6890 ExecuteAsync net472 1.76μs 1.98ns 7.12ns 0.14 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.4μs 1.76ns 6.09ns 0.0221 0 0 2.32 KB
master SendAsync netcoreapp3.1 5.29μs 9.69ns 37.5ns 0.0263 0 0 2.86 KB
master SendAsync net472 7.45μs 5.2ns 19.5ns 0.49 0 0 3.13 KB
#6890 SendAsync net6.0 4.47μs 2.47ns 9.57ns 0.0224 0 0 2.32 KB
#6890 SendAsync netcoreapp3.1 5.3μs 4.31ns 16.7ns 0.0263 0 0 2.86 KB
#6890 SendAsync net472 7.52μs 5.01ns 18.1ns 0.487 0 0 3.13 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6890

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.127 1,679.31 1,490.15

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.68μs 1.82ns 7.07ns 0.0168 0 0 1.71 KB
master EnrichedLog netcoreapp3.1 2.34μs 1.83ns 7.09ns 0.0118 0 0 1.71 KB
master EnrichedLog net472 2.65μs 1.81ns 7.02ns 0.25 0 0 1.64 KB
#6890 EnrichedLog net6.0 1.49μs 1.58ns 6.14ns 0.0221 0 0 1.71 KB
#6890 EnrichedLog netcoreapp3.1 2.19μs 2.21ns 8.26ns 0.0218 0 0 1.71 KB
#6890 EnrichedLog net472 2.65μs 1.69ns 6.53ns 0.252 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 295ns 1.14μs 0 0 0 4.32 KB
master EnrichedLog netcoreapp3.1 115μs 424ns 1.64μs 0 0 0 4.32 KB
master EnrichedLog net472 149μs 226ns 876ns 0 0 0 4.51 KB
#6890 EnrichedLog net6.0 112μs 161ns 623ns 0 0 0 4.32 KB
#6890 EnrichedLog netcoreapp3.1 115μs 196ns 760ns 0 0 0 4.32 KB
#6890 EnrichedLog net472 153μs 167ns 647ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.26μs 2.4ns 9.29ns 0.0331 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 4.27μs 5.13ns 19.9ns 0.0214 0 0 2.26 KB
master EnrichedLog net472 4.89μs 3.09ns 12ns 0.318 0 0 2.09 KB
#6890 EnrichedLog net6.0 3.07μs 1.85ns 6.91ns 0.0305 0 0 2.26 KB
#6890 EnrichedLog netcoreapp3.1 4.22μs 2.69ns 9.7ns 0.0211 0 0 2.26 KB
#6890 EnrichedLog net472 4.93μs 2.79ns 10.8ns 0.321 0 0 2.09 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 1.14ns 4.41ns 0.0138 0 0 1.15 KB
master SendReceive netcoreapp3.1 1.8μs 1.13ns 4.22ns 0.00907 0 0 1.15 KB
master SendReceive net472 2.16μs 1.57ns 6.06ns 0.179 0 0 1.16 KB
#6890 SendReceive net6.0 1.4μs 0.581ns 2.18ns 0.0141 0 0 1.15 KB
#6890 SendReceive netcoreapp3.1 1.76μs 2.76ns 10.3ns 0.00879 0 0 1.15 KB
#6890 SendReceive net472 2.11μs 0.71ns 2.75ns 0.18 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 1.73ns 6.69ns 0.0142 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.18ns 7.85ns 0.0194 0 0 1.69 KB
master EnrichedLog net472 4.46μs 2.75ns 10.6ns 0.313 0 0 2.08 KB
#6890 EnrichedLog net6.0 2.74μs 3.6ns 13.9ns 0.0137 0 0 1.64 KB
#6890 EnrichedLog netcoreapp3.1 3.94μs 2.08ns 7.5ns 0.0198 0 0 1.69 KB
#6890 EnrichedLog net472 4.48μs 4.4ns 17ns 0.311 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 412ns 0.354ns 1.32ns 0.00815 0 0 584 B
master StartFinishSpan netcoreapp3.1 582ns 0.765ns 2.96ns 0.00573 0 0 584 B
master StartFinishSpan net472 658ns 0.658ns 2.37ns 0.0922 0 0 586 B
master StartFinishScope net6.0 492ns 0.316ns 1.18ns 0.00975 0 0 704 B
master StartFinishScope netcoreapp3.1 752ns 0.69ns 2.58ns 0.00755 0 0 704 B
master StartFinishScope net472 838ns 0.778ns 3.01ns 0.105 0 0 666 B
#6890 StartFinishSpan net6.0 403ns 0.393ns 1.52ns 0.00804 0 0 584 B
#6890 StartFinishSpan netcoreapp3.1 592ns 0.719ns 2.69ns 0.00611 0 0 584 B
#6890 StartFinishSpan net472 600ns 0.443ns 1.66ns 0.0931 0 0 586 B
#6890 StartFinishScope net6.0 500ns 0.317ns 1.14ns 0.00994 0 0 704 B
#6890 StartFinishScope netcoreapp3.1 678ns 0.555ns 2ns 0.00676 0 0 704 B
#6890 StartFinishScope net472 839ns 0.532ns 1.99ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6890

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.131 597.07 675.54

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 597ns 0.475ns 1.84ns 0.00901 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1μs 1.28ns 4.78ns 0.00501 0 0 704 B
master RunOnMethodBegin net472 1.14μs 1.45ns 5.62ns 0.102 0 0 666 B
#6890 RunOnMethodBegin net6.0 677ns 0.699ns 2.71ns 0.0101 0 0 704 B
#6890 RunOnMethodBegin netcoreapp3.1 944ns 1.22ns 4.55ns 0.00947 0 0 704 B
#6890 RunOnMethodBegin net472 1.02μs 0.506ns 1.96ns 0.103 0 0 666 B

@andrewlock
Copy link
Member

andrewlock commented Apr 24, 2025 •
edited by dd-trace-dotnet-ci-bot bot
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (74ms)  : 72, 76
     .   : milestone, 74,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (6890) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (1,074ms)  : 1005, 1144
     .   : milestone, 1074,
    master - mean (1,046ms)  : 1008, 1084
     .   : milestone, 1046,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (110ms)  : 108, 113
     .   : milestone, 110,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (6890) - mean (110ms)  : 103, 118
     .   : milestone, 110,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (759ms)  : 728, 790
     .   : milestone, 759,
    master - mean (744ms)  : 719, 769
     .   : milestone, 744,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (98ms)  : 95, 100
     .   : milestone, 98,
    master - mean (101ms)  : 100, 102
     .   : milestone, 101,

    section Baseline
    This PR (6890) - mean (97ms)  : 94, 100
     .   : milestone, 97,
    master - mean (100ms)  : 97, 102
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (723ms)  : 686, 760
     .   : milestone, 723,
    master - mean (776ms)  : 729, 824
     .   : milestone, 776,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (97ms)  : 95, 99
     .   : milestone, 97,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section Baseline
    This PR (6890) - mean (96ms)  : 93, 100
     .   : milestone, 96,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (674ms)  : 652, 697
     .   : milestone, 674,
    master - mean (661ms)  : 648, 674
     .   : milestone, 661,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (198ms)  : 194, 202
     .   : milestone, 198,
    master - mean (195ms)  : 193, 198
     .   : milestone, 195,

    section Baseline
    This PR (6890) - mean (193ms)  : 190, 197
     .   : milestone, 193,
    master - mean (192ms)  : 188, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (1,200ms)  : 1105, 1295
     .   : milestone, 1200,
    master - mean (1,163ms)  : 1108, 1218
     .   : milestone, 1163,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (283ms)  : 275, 290
     .   : milestone, 283,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section Baseline
    This PR (6890) - mean (281ms)  : 274, 288
     .   : milestone, 281,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (977ms)  : 930, 1025
     .   : milestone, 977,
    master - mean (946ms)  : 909, 984
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (276ms)  : 268, 284
     .   : milestone, 276,
    master - mean (280ms)  : 275, 285
     .   : milestone, 280,

    section Baseline
    This PR (6890) - mean (278ms)  : 265, 291
     .   : milestone, 278,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (952ms)  : 895, 1010
     .   : milestone, 952,
    master - mean (996ms)  : 953, 1040
     .   : milestone, 996,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6890) - mean (278ms)  : 267, 289
     .   : milestone, 278,
    master - mean (268ms)  : 263, 272
     .   : milestone, 268,

    section Baseline
    This PR (6890) - mean (275ms)  : 263, 288
     .   : milestone, 275,
    master - mean (267ms)  : 264, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6890) - mean (877ms)  : 846, 908
     .   : milestone, 877,
    master - mean (857ms)  : 835, 880
     .   : milestone, 857,
Loading

@dudikeleti dudikeleti removed the request for review from GreenMatan October 9, 2025 16:26
@dudikeleti dudikeleti force-pushed the dudik/return-rc-apply-details branch from 24bae08 to 4f83bfa Compare October 10, 2025 13:29
@dudikeleti dudikeleti force-pushed the dudik/return-rc-apply-details branch from 4f83bfa to 59886ad Compare October 16, 2025 15:39
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dudikeleti dudikeleti merged commit 4c24df6 into master Oct 16, 2025
154 of 157 checks passed
@dudikeleti dudikeleti deleted the dudik/return-rc-apply-details branch October 16, 2025 16:53
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylfin tylfin tylfin approved these changes

Assignees

No one assigned

Labels

area:debugger

Projects

None yet

Milestone

3.29.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dudikeleti @andrewlock @tylfin @apps-by-pooh