-
Notifications
You must be signed in to change notification settings - Fork 150
Ignore the test filter for RunWindowsAzureFunctionsTests
#7611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When setting the filter we will hit this test stage, but since we only compile the Azure Functions Samples here we will hit an application not found issue. We should look into this to make it better though
|
Issue came up in #7192 when doing a comprehensive test run scoped to those tests. |
NachoEchevarria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
andrewlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying, but I'm not sure this will actually solve the problem? 🤔
| .EnableNoRestore() | ||
| .EnableNoBuild() | ||
| .SetFilter(string.IsNullOrWhiteSpace(Filter) ? "(RunOnWindows=True)&(Category=AzureFunctions)&(SkipInCI!=True)" : Filter) | ||
| .SetFilter("(RunOnWindows=True)&(Category=AzureFunctions)&(SkipInCI!=True)") // FIXME: ignoring the global Filter as when set it may cause issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Will this actually solve the problem? The problem is typically that we're not building the same apps. With this change, it means we will always run the azure functions tests, but that won't change the fact that we aren't building the samples, right?
On the assumption that you always specify both, maybe we should actually just always & these instead? e.g.🤔
| .SetFilter("(RunOnWindows=True)&(Category=AzureFunctions)&(SkipInCI!=True)") // FIXME: ignoring the global Filter as when set it may cause issues | |
| .SetFilter($"(RunOnWindows=True)&(Category=AzureFunctions)&(SkipInCI!=True){(string.IsNullOrWhiteSpace(Filter)? "" : "&" + Filter)}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about this over the weekend and would rather not do this at all and just let it fail, I think it is a reasonable failure for some PRs as we don't do this that much so asking to re-run the normal pipeline is better (or ideally getting it to not link to the PR at all) - I wasn't sure how the build was actually ran.
|
Closing as can just re-run the normal pipeline |
Summary of changes
This removes the ability to change the test filter that is used when running the Azure Functions Tests and it will just fallback on the default values.
Reason for change
When someone sets the test filter for a CI build to something that requires a sample project that is not an Azure Functions sample app this stage will fail at it cannot find the sample application as only Azure Function samples are build prior to this stage.
We don't build all of the sample applications when running these as that takes significant time.
We have these in their own stage because they are a pain to build and test.
Implementation details
.SetFilterjust always uses the default.Test coverage
Other details
Can likely fix this betterer some how, maybe just a new separate test filter, but I actually don't know how often we actually are filtering the Azure Functions tests.