Skip to content

Conversation

@tonyredondo
Copy link
Member

Summary of changes

Bump timeit to the latest version

Reason for change

Provide some fixes

Implementation details

Test coverage

Other details

@tonyredondo tonyredondo requested review from a team as code owners October 13, 2025 09:32
Copy link
Collaborator

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!
Does this version fix the System.IO.EndOfStreamException error?

@tonyredondo
Copy link
Member Author

tonyredondo commented Oct 13, 2025

Cool! Thanks! Does this version fix the System.IO.EndOfStreamException error?

Yeah: tonyredondo/timeitsharp@v0.4.5...v0.4.6

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (72ms)  : 71, 74
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7647) - mean (68ms)  : 67, 70
     .   : milestone, 68,
    master - mean (68ms)  : 67, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (1,051ms)  : 1005, 1097
     .   : milestone, 1051,
    master - mean (1,057ms)  : 992, 1122
     .   : milestone, 1057,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (107ms)  : 106, 108
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section Baseline
    This PR (7647) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 104, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (744ms)  : 720, 769
     .   : milestone, 744,
    master - mean (751ms)  : 726, 775
     .   : milestone, 751,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (101ms)  : 100, 102
     .   : milestone, 101,
    master - mean (101ms)  : 101, 102
     .   : milestone, 101,

    section Baseline
    This PR (7647) - mean (100ms)  : 98, 102
     .   : milestone, 100,
    master - mean (101ms)  : 98, 103
     .   : milestone, 101,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (779ms)  : 742, 817
     .   : milestone, 779,
    master - mean (789ms)  : 756, 823
     .   : milestone, 789,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (93ms)  : 92, 95
     .   : milestone, 93,

    section Baseline
    This PR (7647) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (658ms)  : 642, 675
     .   : milestone, 658,
    master - mean (671ms)  : 651, 691
     .   : milestone, 671,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (196ms)  : 194, 199
     .   : milestone, 196,
    master - mean (196ms)  : 192, 200
     .   : milestone, 196,

    section Baseline
    This PR (7647) - mean (192ms)  : 189, 196
     .   : milestone, 192,
    master - mean (192ms)  : 189, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (1,160ms)  : 1113, 1206
     .   : milestone, 1160,
    master - mean (1,176ms)  : 1098, 1254
     .   : milestone, 1176,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (278ms)  : 274, 281
     .   : milestone, 278,

    section Baseline
    This PR (7647) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (935ms)  : 891, 980
     .   : milestone, 935,
    master - mean (945ms)  : 899, 992
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (281ms)  : 276, 286
     .   : milestone, 281,
    master - mean (280ms)  : 276, 285
     .   : milestone, 280,

    section Baseline
    This PR (7647) - mean (280ms)  : 274, 287
     .   : milestone, 280,
    master - mean (280ms)  : 274, 287
     .   : milestone, 280,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (992ms)  : 949, 1034
     .   : milestone, 992,
    master - mean (996ms)  : 950, 1041
     .   : milestone, 996,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7647) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (268ms)  : 265, 272
     .   : milestone, 268,

    section Baseline
    This PR (7647) - mean (268ms)  : 263, 272
     .   : milestone, 268,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7647) - mean (846ms)  : 828, 863
     .   : milestone, 846,
    master - mean (850ms)  : 836, 865
     .   : milestone, 850,

Loading

Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo tonyredondo merged commit 482a2fd into master Oct 13, 2025
160 of 161 checks passed
@tonyredondo tonyredondo deleted the tony/update-timeit-to-v0.4.6 branch October 13, 2025 11:01
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 13, 2025
@bouwkast bouwkast added the dependencies Pull requests that update a dependency file label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants