Skip to content

Use RuntimeHelpers.GetHashCode in IndexObject #7678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+15 −2
Merged

Use RuntimeHelpers.GetHashCode in IndexObject #7678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracer/src/Datadog.Trace/Iast/DefaultTaintedMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public void Clear()

private int IndexObject(object objectStored)
{
return Index(PositiveHashCode(objectStored.GetHashCode()));
return Index(PositiveHashCode(IastUtils.IdentityHashCode(objectStored)));
}

private int PositiveHashCode(int hash)
Expand Down
15 changes: 14 additions & 1 deletion tracer/src/Datadog.Trace/Iast/IastUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,20 @@ private static int GetHash<T>(T element)

public static int IdentityHashCode(object item)
{
return (item?.GetHashCode() ?? 0);
if (item == null)
{
return 0;
}

try
{
return item.GetHashCode();
}
catch
{
// Seen this that it appears some customer objects have overrode GetHashCode and throw
return System.Runtime.CompilerServices.RuntimeHelpers.GetHashCode(item);
}
}

public static Range[] GetRangesForString(string stringValue, Source source)
Expand Down
Loading