Use ScopedTracer in tests
#7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouwkast
approved these changes
Nov 4, 2025
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7770) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (70ms) : 68, 71
master - mean (68ms) : 67, 69
section Bailout
This PR (7770) - mean (73ms) : 72, 75
master - mean (72ms) : 70, 73
section CallTarget+Inlining+NGEN
This PR (7770) - mean (1,057ms) : 1007, 1107
master - mean (1,051ms) : 1002, 1099
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (110ms) : 101, 120
master - mean (106ms) : 104, 108
section Bailout
This PR (7770) - mean (110ms) : 108, 111
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (7770) - mean (765ms) : 728, 801
master - mean (749ms) : 727, 772
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (96ms) : 94, 99
master - mean (94ms) : 92, 96
section Bailout
This PR (7770) - mean (97ms) : 95, 99
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7770) - mean (712ms) : 676, 748
master - mean (718ms) : 665, 771
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (95ms) : 92, 98
master - mean (92ms) : 90, 95
section Bailout
This PR (7770) - mean (95ms) : 93, 97
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7770) - mean (675ms) : 652, 697
master - mean (670ms) : 651, 689
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (193ms) : 188, 197
master - mean (192ms) : 188, 197
section Bailout
This PR (7770) - mean (196ms) : 194, 199
master - mean (195ms) : 192, 199
section CallTarget+Inlining+NGEN
This PR (7770) - mean (1,172ms) : 1102, 1242
master - mean (1,171ms) : 1101, 1241
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (276ms) : 271, 281
master - mean (275ms) : 270, 280
section Bailout
This PR (7770) - mean (277ms) : 272, 282
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (7770) - mean (955ms) : 909, 1002
master - mean (951ms) : 904, 999
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (269ms) : 264, 273
master - mean (269ms) : 263, 274
section Bailout
This PR (7770) - mean (270ms) : 266, 273
master - mean (269ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (7770) - mean (930ms) : 882, 979
master - mean (934ms) : 870, 998
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7770) - mean (269ms) : 264, 273
master - mean (268ms) : 264, 272
section Bailout
This PR (7770) - mean (270ms) : 266, 274
master - mean (268ms) : 265, 271
section CallTarget+Inlining+NGEN
This PR (7770) - mean (849ms) : 829, 869
master - mean (852ms) : 837, 867
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
ScopedTracerin tests, so that everything gets disposed properlyReason for change
If you don't use `ScopedTacer, or clean up manually, threads leak
Implementation details
Use the existing
ScopedTracer(viaTracerHelper)Test coverage
Same