Skip to content

Fix RedirectInput test flakyness #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
+15 −1
Merged

Fix RedirectInput test flakyness #7771

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
037be06
Fix RedirectInput test flakyness
NachoEchevarria Nov 4, 2025
ee29560
Add some delay to sample app
NachoEchevarria Nov 4, 2025
9236e2b
Remove sleep
NachoEchevarria Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/RunCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System;
using System.Text;
using System.Threading.Tasks;
using Datadog.Trace.TestHelpers;
Expand Down Expand Up @@ -99,7 +100,20 @@ public void RedirectInput()
}
finally
{
process.Kill();
// The echo command exits after echoing one line, so the process may have already exited
try
{
if (!process.HasExited)
{
process.Kill();
}
}
catch (InvalidOperationException)
{
// Process exited between the HasExited check and Kill() call
}

process.Dispose();
}
}

Expand Down
Loading