-
Notifications
You must be signed in to change notification settings - Fork 150
Replace macos-13 with macos-14 in CI #7778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macos-13 will soon be removed and we are getting CI failures
| new (publishFramework: TargetFramework.NET7_0, "macos-13", "macos", "13"), | ||
| new (publishFramework: TargetFramework.NET8_0, "macos-13", "macos", "13"), | ||
| new (publishFramework: TargetFramework.NET9_0, "macos-13", "macos", "13"), | ||
| // macos-11/12/13 environments are no longer available in Azure Devops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh some of these actually appear to be the same so we can remove them, but they aren't all the same / dupes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed some to keep it in order, but unsure if they will actually work? Unsure what the reasoning was for the mix
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7778) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (68ms) : 66, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (7778) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7778) - mean (1,047ms) : 1005, 1088
master - mean (1,047ms) : 1010, 1083
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (106ms) : 104, 108
master - mean (107ms) : 104, 109
section Bailout
This PR (7778) - mean (107ms) : 105, 108
master - mean (107ms) : 106, 109
section CallTarget+Inlining+NGEN
This PR (7778) - mean (750ms) : 719, 781
master - mean (759ms) : 727, 790
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (94ms) : 92, 96
master - mean (94ms) : 91, 97
section Bailout
This PR (7778) - mean (95ms) : 93, 96
master - mean (95ms) : 94, 96
section CallTarget+Inlining+NGEN
This PR (7778) - mean (720ms) : 667, 773
master - mean (711ms) : 674, 748
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (92ms) : 90, 95
master - mean (93ms) : 91, 95
section Bailout
This PR (7778) - mean (93ms) : 91, 95
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (7778) - mean (659ms) : 647, 672
master - mean (664ms) : 649, 678
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (192ms) : 189, 195
master - mean (193ms) : 189, 197
section Bailout
This PR (7778) - mean (195ms) : 193, 197
master - mean (196ms) : 193, 198
section CallTarget+Inlining+NGEN
This PR (7778) - mean (1,171ms) : 1094, 1248
master - mean (1,172ms) : 1094, 1250
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (276ms) : 271, 281
master - mean (278ms) : 272, 283
section Bailout
This PR (7778) - mean (276ms) : 272, 280
master - mean (278ms) : 272, 284
section CallTarget+Inlining+NGEN
This PR (7778) - mean (945ms) : 901, 990
master - mean (954ms) : 915, 992
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (268ms) : 264, 273
master - mean (270ms) : 265, 276
section Bailout
This PR (7778) - mean (270ms) : 266, 274
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (7778) - mean (928ms) : 876, 979
master - mean (933ms) : 885, 980
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7778) - mean (269ms) : 264, 273
master - mean (268ms) : 264, 273
section Bailout
This PR (7778) - mean (268ms) : 263, 273
master - mean (268ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (7778) - mean (852ms) : 829, 876
master - mean (858ms) : 839, 876
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7778 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 5.99 KB | 6.07 KB | 81 B | 1.35% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 10.3μs | 42.4ns | 175ns | 0 | 0 | 0 | 5.52 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 13.7μs | 65.3ns | 269ns | 0 | 0 | 0 | 5.71 KB |
| master | StartStopWithChild |
net472 | 21.9μs | 110ns | 517ns | 1 | 0.401 | 0.1 | 5.99 KB |
| #7778 | StartStopWithChild |
net6.0 | 10.7μs | 60.1ns | 375ns | 0 | 0 | 0 | 5.52 KB |
| #7778 | StartStopWithChild |
netcoreapp3.1 | 13.2μs | 71ns | 369ns | 0 | 0 | 0 | 5.71 KB |
| #7778 | StartStopWithChild |
net472 | 21.9μs | 116ns | 773ns | 0.996 | 0.332 | 0.111 | 6.07 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 953μs | 425ns | 1.59μs | 0 | 0 | 0 | 2.71 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.05ms | 926ns | 3.34μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.24ms | 505ns | 1.96μs | 0 | 0 | 0 | 3.31 KB |
| #7778 | WriteAndFlushEnrichedTraces |
net6.0 | 921μs | 246ns | 953ns | 0 | 0 | 0 | 2.71 KB |
| #7778 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.03ms | 461ns | 1.78μs | 0 | 0 | 0 | 2.7 KB |
| #7778 | WriteAndFlushEnrichedTraces |
net472 | 1.21ms | 58.7ns | 220ns | 0 | 0 | 0 | 3.31 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.07μs | 5.79ns | 32.3ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.41μs | 7.44ns | 38.7ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.03μs | 0.428ns | 1.66ns | 0.191 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 7μs | 35.3ns | 150ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.92μs | 33.7ns | 131ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.65μs | 7.71ns | 29.9ns | 0.729 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 319ns | 0.0645ns | 0.25ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 398ns | 1.93ns | 7.96ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 295ns | 0.0671ns | 0.26ns | 0.0432 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.39μs | 19.8ns | 76.7ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.81μs | 38.8ns | 165ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.72μs | 2.45ns | 9.48ns | 0.601 | 0 | 0 | 3.8 KB |
| #7778 | AllCycleSimpleBody |
net6.0 | 1.06μs | 6.14ns | 53.2ns | 0 | 0 | 0 | 1.22 KB |
| #7778 | AllCycleSimpleBody |
netcoreapp3.1 | 1.41μs | 2.48ns | 9.26ns | 0 | 0 | 0 | 1.2 KB |
| #7778 | AllCycleSimpleBody |
net472 | 1.08μs | 0.489ns | 1.83ns | 0.192 | 0 | 0 | 1.23 KB |
| #7778 | AllCycleMoreComplexBody |
net6.0 | 7.01μs | 37.5ns | 202ns | 0 | 0 | 0 | 4.72 KB |
| #7778 | AllCycleMoreComplexBody |
netcoreapp3.1 | 9.14μs | 4.63ns | 17.3ns | 0 | 0 | 0 | 4.62 KB |
| #7778 | AllCycleMoreComplexBody |
net472 | 7.74μs | 6.88ns | 26.7ns | 0.742 | 0 | 0 | 4.74 KB |
| #7778 | ObjectExtractorSimpleBody |
net6.0 | 313ns | 1.77ns | 12.1ns | 0 | 0 | 0 | 280 B |
| #7778 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 402ns | 2.06ns | 9.66ns | 0 | 0 | 0 | 272 B |
| #7778 | ObjectExtractorSimpleBody |
net472 | 296ns | 0.0202ns | 0.0728ns | 0.0433 | 0 | 0 | 281 B |
| #7778 | ObjectExtractorMoreComplexBody |
net6.0 | 6.34μs | 24.8ns | 92.7ns | 0 | 0 | 0 | 3.78 KB |
| #7778 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.86μs | 32.8ns | 127ns | 0 | 0 | 0 | 3.69 KB |
| #7778 | ObjectExtractorMoreComplexBody |
net472 | 6.7μs | 1.96ns | 7.61ns | 0.602 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 77μs | 20.4ns | 76.4ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 96.7μs | 248ns | 961ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 113μs | 6.99ns | 26.2ns | 5.07 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 146μs | 197ns | 765ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 197μs | 77ns | 288ns | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 263μs | 125ns | 484ns | 0 | 0 | 0 | 2.16 KB |
| #7778 | EncodeArgs |
net6.0 | 77.2μs | 230ns | 892ns | 0 | 0 | 0 | 32.4 KB |
| #7778 | EncodeArgs |
netcoreapp3.1 | 98.5μs | 204ns | 791ns | 0 | 0 | 0 | 32.4 KB |
| #7778 | EncodeArgs |
net472 | 110μs | 14.2ns | 54.9ns | 4.95 | 0 | 0 | 32.51 KB |
| #7778 | EncodeLegacyArgs |
net6.0 | 142μs | 106ns | 409ns | 0 | 0 | 0 | 2.15 KB |
| #7778 | EncodeLegacyArgs |
netcoreapp3.1 | 199μs | 192ns | 742ns | 0 | 0 | 0 | 2.14 KB |
| #7778 | EncodeLegacyArgs |
net472 | 266μs | 35.7ns | 138ns | 0 | 0 | 0 | 2.16 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #7778
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1
2.434
294,986.01
717,859.22
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1
2.100
410,594.48
862,230.00
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 | 2.434 | 294,986.01 | 717,859.22 | |
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.100 | 410,594.48 | 862,230.00 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 417μs | 63.4ns | 237ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 411μs | 90.8ns | 315ns | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 441μs | 85.1ns | 319ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 291μs | 79.9ns | 288ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 295μs | 83ns | 299ns | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 317μs | 40.2ns | 156ns | 0 | 0 | 0 | 2.29 KB |
| #7778 | RunWafRealisticBenchmark |
net6.0 | 393μs | 83.9ns | 325ns | 0 | 0 | 0 | 4.55 KB |
| #7778 | RunWafRealisticBenchmark |
netcoreapp3.1 | 798μs | 14.5μs | 144μs | 0 | 0 | 0 | 4.48 KB |
| #7778 | RunWafRealisticBenchmark |
net472 | 431μs | 38.3ns | 148ns | 0 | 0 | 0 | 4.66 KB |
| #7778 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 287μs | 47.6ns | 178ns | 0 | 0 | 0 | 2.24 KB |
| #7778 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 707μs | 4.97μs | 49.7μs | 0 | 0 | 0 | 2.22 KB |
| #7778 | RunWafRealisticBenchmarkWithAttack |
net472 | 313μs | 40.3ns | 156ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 61.6μs | 27.2ns | 106ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 71.6μs | 101ns | 379ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00136ns | 0.000796ns | 0.00298ns | 0 | 0 | 0 | 0 b |
| #7778 | SendRequest |
net6.0 | 61.3μs | 71.5ns | 277ns | 0 | 0 | 0 | 14.52 KB |
| #7778 | SendRequest |
netcoreapp3.1 | 71.8μs | 271ns | 1.51μs | 0 | 0 | 0 | 17.42 KB |
| #7778 | SendRequest |
net472 | 0.00418ns | 0.00172ns | 0.00667ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472
0 b
73 B
73 B
∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472
0 b
47 B
47 B
∞
Fewer allocations 🎉 in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
3 B
2 B
-1 B
-33.33%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
7 B
4 B
-3 B
-42.86%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 | 0 b | 73 B | 73 B | ∞ |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 | 0 b | 47 B | 47 B | ∞ |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 3 B | 2 B | -1 B | -33.33% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 7 B | 4 B | -3 B | -42.86% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.92ms | 1.96μs | 7.35μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.21ms | 6.9μs | 25.8μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.55ms | 80.9ns | 303ns | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.39ms | 182ns | 705ns | 0 | 0 | 0 | 7 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.68ms | 1.67μs | 6.45μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 2.01ms | 283ns | 1.1μs | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net6.0 | 857μs | 101ns | 393ns | 0 | 0 | 0 | 3 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 808μs | 62.5ns | 242ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
net472 | 1.13ms | 91.4ns | 354ns | 0 | 0 | 0 | 0 b |
| #7778 | OriginalCharSlice |
net6.0 | 1.92ms | 3.78μs | 14.1μs | 0 | 0 | 0 | 640.01 KB |
| #7778 | OriginalCharSlice |
netcoreapp3.1 | 2.11ms | 5.56μs | 21.5μs | 0 | 0 | 0 | 640 KB |
| #7778 | OriginalCharSlice |
net472 | 2.66ms | 127ns | 490ns | 100 | 0 | 0 | 641.95 KB |
| #7778 | OptimizedCharSlice |
net6.0 | 1.39ms | 295ns | 1.14μs | 0 | 0 | 0 | 4 B |
| #7778 | OptimizedCharSlice |
netcoreapp3.1 | 1.73ms | 198ns | 767ns | 0 | 0 | 0 | 1 B |
| #7778 | OptimizedCharSlice |
net472 | 1.98ms | 209ns | 809ns | 0 | 0 | 0 | 73 B |
| #7778 | OptimizedCharSliceWithPool |
net6.0 | 848μs | 26.9ns | 101ns | 0 | 0 | 0 | 2 B |
| #7778 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 818μs | 91.8ns | 343ns | 0 | 0 | 0 | 1 B |
| #7778 | OptimizedCharSliceWithPool |
net472 | 1.14ms | 93.2ns | 361ns | 0 | 0 | 0 | 47 B |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.61 KB
41.91 KB
307 B
0.74%
Fewer allocations 🎉 in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
56.49 KB
56.12 KB
-376 B
-0.67%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.61 KB | 41.91 KB | 307 B | 0.74% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 56.49 KB | 56.12 KB | -376 B | -0.67% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 680μs | 1.96μs | 7.31μs | 0 | 0 | 0 | 41.61 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 696μs | 1.49μs | 5.15μs | 0 | 0 | 0 | 41.84 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 869μs | 2.97μs | 11.5μs | 8.33 | 0 | 0 | 56.49 KB |
| #7778 | WriteAndFlushEnrichedTraces |
net6.0 | 686μs | 996ns | 3.59μs | 0 | 0 | 0 | 41.91 KB |
| #7778 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 728μs | 357ns | 1.38μs | 0 | 0 | 0 | 41.82 KB |
| #7778 | WriteAndFlushEnrichedTraces |
net472 | 926μs | 3.46μs | 13μs | 8.33 | 0 | 0 | 56.12 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.91μs | 4.03ns | 15.6ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.66μs | 9.81ns | 38ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.9μs | 3.07ns | 11.9ns | 0.145 | 0.0145 | 0 | 987 B |
| #7778 | ExecuteNonQuery |
net6.0 | 1.87μs | 8.65ns | 31.2ns | 0 | 0 | 0 | 1.02 KB |
| #7778 | ExecuteNonQuery |
netcoreapp3.1 | 2.59μs | 8.89ns | 34.4ns | 0 | 0 | 0 | 1.02 KB |
| #7778 | ExecuteNonQuery |
net472 | 2.94μs | 3.15ns | 12.2ns | 0.147 | 0.0147 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.74μs | 8.1ns | 31.4ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.2μs | 10.5ns | 44.4ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.6μs | 3ns | 11.6ns | 0.162 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.84μs | 8.73ns | 33.8ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.4μs | 11.6ns | 46.4ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.67μs | 4.86ns | 18.8ns | 0.165 | 0 | 0 | 1.1 KB |
| #7778 | CallElasticsearch |
net6.0 | 1.8μs | 8.53ns | 34.1ns | 0 | 0 | 0 | 1.03 KB |
| #7778 | CallElasticsearch |
netcoreapp3.1 | 2.25μs | 10.4ns | 41.5ns | 0 | 0 | 0 | 1.03 KB |
| #7778 | CallElasticsearch |
net472 | 3.57μs | 3.37ns | 13ns | 0.162 | 0 | 0 | 1.04 KB |
| #7778 | CallElasticsearchAsync |
net6.0 | 1.86μs | 8.27ns | 30.9ns | 0 | 0 | 0 | 1.01 KB |
| #7778 | CallElasticsearchAsync |
netcoreapp3.1 | 2.39μs | 10.7ns | 41.5ns | 0 | 0 | 0 | 1.08 KB |
| #7778 | CallElasticsearchAsync |
net472 | 3.63μs | 2.68ns | 10.4ns | 0.164 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.84μs | 9.26ns | 40.3ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.43μs | 11.3ns | 45.2ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.54μs | 3.55ns | 13.8ns | 0.14 | 0 | 0 | 915 B |
| #7778 | ExecuteAsync |
net6.0 | 1.83μs | 8.67ns | 35.8ns | 0 | 0 | 0 | 952 B |
| #7778 | ExecuteAsync |
netcoreapp3.1 | 2.45μs | 6.03ns | 20.9ns | 0 | 0 | 0 | 952 B |
| #7778 | ExecuteAsync |
net472 | 2.52μs | 0.845ns | 3.27ns | 0.139 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 7.08μs | 8.57ns | 33.2ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.87μs | 33.1ns | 128ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.3μs | 8.57ns | 32.1ns | 0.493 | 0 | 0 | 3.18 KB |
| #7778 | SendAsync |
net6.0 | 6.85μs | 12ns | 46.3ns | 0 | 0 | 0 | 2.36 KB |
| #7778 | SendAsync |
netcoreapp3.1 | 8.69μs | 20.1ns | 77.8ns | 0 | 0 | 0 | 2.9 KB |
| #7778 | SendAsync |
net472 | 12.5μs | 15.5ns | 60.1ns | 0.495 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
255.14 KB
275.22 KB
20.09 KB
7.87%
Fewer allocations 🎉 in #7778
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
278.53 KB
275.16 KB
-3.37 KB
-1.21%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
45.5 KB
42.78 KB
-2.72 KB
-5.98%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 255.14 KB | 275.22 KB | 20.09 KB | 7.87% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 278.53 KB | 275.16 KB | -3.37 KB | -1.21% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 45.5 KB | 42.78 KB | -2.72 KB | -5.98% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 41.7μs | 160ns | 578ns | 0 | 0 | 0 | 43.59 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 54.9μs | 944ns | 9.39μs | 0 | 0 | 0 | 45.5 KB |
| master | StringConcatBenchmark |
net472 | 57.6μs | 91.6ns | 330ns | 0 | 0 | 0 | 65.54 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 474μs | 1.52μs | 5.28μs | 0 | 0 | 0 | 278.42 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 488μs | 2.49μs | 10.8μs | 0 | 0 | 0 | 255.14 KB |
| master | StringConcatAspectBenchmark |
net472 | 409μs | 2.31μs | 15.5μs | 0 | 0 | 0 | 278.53 KB |
| #7778 | StringConcatBenchmark |
net6.0 | 50.6μs | 667ns | 6.57μs | 0 | 0 | 0 | 43.44 KB |
| #7778 | StringConcatBenchmark |
netcoreapp3.1 | 46.5μs | 222ns | 887ns | 0 | 0 | 0 | 42.78 KB |
| #7778 | StringConcatBenchmark |
net472 | 58.4μs | 94.8ns | 342ns | 0 | 0 | 0 | 65.54 KB |
| #7778 | StringConcatAspectBenchmark |
net6.0 | 487μs | 2.44μs | 10.9μs | 0 | 0 | 0 | 279.82 KB |
| #7778 | StringConcatAspectBenchmark |
netcoreapp3.1 | 537μs | 2.46μs | 9.54μs | 0 | 0 | 0 | 275.22 KB |
| #7778 | StringConcatAspectBenchmark |
net472 | 422μs | 2.4μs | 16.5μs | 0 | 0 | 0 | 275.16 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.61μs | 14ns | 72.6ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.69μs | 17.6ns | 70.4ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 4.01μs | 9.66ns | 37.4ns | 0.242 | 0 | 0 | 1.64 KB |
| #7778 | EnrichedLog |
net6.0 | 2.65μs | 13.5ns | 58.6ns | 0 | 0 | 0 | 1.7 KB |
| #7778 | EnrichedLog |
netcoreapp3.1 | 3.64μs | 17.5ns | 70ns | 0 | 0 | 0 | 1.7 KB |
| #7778 | EnrichedLog |
net472 | 3.99μs | 5.31ns | 20.6ns | 0.241 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 122μs | 97.1ns | 350ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 129μs | 392ns | 1.52μs | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 167μs | 62ns | 232ns | 0 | 0 | 0 | 4.51 KB |
| #7778 | EnrichedLog |
net6.0 | 124μs | 112ns | 404ns | 0 | 0 | 0 | 4.31 KB |
| #7778 | EnrichedLog |
netcoreapp3.1 | 129μs | 208ns | 722ns | 0 | 0 | 0 | 4.31 KB |
| #7778 | EnrichedLog |
net472 | 169μs | 556ns | 2.15μs | 0 | 0 | 0 | 4.52 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 5μs | 16ns | 61.9ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.84μs | 12.2ns | 45.5ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.52μs | 6.02ns | 22.5ns | 0.302 | 0 | 0 | 2.08 KB |
| #7778 | EnrichedLog |
net6.0 | 5.06μs | 15.8ns | 61.2ns | 0 | 0 | 0 | 2.26 KB |
| #7778 | EnrichedLog |
netcoreapp3.1 | 6.89μs | 22.3ns | 86.2ns | 0 | 0 | 0 | 2.26 KB |
| #7778 | EnrichedLog |
net472 | 7.49μs | 5.66ns | 21.9ns | 0.299 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.02μs | 9.72ns | 37.6ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.61μs | 13.1ns | 58.5ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.09μs | 2.48ns | 9.61ns | 0.185 | 0 | 0 | 1.2 KB |
| #7778 | SendReceive |
net6.0 | 1.97μs | 1.08ns | 4.18ns | 0 | 0 | 0 | 1.2 KB |
| #7778 | SendReceive |
netcoreapp3.1 | 2.64μs | 11.9ns | 46.2ns | 0 | 0 | 0 | 1.2 KB |
| #7778 | SendReceive |
net472 | 3.08μs | 2.11ns | 8.19ns | 0.184 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.09μs | 17.4ns | 67.5ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.8μs | 11.4ns | 44.2ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.73μs | 9.84ns | 38.1ns | 0.303 | 0 | 0 | 2.03 KB |
| #7778 | EnrichedLog |
net6.0 | 4.31μs | 7.22ns | 28ns | 0 | 0 | 0 | 1.58 KB |
| #7778 | EnrichedLog |
netcoreapp3.1 | 5.62μs | 18.6ns | 71.9ns | 0 | 0 | 0 | 1.63 KB |
| #7778 | EnrichedLog |
net472 | 6.6μs | 8.63ns | 33.4ns | 0.297 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 764ns | 3.95ns | 18.5ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 959ns | 4.95ns | 23.2ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 927ns | 0.386ns | 1.5ns | 0.0885 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 905ns | 4.85ns | 26.1ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.19μs | 2.53ns | 9.8ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.12μs | 0.538ns | 2.01ns | 0.102 | 0 | 0 | 658 B |
| #7778 | StartFinishSpan |
net6.0 | 779ns | 2.99ns | 11.6ns | 0 | 0 | 0 | 576 B |
| #7778 | StartFinishSpan |
netcoreapp3.1 | 945ns | 4.97ns | 25.8ns | 0 | 0 | 0 | 576 B |
| #7778 | StartFinishSpan |
net472 | 925ns | 0.714ns | 2.77ns | 0.0884 | 0 | 0 | 578 B |
| #7778 | StartFinishScope |
net6.0 | 917ns | 0.289ns | 1.08ns | 0 | 0 | 0 | 696 B |
| #7778 | StartFinishScope |
netcoreapp3.1 | 1.2μs | 4.93ns | 19.1ns | 0 | 0 | 0 | 696 B |
| #7778 | StartFinishScope |
net472 | 1.14μs | 1.77ns | 6.84ns | 0.101 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.08μs | 5.76ns | 28.8ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.47μs | 7.42ns | 32.3ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.46μs | 0.673ns | 2.61ns | 0.102 | 0 | 0 | 658 B |
| #7778 | RunOnMethodBegin |
net6.0 | 1.06μs | 5.53ns | 25.3ns | 0 | 0 | 0 | 696 B |
| #7778 | RunOnMethodBegin |
netcoreapp3.1 | 1.44μs | 5.91ns | 22.9ns | 0 | 0 | 0 | 696 B |
| #7778 | RunOnMethodBegin |
net472 | 1.47μs | 1.02ns | 3.97ns | 0.103 | 0 | 0 | 658 B |
This comment has been minimized.
This comment has been minimized.
Test macos-13 VMs
andrewlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
We should remember to update the support matrix in the documentation too |
Summary of changes
Migrate CI pipelines from macOS-13 to macOS-14 runners to resolve Azure DevOps deprecation warnings. The macOS-13 based runner images are being deprecated and are currently experiencing scheduled brownouts.
Reason for change
Implementation details
CTRL + F "macos-13" -> replace "macos-14"
Test coverage
This PR is the coverage
Other details