-
Notifications
You must be signed in to change notification settings - Fork 150
Kr igor/apms 17551 v2 #7792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kr igor/apms 17551 v2 #7792
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7792 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 5.99 KB | 6.08 KB | 92 B | 1.54% |
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 | 5.67 KB | 5.71 KB | 35 B | 0.62% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 10.4μs | 58.6ns | 389ns | 0 | 0 | 0 | 5.52 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 14.2μs | 72.1ns | 330ns | 0 | 0 | 0 | 5.67 KB |
| master | StartStopWithChild |
net472 | 22.4μs | 88.4ns | 342ns | 1.05 | 0.418 | 0.105 | 5.99 KB |
| #7792 | StartStopWithChild |
net6.0 | 10.5μs | 57.6ns | 350ns | 0 | 0 | 0 | 5.5 KB |
| #7792 | StartStopWithChild |
netcoreapp3.1 | 13.9μs | 72.6ns | 340ns | 0 | 0 | 0 | 5.71 KB |
| #7792 | StartStopWithChild |
net472 | 21.6μs | 70.8ns | 255ns | 0.911 | 0.228 | 0 | 6.08 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉
Fewer allocations 🎉 in #7792
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
3.35 KB
3.31 KB
-46 B
-1.37%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 3.35 KB | 3.31 KB | -46 B | -1.37% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 927μs | 64.7ns | 242ns | 0 | 0 | 0 | 2.71 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.06ms | 846ns | 3.28μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.19ms | 71.4ns | 267ns | 0 | 0 | 0 | 3.35 KB |
| #7792 | WriteAndFlushEnrichedTraces |
net6.0 | 935μs | 99.7ns | 359ns | 0 | 0 | 0 | 2.71 KB |
| #7792 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.03ms | 76.4ns | 276ns | 0 | 0 | 0 | 2.7 KB |
| #7792 | WriteAndFlushEnrichedTraces |
net472 | 1.2ms | 107ns | 400ns | 0 | 0 | 0 | 3.31 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.07μs | 1.45ns | 5.62ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.46μs | 7.77ns | 38.9ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.03μs | 0.654ns | 2.53ns | 0.195 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 6.99μs | 35.2ns | 153ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 9.01μs | 24.8ns | 96.2ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.6μs | 4.46ns | 17.3ns | 0.726 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 325ns | 1.22ns | 4.71ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 414ns | 2.12ns | 9.94ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 295ns | 0.0121ns | 0.0419ns | 0.0432 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.43μs | 1.62ns | 6.26ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.81μs | 36.9ns | 143ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.73μs | 4.21ns | 16.3ns | 0.574 | 0 | 0 | 3.8 KB |
| #7792 | AllCycleSimpleBody |
net6.0 | 1.06μs | 6.34ns | 63.4ns | 0 | 0 | 0 | 1.22 KB |
| #7792 | AllCycleSimpleBody |
netcoreapp3.1 | 1.47μs | 0.839ns | 3.25ns | 0 | 0 | 0 | 1.2 KB |
| #7792 | AllCycleSimpleBody |
net472 | 1.04μs | 0.653ns | 2.44ns | 0.193 | 0 | 0 | 1.23 KB |
| #7792 | AllCycleMoreComplexBody |
net6.0 | 6.95μs | 37.3ns | 214ns | 0 | 0 | 0 | 4.72 KB |
| #7792 | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.97μs | 31.1ns | 120ns | 0 | 0 | 0 | 4.62 KB |
| #7792 | AllCycleMoreComplexBody |
net472 | 7.7μs | 4.99ns | 19.3ns | 0.733 | 0 | 0 | 4.74 KB |
| #7792 | ObjectExtractorSimpleBody |
net6.0 | 326ns | 0.0636ns | 0.22ns | 0 | 0 | 0 | 280 B |
| #7792 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 392ns | 2.21ns | 14.3ns | 0 | 0 | 0 | 272 B |
| #7792 | ObjectExtractorSimpleBody |
net472 | 307ns | 1.48ns | 5.94ns | 0.0439 | 0 | 0 | 281 B |
| #7792 | ObjectExtractorMoreComplexBody |
net6.0 | 6.36μs | 24.1ns | 93.4ns | 0 | 0 | 0 | 3.78 KB |
| #7792 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.89μs | 31.3ns | 121ns | 0 | 0 | 0 | 3.69 KB |
| #7792 | ObjectExtractorMoreComplexBody |
net472 | 6.61μs | 0.583ns | 2.02ns | 0.596 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 76.7μs | 260ns | 971ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 98.4μs | 168ns | 649ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 112μs | 20.3ns | 78.5ns | 5.04 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 146μs | 216ns | 837ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 201μs | 577ns | 2.23μs | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 261μs | 20.2ns | 75.7ns | 0 | 0 | 0 | 2.17 KB |
| #7792 | EncodeArgs |
net6.0 | 76.7μs | 142ns | 552ns | 0 | 0 | 0 | 32.4 KB |
| #7792 | EncodeArgs |
netcoreapp3.1 | 97.4μs | 221ns | 856ns | 0 | 0 | 0 | 32.4 KB |
| #7792 | EncodeArgs |
net472 | 110μs | 11.9ns | 44.7ns | 4.95 | 0 | 0 | 32.51 KB |
| #7792 | EncodeLegacyArgs |
net6.0 | 149μs | 133ns | 462ns | 0 | 0 | 0 | 2.15 KB |
| #7792 | EncodeLegacyArgs |
netcoreapp3.1 | 199μs | 226ns | 876ns | 0 | 0 | 0 | 2.14 KB |
| #7792 | EncodeLegacyArgs |
net472 | 266μs | 39.6ns | 153ns | 0 | 0 | 0 | 2.17 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #7792
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1
2.105
870,408.73
413,559.38
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.105 | 870,408.73 | 413,559.38 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 400μs | 102ns | 368ns | 0 | 0 | 0 | 4.56 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 828μs | 13.1μs | 131μs | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 429μs | 30.2ns | 113ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 287μs | 85.1ns | 318ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 309μs | 221ns | 827ns | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 309μs | 29.2ns | 109ns | 0 | 0 | 0 | 2.29 KB |
| #7792 | RunWafRealisticBenchmark |
net6.0 | 402μs | 118ns | 455ns | 0 | 0 | 0 | 4.55 KB |
| #7792 | RunWafRealisticBenchmark |
netcoreapp3.1 | 414μs | 118ns | 426ns | 0 | 0 | 0 | 4.48 KB |
| #7792 | RunWafRealisticBenchmark |
net472 | 437μs | 578ns | 2.24μs | 0 | 0 | 0 | 4.66 KB |
| #7792 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 290μs | 90.6ns | 339ns | 0 | 0 | 0 | 2.24 KB |
| #7792 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 299μs | 186ns | 671ns | 0 | 0 | 0 | 2.22 KB |
| #7792 | RunWafRealisticBenchmarkWithAttack |
net472 | 314μs | 235ns | 911ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 61.1μs | 60.4ns | 218ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 72.8μs | 98.1ns | 367ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00895ns | 0.0023ns | 0.00862ns | 0 | 0 | 0 | 0 b |
| #7792 | SendRequest |
net6.0 | 60.7μs | 43.3ns | 156ns | 0 | 0 | 0 | 14.52 KB |
| #7792 | SendRequest |
netcoreapp3.1 | 73.5μs | 364ns | 1.67μs | 0 | 0 | 0 | 17.42 KB |
| #7792 | SendRequest |
net472 | 0.00151ns | 0.00108ns | 0.00419ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7792
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472
0 b
73 B
73 B
∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472
0 b
47 B
47 B
∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
4 B
7 B
3 B
75.00%
Fewer allocations 🎉 in #7792
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
4 B
2 B
-2 B
-50.00%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 | 0 b | 73 B | 73 B | ∞ |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 | 0 b | 47 B | 47 B | ∞ |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 4 B | 7 B | 3 B | 75.00% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 4 B | 2 B | -2 B | -50.00% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.95ms | 5.87μs | 22.7μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.08ms | 6.07μs | 23.5μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.59ms | 529ns | 1.91μs | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.46ms | 320ns | 1.24μs | 0 | 0 | 0 | 4 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.75ms | 544ns | 2.11μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.9ms | 262ns | 1.02μs | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net6.0 | 826μs | 26.8ns | 100ns | 0 | 0 | 0 | 4 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 840μs | 141ns | 544ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
net472 | 1.22ms | 248ns | 959ns | 0 | 0 | 0 | 0 b |
| #7792 | OriginalCharSlice |
net6.0 | 1.92ms | 628ns | 2.43μs | 0 | 0 | 0 | 640.01 KB |
| #7792 | OriginalCharSlice |
netcoreapp3.1 | 2.13ms | 5.64μs | 21.1μs | 0 | 0 | 0 | 640 KB |
| #7792 | OriginalCharSlice |
net472 | 2.63ms | 173ns | 624ns | 100 | 0 | 0 | 641.95 KB |
| #7792 | OptimizedCharSlice |
net6.0 | 1.36ms | 3.13μs | 12.1μs | 0 | 0 | 0 | 7 B |
| #7792 | OptimizedCharSlice |
netcoreapp3.1 | 1.72ms | 336ns | 1.3μs | 0 | 0 | 0 | 1 B |
| #7792 | OptimizedCharSlice |
net472 | 2ms | 264ns | 1.02μs | 0 | 0 | 0 | 73 B |
| #7792 | OptimizedCharSliceWithPool |
net6.0 | 802μs | 60.4ns | 234ns | 0 | 0 | 0 | 2 B |
| #7792 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 810μs | 88.3ns | 342ns | 0 | 0 | 0 | 1 B |
| #7792 | OptimizedCharSliceWithPool |
net472 | 1.15ms | 182ns | 707ns | 0 | 0 | 0 | 47 B |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 642μs | 488ns | 1.89μs | 0 | 0 | 0 | 41.65 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 692μs | 2.32μs | 8.38μs | 0 | 0 | 0 | 42.17 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 897μs | 4.28μs | 16.6μs | 8.33 | 0 | 0 | 56.12 KB |
| #7792 | WriteAndFlushEnrichedTraces |
net6.0 | 683μs | 3.66μs | 20.7μs | 0 | 0 | 0 | 41.71 KB |
| #7792 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 731μs | 3.43μs | 13.7μs | 0 | 0 | 0 | 42.2 KB |
| #7792 | WriteAndFlushEnrichedTraces |
net472 | 863μs | 2.86μs | 11.1μs | 8.33 | 0 | 0 | 56.32 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.9μs | 1.28ns | 4.78ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.68μs | 11.8ns | 45.6ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.9μs | 6.14ns | 21.3ns | 0.144 | 0.0144 | 0 | 987 B |
| #7792 | ExecuteNonQuery |
net6.0 | 1.92μs | 9.42ns | 42.1ns | 0 | 0 | 0 | 1.02 KB |
| #7792 | ExecuteNonQuery |
netcoreapp3.1 | 2.61μs | 12ns | 46.4ns | 0 | 0 | 0 | 1.02 KB |
| #7792 | ExecuteNonQuery |
net472 | 2.95μs | 4.13ns | 16ns | 0.146 | 0.0146 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.74μs | 0.596ns | 2.31ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.2μs | 11.4ns | 54.5ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.52μs | 1.9ns | 7.36ns | 0.158 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.92μs | 4.09ns | 15.3ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.35μs | 8.99ns | 33.6ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.7μs | 1.85ns | 6.93ns | 0.166 | 0 | 0 | 1.1 KB |
| #7792 | CallElasticsearch |
net6.0 | 1.74μs | 8.96ns | 41.1ns | 0 | 0 | 0 | 1.03 KB |
| #7792 | CallElasticsearch |
netcoreapp3.1 | 2.16μs | 10.9ns | 48.7ns | 0 | 0 | 0 | 1.03 KB |
| #7792 | CallElasticsearch |
net472 | 3.73μs | 1.35ns | 5.22ns | 0.148 | 0 | 0 | 1.04 KB |
| #7792 | CallElasticsearchAsync |
net6.0 | 1.87μs | 2.2ns | 8.53ns | 0 | 0 | 0 | 1.01 KB |
| #7792 | CallElasticsearchAsync |
netcoreapp3.1 | 2.39μs | 7.49ns | 29ns | 0 | 0 | 0 | 1.08 KB |
| #7792 | CallElasticsearchAsync |
net472 | 3.72μs | 3.68ns | 14.2ns | 0.167 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.83μs | 1.05ns | 3.95ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.53μs | 11.6ns | 44.8ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.56μs | 1.3ns | 5.04ns | 0.142 | 0 | 0 | 915 B |
| #7792 | ExecuteAsync |
net6.0 | 1.83μs | 8.46ns | 32.8ns | 0 | 0 | 0 | 952 B |
| #7792 | ExecuteAsync |
netcoreapp3.1 | 2.46μs | 10.4ns | 40.1ns | 0 | 0 | 0 | 952 B |
| #7792 | ExecuteAsync |
net472 | 2.58μs | 2.02ns | 7.83ns | 0.143 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 6.86μs | 10.9ns | 40.8ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.33μs | 26.3ns | 102ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.1μs | 7.49ns | 28ns | 0.482 | 0 | 0 | 3.18 KB |
| #7792 | SendAsync |
net6.0 | 7.14μs | 22.5ns | 84.1ns | 0 | 0 | 0 | 2.36 KB |
| #7792 | SendAsync |
netcoreapp3.1 | 8.69μs | 5.69ns | 22ns | 0 | 0 | 0 | 2.9 KB |
| #7792 | SendAsync |
net472 | 12.3μs | 12.2ns | 47.2ns | 0.492 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7792
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
44.04 KB
45.5 KB
1.46 KB
3.32%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
278.53 KB
286.72 KB
8.19 KB
2.94%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
274.06 KB
278.19 KB
4.14 KB
1.51%
Fewer allocations 🎉 in #7792
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
278.21 KB
275.63 KB
-2.58 KB
-0.93%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
46.16 KB
43.82 KB
-2.34 KB
-5.08%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 | 44.04 KB | 45.5 KB | 1.46 KB | 3.32% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 278.53 KB | 286.72 KB | 8.19 KB | 2.94% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 274.06 KB | 278.19 KB | 4.14 KB | 1.51% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 278.21 KB | 275.63 KB | -2.58 KB | -0.93% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 46.16 KB | 43.82 KB | -2.34 KB | -5.08% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 43.2μs | 260ns | 2.45μs | 0 | 0 | 0 | 46.16 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 46.8μs | 168ns | 606ns | 0 | 0 | 0 | 44.04 KB |
| master | StringConcatBenchmark |
net472 | 56.8μs | 227ns | 849ns | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 470μs | 1.36μs | 4.71μs | 0 | 0 | 0 | 278.21 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 553μs | 1.31μs | 4.9μs | 0 | 0 | 0 | 274.06 KB |
| master | StringConcatAspectBenchmark |
net472 | 411μs | 2.01μs | 13.3μs | 0 | 0 | 0 | 278.53 KB |
| #7792 | StringConcatBenchmark |
net6.0 | 45.8μs | 237ns | 1.19μs | 0 | 0 | 0 | 43.82 KB |
| #7792 | StringConcatBenchmark |
netcoreapp3.1 | 58.7μs | 826ns | 8.22μs | 0 | 0 | 0 | 45.5 KB |
| #7792 | StringConcatBenchmark |
net472 | 56.6μs | 257ns | 994ns | 0 | 0 | 0 | 57.34 KB |
| #7792 | StringConcatAspectBenchmark |
net6.0 | 471μs | 1.62μs | 5.62μs | 0 | 0 | 0 | 275.63 KB |
| #7792 | StringConcatAspectBenchmark |
netcoreapp3.1 | 526μs | 1.45μs | 5.04μs | 0 | 0 | 0 | 278.19 KB |
| #7792 | StringConcatAspectBenchmark |
net472 | 402μs | 2.07μs | 9.24μs | 0 | 0 | 0 | 286.72 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.68μs | 10.7ns | 41.6ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.6μs | 17ns | 70.3ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 4.04μs | 4.82ns | 18ns | 0.24 | 0 | 0 | 1.64 KB |
| #7792 | EnrichedLog |
net6.0 | 2.7μs | 14.4ns | 72.2ns | 0 | 0 | 0 | 1.7 KB |
| #7792 | EnrichedLog |
netcoreapp3.1 | 3.62μs | 15.6ns | 62.2ns | 0 | 0 | 0 | 1.7 KB |
| #7792 | EnrichedLog |
net472 | 3.83μs | 3.47ns | 13.4ns | 0.248 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #7792
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0
1.113
136,821.94
122,875.89
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 | 1.113 | 136,821.94 | 122,875.89 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 137μs | 243ns | 875ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 130μs | 678ns | 3.96μs | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 174μs | 980ns | 6.65μs | 0 | 0 | 0 | 4.51 KB |
| #7792 | EnrichedLog |
net6.0 | 123μs | 61.8ns | 223ns | 0 | 0 | 0 | 4.31 KB |
| #7792 | EnrichedLog |
netcoreapp3.1 | 130μs | 501ns | 1.87μs | 0 | 0 | 0 | 4.31 KB |
| #7792 | EnrichedLog |
net472 | 167μs | 90.1ns | 337ns | 0 | 0 | 0 | 4.52 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.96μs | 25.1ns | 109ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.68μs | 30.2ns | 117ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.55μs | 9.55ns | 37ns | 0.3 | 0 | 0 | 2.08 KB |
| #7792 | EnrichedLog |
net6.0 | 4.84μs | 4.18ns | 15.1ns | 0 | 0 | 0 | 2.26 KB |
| #7792 | EnrichedLog |
netcoreapp3.1 | 6.84μs | 22.8ns | 88.2ns | 0 | 0 | 0 | 2.26 KB |
| #7792 | EnrichedLog |
net472 | 7.55μs | 8.02ns | 31.1ns | 0.303 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.04μs | 3.2ns | 12.4ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.69μs | 12ns | 43.1ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.04μs | 2.74ns | 10.6ns | 0.183 | 0 | 0 | 1.2 KB |
| #7792 | SendReceive |
net6.0 | 1.98μs | 4.3ns | 16.7ns | 0 | 0 | 0 | 1.2 KB |
| #7792 | SendReceive |
netcoreapp3.1 | 2.59μs | 11.5ns | 44.4ns | 0 | 0 | 0 | 1.2 KB |
| #7792 | SendReceive |
net472 | 2.97μs | 3.84ns | 14.4ns | 0.177 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.31μs | 16.4ns | 61.5ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.77μs | 9.03ns | 35ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.52μs | 7.68ns | 29.7ns | 0.293 | 0 | 0 | 2.03 KB |
| #7792 | EnrichedLog |
net6.0 | 4.19μs | 4.16ns | 15.6ns | 0 | 0 | 0 | 1.58 KB |
| #7792 | EnrichedLog |
netcoreapp3.1 | 5.57μs | 17.4ns | 67.5ns | 0 | 0 | 0 | 1.63 KB |
| #7792 | EnrichedLog |
net472 | 6.81μs | 6.66ns | 24.9ns | 0.308 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 769ns | 4.12ns | 21.8ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 943ns | 4.54ns | 17.6ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 919ns | 0.765ns | 2.96ns | 0.0877 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 938ns | 0.458ns | 1.71ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.2μs | 5.39ns | 20.9ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.13μs | 0.537ns | 2.08ns | 0.101 | 0 | 0 | 658 B |
| #7792 | StartFinishSpan |
net6.0 | 761ns | 3.69ns | 14.7ns | 0 | 0 | 0 | 576 B |
| #7792 | StartFinishSpan |
netcoreapp3.1 | 963ns | 5.03ns | 26.2ns | 0 | 0 | 0 | 576 B |
| #7792 | StartFinishSpan |
net472 | 924ns | 0.393ns | 1.52ns | 0.0876 | 0 | 0 | 578 B |
| #7792 | StartFinishScope |
net6.0 | 928ns | 1.89ns | 7.32ns | 0 | 0 | 0 | 696 B |
| #7792 | StartFinishScope |
netcoreapp3.1 | 1.21μs | 6.11ns | 26.6ns | 0 | 0 | 0 | 696 B |
| #7792 | StartFinishScope |
net472 | 1.13μs | 0.766ns | 2.97ns | 0.102 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.05μs | 0.921ns | 3.57ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.43μs | 5.48ns | 21.2ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.46μs | 0.823ns | 3.19ns | 0.102 | 0 | 0 | 658 B |
| #7792 | RunOnMethodBegin |
net6.0 | 1.09μs | 5.72ns | 29.7ns | 0 | 0 | 0 | 696 B |
| #7792 | RunOnMethodBegin |
netcoreapp3.1 | 1.45μs | 7.16ns | 31.2ns | 0 | 0 | 0 | 696 B |
| #7792 | RunOnMethodBegin |
net472 | 1.42μs | 1.02ns | 3.97ns | 0.0991 | 0 | 0 | 658 B |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7792) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (74ms) : 70, 78
master - mean (76ms) : 71, 80
section Bailout
This PR (7792) - mean (78ms) : 72, 83
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (7792) - mean (1,098ms) : 1044, 1152
master - mean (1,123ms) : 1040, 1206
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (116ms) : 108, 124
master - mean (117ms) : 110, 125
section Bailout
This PR (7792) - mean (118ms) : 110, 126
master - mean (119ms) : 110, 129
section CallTarget+Inlining+NGEN
This PR (7792) - mean (797ms) : 759, 835
master - mean (815ms) : 772, 857
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (104ms) : 95, 113
master - mean (105ms) : 99, 110
section Bailout
This PR (7792) - mean (103ms) : 98, 109
master - mean (106ms) : 99, 113
section CallTarget+Inlining+NGEN
This PR (7792) - mean (743ms) : 708, 779
master - mean (759ms) : 720, 799
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (99ms) : 93, 106
master - mean (107ms) : 97, 116
section Bailout
This PR (7792) - mean (101ms) : 96, 106
master - mean (104ms) : 97, 111
section CallTarget+Inlining+NGEN
This PR (7792) - mean (701ms) : 673, 728
master - mean (724ms) : 697, 751
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (196ms) : 189, 204
master - mean (192ms) : 189, 196
section Bailout
This PR (7792) - mean (198ms) : 194, 202
master - mean (196ms) : 193, 200
section CallTarget+Inlining+NGEN
This PR (7792) - mean (1,179ms) : 1110, 1249
master - mean (1,156ms) : 1110, 1202
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (284ms) : 266, 302
master - mean (276ms) : 271, 282
section Bailout
This PR (7792) - mean (281ms) : 273, 289
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (7792) - mean (954ms) : 913, 995
master - mean (938ms) : 893, 983
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (269ms) : 265, 273
master - mean (268ms) : 262, 274
section Bailout
This PR (7792) - mean (269ms) : 266, 272
master - mean (289ms) : 282, 296
section CallTarget+Inlining+NGEN
This PR (7792) - mean (926ms) : 885, 967
master - mean (948ms) : 882, 1015
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7792) - mean (269ms) : 264, 274
master - mean (272ms) : 261, 282
section Bailout
This PR (7792) - mean (270ms) : 265, 275
master - mean (272ms) : 264, 280
section CallTarget+Inlining+NGEN
This PR (7792) - mean (853ms) : 830, 877
master - mean (865ms) : 827, 904
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Reason for change
Implementation details
Test coverage
Other details