Skip to content

[Test Package Versions Bump] Updating package versions #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Test Package Versions Bump] Updating package versions #7794

wants to merge 1 commit into from
+1,404 −1,201

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Nov 9, 2025

Updates the package versions for integration tests.

@dd-octo-sts dd-octo-sts bot added area:dependabot dependabot updates area:test-apps apps used to test integrations labels Nov 9, 2025
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner November 9, 2025 00:27
@dd-octo-sts dd-octo-sts bot added the dependencies Pull requests that update a dependency file label Nov 9, 2025
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner November 9, 2025 00:27
@dd-octo-sts dd-octo-sts bot added area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Nov 9, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 9, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7794) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.47 ± (74.18 - 74.79) ms74.65 ± (74.78 - 75.57) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration79.72 ± (79.40 - 79.93) ms78.23 ± (77.94 - 78.62) ms-1.9%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1096.48 ± (1097.92 - 1107.47) ms1106.41 ± (1111.68 - 1123.58) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.06 ± (22.97 - 23.15) ms22.72 ± (22.66 - 22.78) ms-1.5%✅
process.time_to_main_ms87.83 ± (87.47 - 88.18) ms87.03 ± (86.65 - 87.41) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.88 ± (10.88 - 10.89) MB10.92 ± (10.91 - 10.92) MB+0.3%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms23.04 ± (22.96 - 23.11) ms22.70 ± (22.64 - 22.77) ms-1.4%✅
process.time_to_main_ms89.74 ± (89.30 - 90.18) ms88.33 ± (87.92 - 88.75) ms-1.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.96 ± (10.96 - 10.97) MB+0.4%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms217.42 ± (215.95 - 218.90) ms220.59 ± (219.23 - 221.94) ms+1.5%✅⬆️
process.time_to_main_ms545.30 ± (544.06 - 546.53) ms551.64 ± (550.46 - 552.83) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.66 ± (52.64 - 52.68) MB52.53 ± (52.51 - 52.55) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.50 ± (21.44 - 21.56) ms21.70 ± (21.63 - 21.76) ms+0.9%✅⬆️
process.time_to_main_ms74.57 ± (74.25 - 74.89) ms75.90 ± (75.58 - 76.22) ms+1.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.56 ± (10.56 - 10.56) MB10.64 ± (10.64 - 10.64) MB+0.8%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.41 ± (21.35 - 21.46) ms21.69 ± (21.63 - 21.76) ms+1.3%✅⬆️
process.time_to_main_ms76.13 ± (75.79 - 76.46) ms77.31 ± (76.97 - 77.64) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.61) MB10.67 ± (10.67 - 10.67) MB+0.5%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms205.75 ± (204.12 - 207.37) ms206.89 ± (205.54 - 208.24) ms+0.6%✅⬆️
process.time_to_main_ms511.40 ± (510.41 - 512.40) ms514.42 ± (513.52 - 515.32) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.76 ± (51.73 - 51.78) MB51.69 ± (51.65 - 51.72) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.53 ± (19.48 - 19.59) ms19.94 ± (19.88 - 20.00) ms+2.1%✅⬆️
process.time_to_main_ms73.74 ± (73.43 - 74.04) ms75.57 ± (75.24 - 75.90) ms+2.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.62 ± (7.61 - 7.63) MB7.67 ± (7.67 - 7.68) MB+0.7%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.52 ± (19.47 - 19.57) ms19.96 ± (19.90 - 20.02) ms+2.2%✅⬆️
process.time_to_main_ms75.06 ± (74.77 - 75.35) ms76.28 ± (76.00 - 76.57) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.72 ± (7.71 - 7.73) MB+0.7%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms189.34 ± (188.43 - 190.24) ms189.75 ± (188.73 - 190.78) ms+0.2%✅⬆️
process.time_to_main_ms490.52 ± (489.43 - 491.60) ms486.32 ± (485.29 - 487.35) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed38.99 ± (38.95 - 39.02) MB38.90 ± (38.86 - 38.95) MB-0.2%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.09 ± (192.94 - 193.82) ms192.52 ± (192.33 - 193.10) ms-0.3%✅
.NET Framework 4.8 - Bailout
duration196.26 ± (196.23 - 196.82) ms195.80 ± (195.64 - 196.19) ms-0.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1159.28 ± (1164.78 - 1174.53) ms1166.11 ± (1165.34 - 1173.17) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.41 ± (187.10 - 187.72) ms188.14 ± (187.71 - 188.58) ms+0.4%✅⬆️
process.time_to_main_ms81.04 ± (80.81 - 81.26) ms80.58 ± (80.34 - 80.81) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.06 ± (16.03 - 16.09) MB16.15 ± (16.12 - 16.19) MB+0.6%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.31 ± (186.97 - 187.64) ms187.27 ± (186.93 - 187.61) ms-0.0%✅
process.time_to_main_ms82.40 ± (82.21 - 82.58) ms81.92 ± (81.77 - 82.06) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.06 - 16.13) MB16.19 ± (16.17 - 16.22) MB+0.6%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.1%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms392.01 ± (389.73 - 394.29) ms398.70 ± (396.05 - 401.34) ms+1.7%✅⬆️
process.time_to_main_ms518.84 ± (518.18 - 519.50) ms518.97 ± (518.26 - 519.67) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed62.75 ± (62.60 - 62.90) MB63.11 ± (62.96 - 63.27) MB+0.6%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms191.37 ± (191.07 - 191.67) ms191.77 ± (191.37 - 192.16) ms+0.2%✅⬆️
process.time_to_main_ms69.60 ± (69.43 - 69.76) ms69.70 ± (69.55 - 69.85) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.30 ± (16.22 - 16.38) MB16.14 ± (16.01 - 16.26) MB-1.0%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.3%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.18 ± (190.89 - 191.46) ms190.63 ± (190.33 - 190.93) ms-0.3%✅
process.time_to_main_ms70.56 ± (70.47 - 70.65) ms70.63 ± (70.53 - 70.74) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.26 ± (16.15 - 16.37) MB16.17 ± (16.03 - 16.30) MB-0.6%✅
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 19)-1.4%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.60 ± (408.75 - 414.45) ms411.04 ± (407.97 - 414.11) ms-0.1%✅
process.time_to_main_ms486.96 ± (486.36 - 487.57) ms488.30 ± (487.57 - 489.04) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.39 ± (62.26 - 62.53) MB61.94 ± (61.79 - 62.09) MB-0.7%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms191.07 ± (190.78 - 191.35) ms189.45 ± (189.22 - 189.68) ms-0.8%✅
process.time_to_main_ms69.64 ± (69.44 - 69.83) ms68.90 ± (68.77 - 69.03) ms-1.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.71 ± (11.68 - 11.74) MB11.73 ± (11.70 - 11.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms190.27 ± (189.89 - 190.64) ms188.64 ± (188.39 - 188.89) ms-0.9%✅
process.time_to_main_ms70.65 ± (70.54 - 70.77) ms69.95 ± (69.86 - 70.04) ms-1.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.84) MB11.80 ± (11.77 - 11.83) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.6%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms359.69 ± (358.03 - 361.34) ms359.46 ± (357.69 - 361.23) ms-0.1%✅
process.time_to_main_ms468.31 ± (467.74 - 468.88) ms460.63 ± (460.00 - 461.25) ms-1.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.52 ± (50.48 - 50.56) MB50.28 ± (50.25 - 50.31) MB-0.5%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.3%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (75ms)  : 69, 81
    master - mean (74ms)  : 70, 79

    section Bailout
    This PR (7794) - mean (78ms)  : 73, 83
    master - mean (80ms)  : 76, 84

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (1,118ms)  : 1025, 1210
    master - mean (1,103ms)  : 1035, 1171
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (117ms)  : 109, 125
    master - mean (118ms)  : 111, 125

    section Bailout
    This PR (7794) - mean (119ms)  : 112, 126
    master - mean (120ms)  : 111, 129

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (814ms)  : 780, 847
    master - mean (796ms)  : 757, 835
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (105ms)  : 98, 112
    master - mean (103ms)  : 98, 109

    section Bailout
    This PR (7794) - mean (106ms)  : 101, 112
    master - mean (104ms)  : 97, 111

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (764ms)  : 733, 794
    master - mean (750ms)  : 710, 789
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (104ms)  : 96, 112
    master - mean (101ms)  : 95, 108

    section Bailout
    This PR (7794) - mean (105ms)  : 99, 110
    master - mean (103ms)  : 97, 109

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (717ms)  : 690, 745
    master - mean (710ms)  : 685, 734
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (193ms)  : 189, 197
    master - mean (193ms)  : 189, 198

    section Bailout
    This PR (7794) - mean (196ms)  : 193, 199
    master - mean (197ms)  : 193, 200

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (1,169ms)  : 1112, 1226
    master - mean (1,170ms)  : 1101, 1239
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (277ms)  : 271, 283
    master - mean (277ms)  : 273, 281

    section Bailout
    This PR (7794) - mean (278ms)  : 271, 284
    master - mean (278ms)  : 273, 283

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (957ms)  : 904, 1010
    master - mean (954ms)  : 918, 990
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (270ms)  : 265, 274
    master - mean (269ms)  : 265, 273

    section Bailout
    This PR (7794) - mean (269ms)  : 266, 273
    master - mean (270ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (932ms)  : 883, 982
    master - mean (931ms)  : 889, 972
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7794) - mean (268ms)  : 265, 271
    master - mean (270ms)  : 266, 274

    section Bailout
    This PR (7794) - mean (268ms)  : 265, 272
    master - mean (270ms)  : 264, 276

    section CallTarget+Inlining+NGEN
    This PR (7794) - mean (853ms)  : 831, 874
    master - mean (859ms)  : 840, 878
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 9, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7794 compared to master:

  • 1 benchmarks are faster, with geometric mean 2.101
  • 1 benchmarks are slower, with geometric mean 1.162
  • 4 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.13 KB 6.07 KB -60 B -0.98%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.2μs 56.6ns 330ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 13.4μs 72.4ns 403ns 0 0 0 5.73 KB
master StartStopWithChild net472 22.3μs 116ns 580ns 0.963 0.321 0 6.13 KB
#7794 StartStopWithChild net6.0 10.5μs 57.4ns 339ns 0 0 0 5.53 KB
#7794 StartStopWithChild netcoreapp3.1 13.9μs 67.5ns 278ns 0 0 0 5.73 KB
#7794 StartStopWithChild net472 22.3μs 114ns 559ns 0.914 0.343 0 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.35 KB 3.31 KB -46 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 936μs 570ns 2.21μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 149ns 577ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.22ms 73.8ns 286ns 0 0 0 3.35 KB
#7794 WriteAndFlushEnrichedTraces net6.0 931μs 165ns 618ns 0 0 0 2.71 KB
#7794 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 48.4ns 174ns 0 0 0 2.7 KB
#7794 WriteAndFlushEnrichedTraces net472 1.22ms 86.7ns 324ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.1μs 6.06ns 36.9ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.44μs 4.52ns 17.5ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.03μs 4.66ns 18.1ns 0.192 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.54μs 2.42ns 9.39ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 8.98μs 42.5ns 165ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.57μs 4.24ns 15.9ns 0.718 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 322ns 0.162ns 0.628ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 1.92ns 7.93ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0594ns 0.23ns 0.0438 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.34μs 20.6ns 79.6ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.89μs 28.1ns 109ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 5.28ns 20.4ns 0.599 0 0 3.8 KB
#7794 AllCycleSimpleBody net6.0 1.08μs 1.16ns 4.5ns 0 0 0 1.22 KB
#7794 AllCycleSimpleBody netcoreapp3.1 1.39μs 7.76ns 47.2ns 0 0 0 1.2 KB
#7794 AllCycleSimpleBody net472 1.02μs 0.599ns 2.32ns 0.191 0 0 1.23 KB
#7794 AllCycleMoreComplexBody net6.0 6.96μs 36.1ns 188ns 0 0 0 4.72 KB
#7794 AllCycleMoreComplexBody netcoreapp3.1 8.92μs 42.8ns 171ns 0 0 0 4.62 KB
#7794 AllCycleMoreComplexBody net472 7.77μs 4.93ns 19.1ns 0.737 0 0 4.74 KB
#7794 ObjectExtractorSimpleBody net6.0 317ns 1.8ns 12.7ns 0 0 0 280 B
#7794 ObjectExtractorSimpleBody netcoreapp3.1 395ns 2.24ns 15ns 0 0 0 272 B
#7794 ObjectExtractorSimpleBody net472 296ns 0.0643ns 0.24ns 0.0441 0 0 281 B
#7794 ObjectExtractorMoreComplexBody net6.0 6.27μs 31.1ns 136ns 0 0 0 3.78 KB
#7794 ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 34.4ns 133ns 0 0 0 3.69 KB
#7794 ObjectExtractorMoreComplexBody net472 6.71μs 4.86ns 18.8ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 77.8μs 57.3ns 207ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.1μs 18.4ns 71.3ns 0 0 0 32.4 KB
master EncodeArgs net472 112μs 21.8ns 84.6ns 5.01 0 0 32.5 KB
master EncodeLegacyArgs net6.0 144μs 30.9ns 120ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 584ns 2.26μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 297ns 1.15μs 0 0 0 2.16 KB
#7794 EncodeArgs net6.0 77.3μs 315ns 1.22μs 0 0 0 32.4 KB
#7794 EncodeArgs netcoreapp3.1 98.5μs 194ns 751ns 0 0 0 32.4 KB
#7794 EncodeArgs net472 109μs 28.1ns 105ns 4.92 0 0 32.51 KB
#7794 EncodeLegacyArgs net6.0 144μs 14.6ns 56.6ns 0 0 0 2.14 KB
#7794 EncodeLegacyArgs netcoreapp3.1 198μs 687ns 2.66μs 0 0 0 2.14 KB
#7794 EncodeLegacyArgs net472 265μs 61.7ns 239ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7794

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.101 863,958.96 411,278.54

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 388μs 52.7ns 204ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 854μs 5.45μs 54.2μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 430μs 50.4ns 195ns 0 0 0 4.68 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 43.5ns 168ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 299μs 45.1ns 163ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 315μs 19.8ns 68.5ns 0 0 0 2.29 KB
#7794 RunWafRealisticBenchmark net6.0 392μs 116ns 433ns 0 0 0 4.56 KB
#7794 RunWafRealisticBenchmark netcoreapp3.1 411μs 93.4ns 349ns 0 0 0 4.48 KB
#7794 RunWafRealisticBenchmark net472 430μs 44.2ns 165ns 0 0 0 4.66 KB
#7794 RunWafRealisticBenchmarkWithAttack net6.0 284μs 40.8ns 153ns 0 0 0 2.24 KB
#7794 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 297μs 205ns 793ns 0 0 0 2.22 KB
#7794 RunWafRealisticBenchmarkWithAttack net472 310μs 117ns 452ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.3μs 65.9ns 255ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.1μs 294ns 1.02μs 0 0 0 17.42 KB
master SendRequest net472 0.00355ns 0.00163ns 0.0063ns 0 0 0 0 b
#7794 SendRequest net6.0 61μs 89.4ns 322ns 0 0 0 14.52 KB
#7794 SendRequest netcoreapp3.1 71.7μs 71.1ns 266ns 0 0 0 17.42 KB
#7794 SendRequest net472 0.00253ns 0.00115ns 0.00444ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7794

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 1.162 832,945.21 968,018.14

More allocations ⚠️ in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 0 b 1 B 1 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 2 B 8 B 6 B 300.00%

Fewer allocations 🎉 in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 3 B -1 B -25.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 1.23μs 4.43μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.13ms 5.59μs 20.9μs 0 0 0 640 KB
master OriginalCharSlice net472 2.75ms 2.21μs 8.55μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.45ms 420ns 1.63μs 0 0 0 2 B
master OptimizedCharSlice netcoreapp3.1 1.78ms 456ns 1.64μs 0 0 0 1 B
master OptimizedCharSlice net472 1.93ms 367ns 1.42μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 833μs 31.9ns 119ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 797μs 125ns 484ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.21ms 137ns 532ns 0 0 0 47 B
#7794 OriginalCharSlice net6.0 1.94ms 5.48μs 21.2μs 0 0 0 640.01 KB
#7794 OriginalCharSlice netcoreapp3.1 2.12ms 2.1μs 7.59μs 0 0 0 640 KB
#7794 OriginalCharSlice net472 2.56ms 1.25μs 4.86μs 100 0 0 641.95 KB
#7794 OptimizedCharSlice net6.0 1.46ms 117ns 453ns 0 0 0 8 B
#7794 OptimizedCharSlice netcoreapp3.1 1.89ms 1.16μs 4.48μs 0 0 0 1 B
#7794 OptimizedCharSlice net472 1.97ms 239ns 927ns 0 0 0 73 B
#7794 OptimizedCharSliceWithPool net6.0 966μs 817ns 3.17μs 0 0 0 3 B
#7794 OptimizedCharSliceWithPool netcoreapp3.1 836μs 122ns 473ns 0 0 0 1 B
#7794 OptimizedCharSliceWithPool net472 1.15ms 108ns 417ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.99 KB 43.13 KB 1.14 KB 2.71%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.89 KB 42.4 KB 513 B 1.22%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 728μs 3.93μs 21.2μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 729μs 4.22μs 34.3μs 0 0 0 41.99 KB
master WriteAndFlushEnrichedTraces net472 878μs 2.59μs 10μs 8.33 0 0 56.32 KB
#7794 WriteAndFlushEnrichedTraces net6.0 707μs 2.46μs 16.5μs 0 0 0 42.4 KB
#7794 WriteAndFlushEnrichedTraces netcoreapp3.1 742μs 1.3μs 5.02μs 0 0 0 43.13 KB
#7794 WriteAndFlushEnrichedTraces net472 977μs 4.98μs 24.4μs 4.81 0 0 56.05 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.88μs 8.77ns 34ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.6μs 9.98ns 38.6ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.85μs 3.8ns 14.7ns 0.157 0.0143 0 987 B
#7794 ExecuteNonQuery net6.0 1.97μs 3.3ns 12.8ns 0 0 0 1.02 KB
#7794 ExecuteNonQuery netcoreapp3.1 2.61μs 6.68ns 25.9ns 0 0 0 1.02 KB
#7794 ExecuteNonQuery net472 2.88μs 3.85ns 14.9ns 0.143 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.7μs 7.42ns 28.8ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.28μs 9.76ns 37.8ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.66μs 2.55ns 9.89ns 0.165 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.83μs 2.08ns 8.05ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.34μs 12ns 57.6ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.81μs 7.47ns 28.9ns 0.17 0 0 1.1 KB
#7794 CallElasticsearch net6.0 1.68μs 8.69ns 41.7ns 0 0 0 1.03 KB
#7794 CallElasticsearch netcoreapp3.1 2.19μs 11.2ns 52.6ns 0 0 0 1.03 KB
#7794 CallElasticsearch net472 3.62μs 6.15ns 23.8ns 0.163 0 0 1.04 KB
#7794 CallElasticsearchAsync net6.0 1.85μs 5.05ns 19.5ns 0 0 0 1.01 KB
#7794 CallElasticsearchAsync netcoreapp3.1 2.33μs 11.1ns 44.5ns 0 0 0 1.08 KB
#7794 CallElasticsearchAsync net472 3.71μs 3.27ns 12.2ns 0.166 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.94μs 4.93ns 19.1ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.49μs 2.47ns 9.55ns 0 0 0 952 B
master ExecuteAsync net472 2.7μs 2.06ns 7.72ns 0.135 0 0 915 B
#7794 ExecuteAsync net6.0 1.89μs 4.01ns 15.5ns 0 0 0 952 B
#7794 ExecuteAsync netcoreapp3.1 2.43μs 7.71ns 29.8ns 0 0 0 952 B
#7794 ExecuteAsync net472 2.57μs 0.876ns 3.39ns 0.141 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.88μs 17.6ns 65.8ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.81μs 22.5ns 77.8ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 6.18ns 23.9ns 0.493 0 0 3.18 KB
#7794 SendAsync net6.0 6.8μs 18.7ns 72.5ns 0 0 0 2.36 KB
#7794 SendAsync netcoreapp3.1 8.57μs 14.8ns 57.2ns 0 0 0 2.9 KB
#7794 SendAsync net472 12.3μs 5.93ns 22.9ns 0.488 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 44.04 KB 86.74 KB 42.7 KB 96.97%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 260.26 KB 275.62 KB 15.37 KB 5.90%

Fewer allocations 🎉 in #7794

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 47μs 371ns 3.53μs 0 0 0 43.22 KB
master StringConcatBenchmark netcoreapp3.1 47μs 230ns 921ns 0 0 0 44.04 KB
master StringConcatBenchmark net472 56.7μs 266ns 1.06μs 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 483μs 2.34μs 10.2μs 0 0 0 260.26 KB
master StringConcatAspectBenchmark netcoreapp3.1 526μs 1.54μs 5.54μs 0 0 0 276.34 KB
master StringConcatAspectBenchmark net472 411μs 2.35μs 17.6μs 0 0 0 278.63 KB
#7794 StringConcatBenchmark net6.0 43μs 226ns 1.41μs 0 0 0 43.18 KB
#7794 StringConcatBenchmark netcoreapp3.1 49.5μs 239ns 1.77μs 0 0 0 86.74 KB
#7794 StringConcatBenchmark net472 57.8μs 198ns 742ns 0 0 0 57.34 KB
#7794 StringConcatAspectBenchmark net6.0 455μs 1.19μs 4.31μs 0 0 0 275.62 KB
#7794 StringConcatAspectBenchmark netcoreapp3.1 513μs 2.49μs 11.1μs 0 0 0 275.65 KB
#7794 StringConcatAspectBenchmark net472 402μs 1.77μs 12.3μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.7μs 13.7ns 65.9ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.89μs 3.62ns 14ns 0 0 0 1.7 KB
master EnrichedLog net472 4μs 5.41ns 20.9ns 0.257 0 0 1.64 KB
#7794 EnrichedLog net6.0 2.67μs 13ns 52.1ns 0 0 0 1.7 KB
#7794 EnrichedLog netcoreapp3.1 3.6μs 17.4ns 73.8ns 0 0 0 1.7 KB
#7794 EnrichedLog net472 3.99μs 10ns 38.9ns 0.258 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 44.5ns 167ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 152ns 570ns 0 0 0 4.31 KB
master EnrichedLog net472 165μs 54.2ns 203ns 0 0 0 4.51 KB
#7794 EnrichedLog net6.0 123μs 51.3ns 185ns 0 0 0 4.31 KB
#7794 EnrichedLog netcoreapp3.1 128μs 525ns 1.96μs 0 0 0 4.31 KB
#7794 EnrichedLog net472 169μs 120ns 450ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.89μs 15.5ns 58.2ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.81μs 14.3ns 55.4ns 0 0 0 2.26 KB
master EnrichedLog net472 7.51μs 6.44ns 25ns 0.299 0 0 2.08 KB
#7794 EnrichedLog net6.0 5.07μs 14.7ns 56.8ns 0 0 0 2.26 KB
#7794 EnrichedLog netcoreapp3.1 7.08μs 19.8ns 76.7ns 0 0 0 2.26 KB
#7794 EnrichedLog net472 7.5μs 6.04ns 23.4ns 0.3 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.99μs 9.19ns 35.6ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.67μs 8.25ns 32ns 0 0 0 1.2 KB
master SendReceive net472 3.07μs 5.94ns 23ns 0.184 0 0 1.2 KB
#7794 SendReceive net6.0 1.97μs 9.47ns 37.9ns 0 0 0 1.2 KB
#7794 SendReceive netcoreapp3.1 2.65μs 10.7ns 41.5ns 0 0 0 1.2 KB
#7794 SendReceive net472 3.12μs 4.16ns 15.6ns 0.185 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.32μs 11.3ns 43.9ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.68μs 11.5ns 43.2ns 0 0 0 1.63 KB
master EnrichedLog net472 6.59μs 10.6ns 41.1ns 0.297 0 0 2.03 KB
#7794 EnrichedLog net6.0 4.33μs 11.2ns 43.4ns 0 0 0 1.58 KB
#7794 EnrichedLog netcoreapp3.1 5.56μs 13.7ns 51.3ns 0 0 0 1.63 KB
#7794 EnrichedLog net472 6.56μs 7.62ns 29.5ns 0.292 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 775ns 4ns 21.1ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 977ns 1.35ns 5.24ns 0 0 0 576 B
master StartFinishSpan net472 922ns 0.603ns 2.33ns 0.0882 0 0 578 B
master StartFinishScope net6.0 949ns 4.46ns 17.3ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 6.61ns 40.2ns 0 0 0 696 B
master StartFinishScope net472 1.14μs 2.95ns 11.4ns 0.104 0 0 658 B
#7794 StartFinishSpan net6.0 774ns 4.04ns 19ns 0 0 0 576 B
#7794 StartFinishSpan netcoreapp3.1 963ns 4.67ns 19.8ns 0 0 0 576 B
#7794 StartFinishSpan net472 938ns 0.756ns 2.93ns 0.0894 0 0 578 B
#7794 StartFinishScope net6.0 918ns 4.9ns 25.5ns 0 0 0 696 B
#7794 StartFinishScope netcoreapp3.1 1.2μs 6.36ns 34.2ns 0 0 0 696 B
#7794 StartFinishScope net472 1.12μs 0.514ns 1.99ns 0.101 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.09μs 2.16ns 8.35ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 6.93ns 29.4ns 0 0 0 696 B
master RunOnMethodBegin net472 1.47μs 1.39ns 5.38ns 0.102 0 0 658 B
#7794 RunOnMethodBegin net6.0 1.07μs 5.73ns 28.7ns 0 0 0 696 B
#7794 RunOnMethodBegin netcoreapp3.1 1.42μs 7.09ns 31.7ns 0 0 0 696 B
#7794 RunOnMethodBegin net472 1.45μs 0.657ns 2.54ns 0.102 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:dependabot dependabot updates area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock