fix(openfeature): isolate invalid flags [backport v2.9] - #5105
Conversation
Use the shared FFE fixture corpus. This prevents copied Go fixtures from drifting from other SDKs. The same migration is merged in [Java](DataDog/dd-trace-java#11355) and [libdatadog](DataDog/libdatadog#1979). Related migrations are open for [Python](DataDog/dd-trace-py#19390), [JavaScript](DataDog/dd-trace-js#8441), [Ruby](DataDog/dd-trace-rb#5742), and [.NET](DataDog/dd-trace-dotnet#8616). - Add `DataDog/ffe-system-test-data` as an OpenFeature test submodule. - Read all canonical configuration and evaluation cases from the submodule. - Parse and validate flags independently so one invalid flag does not reject valid neighbors. - Assert canonical values and reasons, including temporal defaults and missing-flag errors. - Initialize submodules in Go test workflows and configure weekly Dependabot updates. Co-authored-by: leo.romanovsky <leo.romanovsky@datadoghq.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 28ec9e5 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-08-05 20:59:08 Comparing candidate commit 28ec9e5 in PR branch Found 4 performance improvements and 0 performance regressions! Performance is the same for 269 metrics, 2 unstable metrics, 1 flaky benchmarks without significant changes.
|
darccio
left a comment
There was a problem hiding this comment.
Approving on behalf of @DataDog/dd-trace-go-guild as the original PR was reviewed and approved.
d6a9172 to
28ec9e5
Compare
|
Failures are unrelated. |
Motivation
A malformed flag can reject the complete UFC configuration. This makes unrelated flags return defaults.
Backport the exact merged main commit 6d96ff5424 to
release-v2.9.x. A compatibility commit adapts tests to the older evaluator signature.Changes and Decisions