Mark Kafka DSM disabled batch consume test flaky for parentId mismatch#10795
Closed
Mark Kafka DSM disabled batch consume test flaky for parentId mismatch#10795
Conversation
…atch The test "test spring kafka template produce and batch consume" was already annotated @flaky for partition ordering issues. Update the annotation to also document the consumer span parentId mismatch failure mode that occurs due to non-deterministic trace ordering in KafkaClientDataStreamsDisabledForkedTest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing — need to fix the non-deterministic consumer→producer trace mapping rather than update @flaky message |
Contributor
|
Addressed in #11168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates the
@Flakyannotation ontest spring kafka template produce and batch consumeinKafkaClientTestBaseto document the consumer spanparentIdmismatch failure mode in addition to the previously documented partition ordering issue.Motivation
The test
KafkaClientDataStreamsDisabledForkedTest→test spring kafka template produce and batch consumewas observed failing in CI with:This failure occurs because the
elsebranch of theassertTracesblock (used whenhasQueueSpan()is false) assumes a deterministic mapping between consumer trace ordering and producer span indices within trace(0). SinceSORT_TRACES_BY_IDuses random trace IDs, the consumer-to-producer linkage is non-deterministic.The test was already annotated
@Flakyfor a related partition-ordering issue (#3864). This PR updates the annotation message to accurately describe all known failure modes from this same root cause.Additional Notes
@FlakyissueContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A