Migrate dd-trace-core groovy files to java part 4 #11146
Migrate dd-trace-core groovy files to java part 4 #11146
Conversation
we migrate 3 tests: - CoreSpanBuilderTest - CoreTracerTest - DDSpanContextPropagationTagsTest
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054770
Total [baseline] (11.065 s) : 0, 11064857
Agent [candidate] (1.053 s) : 0, 1053286
Total [candidate] (10.997 s) : 0, 10997150
section appsec
Agent [baseline] (1.249 s) : 0, 1248874
Total [baseline] (11.165 s) : 0, 11164741
Agent [candidate] (1.247 s) : 0, 1247008
Total [candidate] (11.06 s) : 0, 11059958
section iast
Agent [baseline] (1.231 s) : 0, 1230834
Total [baseline] (11.219 s) : 0, 11218769
Agent [candidate] (1.228 s) : 0, 1228199
Total [candidate] (11.245 s) : 0, 11245465
section profiling
Agent [baseline] (1.19 s) : 0, 1189806
Total [baseline] (10.993 s) : 0, 10993215
Agent [candidate] (1.184 s) : 0, 1183836
Total [candidate] (11.061 s) : 0, 11060619
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (632.202 ms) : 0, 632202
BytebuddyAgent [candidate] (631.134 ms) : 0, 631134
AgentMeter [baseline] (29.416 ms) : 0, 29416
AgentMeter [candidate] (29.367 ms) : 0, 29367
GlobalTracer [baseline] (248.415 ms) : 0, 248415
GlobalTracer [candidate] (248.325 ms) : 0, 248325
AppSec [baseline] (32.18 ms) : 0, 32180
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (59.833 ms) : 0, 59833
Debugger [candidate] (59.927 ms) : 0, 59927
Remote Config [baseline] (585.419 µs) : 0, 585
Remote Config [candidate] (592.137 µs) : 0, 592
Telemetry [baseline] (8.041 ms) : 0, 8041
Telemetry [candidate] (8.015 ms) : 0, 8015
Flare Poller [baseline] (6.757 ms) : 0, 6757
Flare Poller [candidate] (6.523 ms) : 0, 6523
section appsec
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (661.681 ms) : 0, 661681
BytebuddyAgent [candidate] (661.253 ms) : 0, 661253
AgentMeter [baseline] (12.051 ms) : 0, 12051
AgentMeter [candidate] (12.05 ms) : 0, 12050
GlobalTracer [baseline] (249.036 ms) : 0, 249036
GlobalTracer [candidate] (248.293 ms) : 0, 248293
IAST [baseline] (24.535 ms) : 0, 24535
IAST [candidate] (24.585 ms) : 0, 24585
AppSec [baseline] (185.099 ms) : 0, 185099
AppSec [candidate] (184.911 ms) : 0, 184911
Debugger [baseline] (66.208 ms) : 0, 66208
Debugger [candidate] (65.873 ms) : 0, 65873
Remote Config [baseline] (619.92 µs) : 0, 620
Remote Config [candidate] (608.909 µs) : 0, 609
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.397 ms) : 0, 8397
Flare Poller [baseline] (3.576 ms) : 0, 3576
Flare Poller [candidate] (3.567 ms) : 0, 3567
section iast
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (805.987 ms) : 0, 805987
BytebuddyAgent [candidate] (803.176 ms) : 0, 803176
AgentMeter [baseline] (11.464 ms) : 0, 11464
AgentMeter [candidate] (11.433 ms) : 0, 11433
GlobalTracer [baseline] (239.795 ms) : 0, 239795
GlobalTracer [candidate] (240.128 ms) : 0, 240128
IAST [baseline] (25.932 ms) : 0, 25932
IAST [candidate] (25.911 ms) : 0, 25911
AppSec [baseline] (33.826 ms) : 0, 33826
AppSec [candidate] (31.323 ms) : 0, 31323
Debugger [baseline] (61.153 ms) : 0, 61153
Debugger [candidate] (62.436 ms) : 0, 62436
Remote Config [baseline] (542.603 µs) : 0, 543
Remote Config [candidate] (544.864 µs) : 0, 545
Telemetry [baseline] (11.054 ms) : 0, 11054
Telemetry [candidate] (12.353 ms) : 0, 12353
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.467 ms) : 0, 3467
section profiling
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (695.444 ms) : 0, 695444
BytebuddyAgent [candidate] (690.845 ms) : 0, 690845
AgentMeter [baseline] (9.145 ms) : 0, 9145
AgentMeter [candidate] (9.117 ms) : 0, 9117
GlobalTracer [baseline] (208.173 ms) : 0, 208173
GlobalTracer [candidate] (207.05 ms) : 0, 207050
AppSec [baseline] (32.718 ms) : 0, 32718
AppSec [candidate] (32.864 ms) : 0, 32864
Debugger [baseline] (65.972 ms) : 0, 65972
Debugger [candidate] (65.554 ms) : 0, 65554
Remote Config [baseline] (588.516 µs) : 0, 589
Remote Config [candidate] (565.1 µs) : 0, 565
Telemetry [baseline] (7.771 ms) : 0, 7771
Telemetry [candidate] (7.816 ms) : 0, 7816
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.591 ms) : 0, 3591
ProfilingAgent [baseline] (94.018 ms) : 0, 94018
ProfilingAgent [candidate] (94.086 ms) : 0, 94086
Profiling [baseline] (94.585 ms) : 0, 94585
Profiling [candidate] (94.652 ms) : 0, 94652
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058948
Total [baseline] (8.806 s) : 0, 8806128
Agent [candidate] (1.06 s) : 0, 1059884
Total [candidate] (8.857 s) : 0, 8857173
section iast
Agent [baseline] (1.225 s) : 0, 1224898
Total [baseline] (9.582 s) : 0, 9581941
Agent [candidate] (1.232 s) : 0, 1232068
Total [candidate] (9.547 s) : 0, 9547194
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.248 ms) : 0, 1248
BytebuddyAgent [baseline] (635.723 ms) : 0, 635723
BytebuddyAgent [candidate] (634.404 ms) : 0, 634404
AgentMeter [baseline] (29.585 ms) : 0, 29585
AgentMeter [candidate] (29.388 ms) : 0, 29388
GlobalTracer [baseline] (249.371 ms) : 0, 249371
GlobalTracer [candidate] (250.228 ms) : 0, 250228
AppSec [baseline] (32.539 ms) : 0, 32539
AppSec [candidate] (32.611 ms) : 0, 32611
Debugger [baseline] (59.044 ms) : 0, 59044
Debugger [candidate] (59.62 ms) : 0, 59620
Remote Config [baseline] (588.989 µs) : 0, 589
Remote Config [candidate] (593.403 µs) : 0, 593
Telemetry [baseline] (7.998 ms) : 0, 7998
Telemetry [candidate] (8.124 ms) : 0, 8124
Flare Poller [baseline] (6.648 ms) : 0, 6648
Flare Poller [candidate] (7.516 ms) : 0, 7516
section iast
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (802.441 ms) : 0, 802441
BytebuddyAgent [candidate] (807.462 ms) : 0, 807462
AgentMeter [baseline] (11.33 ms) : 0, 11330
AgentMeter [candidate] (11.65 ms) : 0, 11650
GlobalTracer [baseline] (239.562 ms) : 0, 239562
GlobalTracer [candidate] (240.578 ms) : 0, 240578
IAST [baseline] (25.939 ms) : 0, 25939
IAST [candidate] (27.541 ms) : 0, 27541
AppSec [baseline] (32.2 ms) : 0, 32200
AppSec [candidate] (31.38 ms) : 0, 31380
Debugger [baseline] (58.591 ms) : 0, 58591
Debugger [candidate] (60.146 ms) : 0, 60146
Remote Config [baseline] (538.979 µs) : 0, 539
Remote Config [candidate] (547.543 µs) : 0, 548
Telemetry [baseline] (13.041 ms) : 0, 13041
Telemetry [candidate] (11.728 ms) : 0, 11728
Flare Poller [baseline] (3.444 ms) : 0, 3444
Flare Poller [candidate] (3.478 ms) : 0, 3478
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (17.993 ms) : 17811, 18176
. : milestone, 17993,
appsec (19.915 ms) : 19711, 20118
. : milestone, 19915,
code_origins (17.952 ms) : 17773, 18131
. : milestone, 17952,
iast (19.077 ms) : 18886, 19267
. : milestone, 19077,
profiling (18.241 ms) : 18057, 18426
. : milestone, 18241,
tracing (17.922 ms) : 17746, 18098
. : milestone, 17922,
section candidate
no_agent (19.324 ms) : 19131, 19517
. : milestone, 19324,
appsec (18.62 ms) : 18437, 18803
. : milestone, 18620,
code_origins (17.69 ms) : 17518, 17863
. : milestone, 17690,
iast (19.583 ms) : 19381, 19786
. : milestone, 19583,
profiling (18.115 ms) : 17936, 18294
. : milestone, 18115,
tracing (18.532 ms) : 18347, 18716
. : milestone, 18532,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.242 ms) : 1230, 1254
. : milestone, 1242,
iast (3.38 ms) : 3334, 3425
. : milestone, 3380,
iast_FULL (5.951 ms) : 5891, 6011
. : milestone, 5951,
iast_GLOBAL (3.655 ms) : 3590, 3719
. : milestone, 3655,
profiling (2.226 ms) : 2204, 2248
. : milestone, 2226,
tracing (1.934 ms) : 1918, 1951
. : milestone, 1934,
section candidate
no_agent (1.254 ms) : 1242, 1267
. : milestone, 1254,
iast (3.471 ms) : 3421, 3521
. : milestone, 3471,
iast_FULL (6.441 ms) : 6374, 6509
. : milestone, 6441,
iast_GLOBAL (3.727 ms) : 3665, 3789
. : milestone, 3727,
profiling (2.003 ms) : 1987, 2020
. : milestone, 2003,
tracing (1.94 ms) : 1924, 1957
. : milestone, 1940,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.818 ms) : 3596, 4041
. : milestone, 3818,
iast (2.271 ms) : 2201, 2340
. : milestone, 2271,
iast_GLOBAL (2.319 ms) : 2248, 2389
. : milestone, 2319,
profiling (2.522 ms) : 2357, 2688
. : milestone, 2522,
tracing (2.09 ms) : 2036, 2144
. : milestone, 2090,
section candidate
no_agent (1.488 ms) : 1476, 1500
. : milestone, 1488,
appsec (3.818 ms) : 3594, 4042
. : milestone, 3818,
iast (2.274 ms) : 2205, 2343
. : milestone, 2274,
iast_GLOBAL (2.31 ms) : 2241, 2380
. : milestone, 2310,
profiling (2.529 ms) : 2363, 2695
. : milestone, 2529,
tracing (2.095 ms) : 2041, 2149
. : milestone, 2095,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~16eb29281d, baseline=1.62.0-SNAPSHOT~42f154d2f6
dateFormat X
axisFormat %s
section baseline
no_agent (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
appsec (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
iast (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
iast_GLOBAL (18.175 s) : 18175000, 18175000
. : milestone, 18175000,
profiling (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
section candidate
no_agent (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
appsec (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (18.226 s) : 18226000, 18226000
. : milestone, 18226000,
profiling (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
tracing (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
|
we save the original instance before replaced by mock to restore it Some tests rely on having. the original, and depending on the order the class my keep the mocks instead resulting in errors
fcfc49d to
9bce9c0
Compare
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left minor comments about style
c7d72c1 to
ad5d7c7
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
What Does This Do
we migrate 3 tests:
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
Additional Notes
fix some still existing groovy tests regarding ServieNameCollector singleton. see commit
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.