Restore original tracer during LambdaAppSecHandlerTest cleanup#11172
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058552
Total [baseline] (11.035 s) : 0, 11034677
Agent [candidate] (1.059 s) : 0, 1058718
Total [candidate] (11.117 s) : 0, 11117160
section appsec
Agent [baseline] (1.261 s) : 0, 1261462
Total [baseline] (11.032 s) : 0, 11031543
Agent [candidate] (1.272 s) : 0, 1271669
Total [candidate] (11.128 s) : 0, 11127605
section iast
Agent [baseline] (1.231 s) : 0, 1230593
Total [baseline] (11.324 s) : 0, 11323804
Agent [candidate] (1.239 s) : 0, 1239005
Total [candidate] (11.353 s) : 0, 11353383
section profiling
Agent [baseline] (1.187 s) : 0, 1187324
Total [baseline] (11.054 s) : 0, 11053821
Agent [candidate] (1.198 s) : 0, 1197896
Total [candidate] (11.064 s) : 0, 11063554
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (632.34 ms) : 0, 632340
BytebuddyAgent [candidate] (633.08 ms) : 0, 633080
AgentMeter [baseline] (29.587 ms) : 0, 29587
AgentMeter [candidate] (29.641 ms) : 0, 29641
GlobalTracer [baseline] (248.97 ms) : 0, 248970
GlobalTracer [candidate] (249.48 ms) : 0, 249480
AppSec [baseline] (32.418 ms) : 0, 32418
AppSec [candidate] (32.342 ms) : 0, 32342
Debugger [baseline] (59.937 ms) : 0, 59937
Debugger [candidate] (59.634 ms) : 0, 59634
Remote Config [baseline] (612.639 µs) : 0, 613
Remote Config [candidate] (604.913 µs) : 0, 605
Telemetry [baseline] (9.58 ms) : 0, 9580
Telemetry [candidate] (8.762 ms) : 0, 8762
Flare Poller [baseline] (7.568 ms) : 0, 7568
Flare Poller [candidate] (7.555 ms) : 0, 7555
section appsec
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (673.97 ms) : 0, 673970
BytebuddyAgent [candidate] (680.318 ms) : 0, 680318
AgentMeter [baseline] (12.101 ms) : 0, 12101
AgentMeter [candidate] (12.263 ms) : 0, 12263
GlobalTracer [baseline] (249.338 ms) : 0, 249338
GlobalTracer [candidate] (250.565 ms) : 0, 250565
AppSec [baseline] (188.366 ms) : 0, 188366
AppSec [candidate] (187.778 ms) : 0, 187778
Debugger [baseline] (63.92 ms) : 0, 63920
Debugger [candidate] (66.283 ms) : 0, 66283
Remote Config [baseline] (578.068 µs) : 0, 578
Remote Config [candidate] (579.843 µs) : 0, 580
Telemetry [baseline] (7.828 ms) : 0, 7828
Telemetry [candidate] (7.95 ms) : 0, 7950
Flare Poller [baseline] (3.418 ms) : 0, 3418
Flare Poller [candidate] (3.55 ms) : 0, 3550
IAST [baseline] (24.277 ms) : 0, 24277
IAST [candidate] (24.519 ms) : 0, 24519
section iast
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (807.543 ms) : 0, 807543
BytebuddyAgent [candidate] (815.95 ms) : 0, 815950
AgentMeter [baseline] (11.408 ms) : 0, 11408
AgentMeter [candidate] (11.476 ms) : 0, 11476
GlobalTracer [baseline] (239.096 ms) : 0, 239096
GlobalTracer [candidate] (239.53 ms) : 0, 239530
AppSec [baseline] (29.49 ms) : 0, 29490
AppSec [candidate] (27.518 ms) : 0, 27518
Debugger [baseline] (65.756 ms) : 0, 65756
Debugger [candidate] (63.022 ms) : 0, 63022
Remote Config [baseline] (543.847 µs) : 0, 544
Remote Config [candidate] (527.843 µs) : 0, 528
Telemetry [baseline] (7.785 ms) : 0, 7785
Telemetry [candidate] (7.749 ms) : 0, 7749
Flare Poller [baseline] (3.383 ms) : 0, 3383
Flare Poller [candidate] (3.415 ms) : 0, 3415
IAST [baseline] (28.275 ms) : 0, 28275
IAST [candidate] (32.311 ms) : 0, 32311
section profiling
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (692.853 ms) : 0, 692853
BytebuddyAgent [candidate] (700.242 ms) : 0, 700242
AgentMeter [baseline] (9.174 ms) : 0, 9174
AgentMeter [candidate] (9.359 ms) : 0, 9359
GlobalTracer [baseline] (207.476 ms) : 0, 207476
GlobalTracer [candidate] (209.517 ms) : 0, 209517
AppSec [baseline] (32.914 ms) : 0, 32914
AppSec [candidate] (33.287 ms) : 0, 33287
Debugger [baseline] (65.286 ms) : 0, 65286
Debugger [candidate] (66.051 ms) : 0, 66051
Remote Config [baseline] (612.57 µs) : 0, 613
Remote Config [candidate] (576.235 µs) : 0, 576
Telemetry [baseline] (8.589 ms) : 0, 8589
Telemetry [candidate] (7.8 ms) : 0, 7800
Flare Poller [baseline] (3.537 ms) : 0, 3537
Flare Poller [candidate] (3.533 ms) : 0, 3533
ProfilingAgent [baseline] (94.229 ms) : 0, 94229
ProfilingAgent [candidate] (94.493 ms) : 0, 94493
Profiling [baseline] (94.799 ms) : 0, 94799
Profiling [candidate] (95.055 ms) : 0, 95055
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064872
Total [baseline] (8.896 s) : 0, 8896149
Agent [candidate] (1.06 s) : 0, 1060059
Total [candidate] (8.841 s) : 0, 8841128
section iast
Agent [baseline] (1.233 s) : 0, 1232691
Total [baseline] (9.564 s) : 0, 9563540
Agent [candidate] (1.231 s) : 0, 1230868
Total [candidate] (9.567 s) : 0, 9567283
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (637.418 ms) : 0, 637418
BytebuddyAgent [candidate] (633.912 ms) : 0, 633912
AgentMeter [baseline] (29.779 ms) : 0, 29779
AgentMeter [candidate] (29.571 ms) : 0, 29571
GlobalTracer [baseline] (250.659 ms) : 0, 250659
GlobalTracer [candidate] (249.796 ms) : 0, 249796
AppSec [baseline] (32.662 ms) : 0, 32662
AppSec [candidate] (32.416 ms) : 0, 32416
Debugger [baseline] (59.623 ms) : 0, 59623
Debugger [candidate] (59.202 ms) : 0, 59202
Remote Config [baseline] (604.247 µs) : 0, 604
Remote Config [candidate] (585.466 µs) : 0, 585
Telemetry [baseline] (8.913 ms) : 0, 8913
Telemetry [candidate] (8.062 ms) : 0, 8062
Flare Poller [baseline] (7.504 ms) : 0, 7504
Flare Poller [candidate] (9.108 ms) : 0, 9108
section iast
crashtracking [baseline] (1.257 ms) : 0, 1257
crashtracking [candidate] (1.247 ms) : 0, 1247
BytebuddyAgent [baseline] (808.237 ms) : 0, 808237
BytebuddyAgent [candidate] (809.748 ms) : 0, 809748
AgentMeter [baseline] (11.399 ms) : 0, 11399
AgentMeter [candidate] (11.438 ms) : 0, 11438
GlobalTracer [baseline] (240.207 ms) : 0, 240207
GlobalTracer [candidate] (238.725 ms) : 0, 238725
AppSec [baseline] (30.545 ms) : 0, 30545
AppSec [candidate] (26.501 ms) : 0, 26501
Debugger [baseline] (65.275 ms) : 0, 65275
Debugger [candidate] (63.93 ms) : 0, 63930
Remote Config [baseline] (545.689 µs) : 0, 546
Remote Config [candidate] (525.317 µs) : 0, 525
Telemetry [baseline] (7.87 ms) : 0, 7870
Telemetry [candidate] (7.727 ms) : 0, 7727
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.39 ms) : 0, 3390
IAST [baseline] (27.684 ms) : 0, 27684
IAST [candidate] (31.56 ms) : 0, 31560
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section baseline
no_agent (17.324 ms) : 17152, 17496
. : milestone, 17324,
appsec (18.996 ms) : 18804, 19188
. : milestone, 18996,
code_origins (17.719 ms) : 17544, 17894
. : milestone, 17719,
iast (19.162 ms) : 18971, 19354
. : milestone, 19162,
profiling (18.489 ms) : 18307, 18671
. : milestone, 18489,
tracing (18.718 ms) : 18531, 18906
. : milestone, 18718,
section candidate
no_agent (18.378 ms) : 18188, 18569
. : milestone, 18378,
appsec (18.819 ms) : 18632, 19005
. : milestone, 18819,
code_origins (18.046 ms) : 17865, 18227
. : milestone, 18046,
iast (18.092 ms) : 17915, 18269
. : milestone, 18092,
profiling (18.556 ms) : 18372, 18741
. : milestone, 18556,
tracing (17.975 ms) : 17799, 18151
. : milestone, 17975,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section baseline
no_agent (1.228 ms) : 1216, 1240
. : milestone, 1228,
iast (3.344 ms) : 3296, 3391
. : milestone, 3344,
iast_FULL (6.09 ms) : 6027, 6152
. : milestone, 6090,
iast_GLOBAL (3.705 ms) : 3643, 3768
. : milestone, 3705,
profiling (2.432 ms) : 2408, 2456
. : milestone, 2432,
tracing (1.988 ms) : 1971, 2005
. : milestone, 1988,
section candidate
no_agent (1.253 ms) : 1241, 1265
. : milestone, 1253,
iast (3.495 ms) : 3444, 3547
. : milestone, 3495,
iast_FULL (6.23 ms) : 6166, 6294
. : milestone, 6230,
iast_GLOBAL (3.748 ms) : 3684, 3812
. : milestone, 3748,
profiling (2.391 ms) : 2365, 2416
. : milestone, 2391,
tracing (1.869 ms) : 1853, 1884
. : milestone, 1869,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section baseline
no_agent (1.5 ms) : 1488, 1511
. : milestone, 1500,
appsec (3.864 ms) : 3640, 4089
. : milestone, 3864,
iast (2.296 ms) : 2226, 2366
. : milestone, 2296,
iast_GLOBAL (2.33 ms) : 2259, 2400
. : milestone, 2330,
profiling (2.107 ms) : 2052, 2162
. : milestone, 2107,
tracing (2.095 ms) : 2041, 2149
. : milestone, 2095,
section candidate
no_agent (1.497 ms) : 1485, 1509
. : milestone, 1497,
appsec (3.871 ms) : 3646, 4095
. : milestone, 3871,
iast (2.291 ms) : 2222, 2361
. : milestone, 2291,
iast_GLOBAL (2.337 ms) : 2267, 2408
. : milestone, 2337,
profiling (2.108 ms) : 2053, 2163
. : milestone, 2108,
tracing (2.101 ms) : 2047, 2155
. : milestone, 2101,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~8f0121148b, baseline=1.62.0-SNAPSHOT~b0889567dc
dateFormat X
axisFormat %s
section baseline
no_agent (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
appsec (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
. : milestone, 18044000,
profiling (15.398 s) : 15398000, 15398000
. : milestone, 15398000,
tracing (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
section candidate
no_agent (15.422 s) : 15422000, 15422000
. : milestone, 15422000,
appsec (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
iast (18.492 s) : 18492000, 18492000
. : milestone, 18492000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
. : milestone, 18020000,
profiling (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
tracing (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Restore original tracer during the cleanup after LambdaAppSecHandlerTest
Motivation
forceRegister(null) in LambdaAppSecHandlerTest cleanup was causing NPE in LambdaHandlerTest when the AppSec test was ran before the LambdaHandlerTest.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.