Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed46fe30a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ECHO_ARG="-e" | ||
| CFLAGS="-std=gnu11 -O2 -g -Wall -Wextra" | ||
| export CFLAGS="-std=gnu11 -O2 -g -Wall -Wextra -flto=auto -ffat-lto-objects" |
There was a problem hiding this comment.
The Linux GNU packaging jobs use the CentOS 7 images configured in .gitlab/generate-package.php, and this script explicitly activates devtoolset-7 before exporting these flags. GCC 7 supports -flto, an integer job count, or jobserver, but not -flto=auto (GCC 7.5 LTO documentation); because the exported value is inherited by configure and the extension build, every CentOS artifact job will stop with an unsupported -flto= argument before producing packages. Use plain -flto, a numeric value, or a compiler-supported conditional.
Useful? React with 👍 / 👎.
1 participant
Aside from being a lto build, in particular this serves as regression that it doesn't break the distro build of ddtrace anymore.