-
Notifications
You must be signed in to change notification settings - Fork 470
ci: suitespec riot venvs_per_job for gen_gitlab_config #15367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 256 ± 4 ms. The import time difference between this PR and base is: -5.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/venvs_per_job (3f9981d) with baseline main (a82e9b1) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.059µs (SLO: <10.000µs 📉 -49.4%) vs baseline: 📈 +17.6% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.3% ✅ ospathbasename_noaspectTime: ✅ 1.070µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -1.4% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.3% ✅ ospathjoin_aspectTime: ✅ 6.075µs (SLO: <10.000µs 📉 -39.2%) vs baseline: -1.3% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.300µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.3% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.534µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +1.0% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.7% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.908µs (SLO: <10.000µs 📉 -50.9%) vs baseline: +0.4% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.583µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.6% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.653µs (SLO: <10.000µs 📉 -63.5%) vs baseline: -1.4% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.4% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ ospathsplitext_aspectTime: ✅ 4.596µs (SLO: <10.000µs 📉 -54.0%) vs baseline: +0.6% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.376µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.5% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.463µs (SLO: <20.000µs 📉 -82.7%) vs baseline: 📈 +15.6% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.3% ✅ 1-count-metrics-100-timesTime: ✅ 200.624µs (SLO: <220.000µs -8.8%) vs baseline: +0.1% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ 1-distribution-metric-1-timesTime: ✅ 3.320µs (SLO: <20.000µs 📉 -83.4%) vs baseline: -0.3% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.893µs (SLO: <230.000µs -7.0%) vs baseline: -0.4% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.259µs (SLO: <20.000µs 📉 -88.7%) vs baseline: ~same Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.306µs (SLO: <150.000µs -8.5%) vs baseline: -0.4% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.138µs (SLO: <20.000µs 📉 -84.3%) vs baseline: -0.3% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.664µs (SLO: <250.000µs 📉 -13.7%) vs baseline: +0.2% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.502ms (SLO: <22.000ms -6.8%) vs baseline: +1.1% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.300ms -2.2%) vs baseline: ~same Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.425ms (SLO: <1.550ms -8.1%) vs baseline: +0.4% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.222ms (SLO: <2.550ms 📉 -12.9%) vs baseline: +1.2% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.485µs (SLO: <20.000µs 📉 -77.6%) vs baseline: -0.2% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 172.741µs (SLO: <250.000µs 📉 -30.9%) vs baseline: +0.1% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.193ms (SLO: <2.500ms 📉 -12.3%) vs baseline: +0.2% Memory: ✅ 36.156MB (SLO: <36.500MB 🟡 -0.9%) vs baseline: +4.7% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Adds a new
venvs_per_joboption to suitespec so we can dynamically determine how many parallel GitLab jobs to create based on the number of riot venvs that exist instead of being a set static number.This should help when we scale the testing matrix at any point, and make it more predictable for total job runtime (e.g. 60 seconds per venv, if we run 3 venvs per job, then each job should be only 3 minutes long).
Testing
Risks
Additional Notes