Fix memory leak in JfrMetadata::reset() by jbachorik · Pull Request #694 · DataDog/java-profiler

jbachorik · 2026-07-28T11:41:00Z

What does this PR do?:
JfrMetadata::reset() cleared _root._children/_root._attributes without deleting the heap-allocated Element/NoField objects initialize() had allocated, leaking them and leaving the tree vulnerable to use-after-free if the allocator later reused a freed address. Adds recursive deletion of the Element tree and the tracked _nofields list before clearing.

Motivation:
Only reachable via a profiler restart (reset() followed by initialize() a second time in the same process). Found while investigating PROF-15075 (SIGSEGV in Recording::writeElement) but not its cause — that crash trace shows a plain chunk dump with no restart involved. Closing this separately since it's a real leak/UAF risk on its own.

How to test the change?:

ddprof-lib/src/test/cpp/jfrMetadata_ut.cpp exercises initialize()/reset() cycles, including with context attributes, and asserts no leaked/dangling Elements.

For Datadog employees:

If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a security review (run the dd:platform-security-review
skill, or file a request via the PSEC review form).
bewaire also runs automatically on every PR.
This PR doesn't touch any of that.
JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

reset() cleared _root._children/_attributes without deleting the heap-allocated Element/NoField objects initialize() had allocated. Only reachable via a Profiler restart (reset() -> initialize() a second time in the same process); unrelated to PROF-15075, which crashes on a plain chunk dump with no restart involved (split out of #692 per https://datadoghq.atlassian.net/browse/PROF-15075).

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

dd-octo-sts · 2026-07-28T12:14:19Z

CI Test Results

Run: #30900616939 | Commit: 31724fa | Duration: 13m 49s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK	glibc-aarch64/debug	glibc-amd64/debug	musl-aarch64/debug	musl-amd64/debug
8	-	✅	-	-
8-ibm	-	✅	-	-
8-j9	✅	✅	-	-
8-librca	-	-	✅	✅
8-orcl	-	✅	-	-
11	-	✅	-	-
11-j9	✅	✅	-	-
11-librca	-	-	✅	✅
17	✅	✅	-	-
17-graal	✅	✅	-	-
17-j9	✅	✅	-	-
17-librca	-	-	✅	✅
21	✅	✅	-	-
21-graal	✅	✅	-	-
21-librca	-	-	✅	✅
25	✅	✅	-	-
25-graal	✅	✅	-	-
25-librca	-	-	✅	✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0

Updated: 2026-08-04 10:42:49 UTC

dd-octo-sts · 2026-07-28T12:49:04Z

Benchmark Results (commit `008d688`)

Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/127401287 Commit: 008d6889e4f9acc4be699bb2ac845f3396e20528

⚠️ Significant outliers

🟢 fj-kmeans (JDK 21): runtime -3.9% (2745→2638 ms)
🟢 future-genetic (JDK 21): runtime -3% (2122→2058 ms)

Runtime details (per benchmark × JDK)

Benchmark	JDK	Latest	Dev	Δ (dev vs latest)	Issues L/D
akka-uct	21	✅ 10193 ms (21 iters)	✅ 10416 ms (21 iters)	≈ +2.2% (±11.2%)	— / —
akka-uct	25	✅ 8880 ms (24 iters)	✅ 8743 ms (24 iters)	≈ -1.5% (±10%)	— / —
finagle-chirper	21	✅ 6002 ms (33 iters)	✅ 5929 ms (33 iters)	≈ -1.2% (±24.7%)	⚠️ W:3 / ⚠️ W:3
finagle-chirper	25	✅ 5437 ms (36 iters)	✅ 5445 ms (36 iters)	≈ +0.1% (±24.3%)	⚠️ W:3 / ⚠️ W:3
fj-kmeans	21	✅ 2745 ms (68 iters)	✅ 2638 ms (72 iters)	🟢 -3.9%	— / —
fj-kmeans	25	✅ 2832 ms (66 iters)	✅ 2832 ms (66 iters)	≈ 0% (±2.6%)	— / —
future-genetic	21	✅ 2122 ms (87 iters)	✅ 2058 ms (90 iters)	🟢 -3%	— / —
future-genetic	25	✅ 2059 ms (90 iters)	✅ 2049 ms (90 iters)	≈ -0.5% (±2.6%)	— / —
naive-bayes	21	✅ 1257 ms (136 iters)	✅ 1304 ms (132 iters)	≈ +3.7% (±33.1%)	— / —
naive-bayes	25	✅ 1028 ms (167 iters)	✅ 1014 ms (169 iters)	≈ -1.4% (±31.8%)	— / —
reactors	21	✅ 16668 ms (15 iters)	✅ 15846 ms (15 iters)	≈ -4.9% (±7.4%)	— / —
reactors	25	✅ 18281 ms (15 iters)	✅ 18391 ms (15 iters)	≈ +0.6% (±5%)	— / —

Internal counter details (ddprof)

ddprof internal counters, latest / dev (✅ = 0, · = unavailable):

Benchmark	JDK	Dropped rec	Dropped jvmti	Dropped trace	Skipped WC	AGCT fail	Unwind fail
akka-uct	21	✅ / ✅	✅ / ✅	4 / 2	1961 / 1939	✅ / ✅	✅ / ✅
akka-uct	25	✅ / ✅	✅ / ✅	6 / 1	2369 / 2031	✅ / ✅	✅ / ✅
finagle-chirper	21	✅ / ✅	✅ / ✅	4 / 1	8227 / 8628	✅ / ✅	✅ / ✅
finagle-chirper	25	✅ / ✅	✅ / ✅	✅ / ✅	8367 / 8248	✅ / ✅	✅ / ✅
fj-kmeans	21	✅ / ✅	✅ / ✅	2 / 1	1267 / 1276	✅ / ✅	✅ / ✅
fj-kmeans	25	✅ / ✅	✅ / ✅	✅ / ✅	1287 / 1259	✅ / ✅	✅ / ✅
future-genetic	21	✅ / ✅	✅ / ✅	2 / 1	2932 / 3002	✅ / ✅	✅ / ✅
future-genetic	25	✅ / ✅	✅ / ✅	2 / 2	2843 / 2845	✅ / ✅	✅ / ✅
naive-bayes	21	✅ / ✅	✅ / ✅	2 / 4	3484 / 3550	✅ / ✅	✅ / ✅
naive-bayes	25	✅ / ✅	✅ / ✅	2 / 4	3492 / 3488	✅ / ✅	✅ / ✅
reactors	21	✅ / ✅	✅ / ✅	1 / 2	1638 / 1621	✅ / ✅	✅ / ✅
reactors	25	✅ / ✅	✅ / ✅	1 / 1	1843 / 1824	✅ / ✅	✅ / ✅

jbachorik · 2026-08-04T10:26:01Z

@codex review

dd-octo-sts · 2026-08-04T10:29:04Z

Scan-Build Report

User:	runner@runnervmvrwv9
Working Directory:	/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:	make -j4 all
Clang Version:	Ubuntu clang version 18.1.3 (1ubuntu1)
Date:	Tue Aug 4 10:27:49 2026

Bug Summary

Logic error
Bug Type	Quantity	Display?
All Bugs	1
Dereference of null pointer	1

Reports

Bug Group	Bug Type ▾	File	Function/Method	Line	Path Length
Logic error	Dereference of null pointer	profiler.h	findLibraryByAddress	517	13

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64c7b4423d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dd-octo-sts · 2026-08-04T10:57:44Z

Benchmark Results (commit `64c7b44`)

Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128804523 Commit: 64c7b4423d39dedb72601809089f923c0f484e62

⚠️ Significant outliers

🔴 future-genetic (JDK 21): runtime +2.6% (2037→2090 ms)

Runtime details (per benchmark × JDK)

Benchmark	JDK	Latest	Dev	Δ (dev vs latest)	Issues L/D
akka-uct	21	✅ 10336 ms (21 iters)	✅ 10225 ms (21 iters)	≈ -1.1% (±11.2%)	— / —
akka-uct	25	✅ 8844 ms (24 iters)	✅ 8823 ms (24 iters)	≈ -0.2% (±9.5%)	— / —
finagle-chirper	21	✅ 5987 ms (33 iters)	✅ 5912 ms (33 iters)	≈ -1.3% (±25.2%)	⚠️ W:3 / ⚠️ W:3
finagle-chirper	25	✅ 5454 ms (36 iters)	✅ 5458 ms (36 iters)	≈ +0.1% (±24.1%)	⚠️ W:3 / ⚠️ W:3
fj-kmeans	21	✅ 2712 ms (68 iters)	✅ 2695 ms (70 iters)	≈ -0.6% (±2.8%)	— / —
fj-kmeans	25	✅ 2828 ms (66 iters)	✅ 2822 ms (66 iters)	≈ -0.2% (±2.6%)	— / —
future-genetic	21	✅ 2037 ms (91 iters)	✅ 2090 ms (89 iters)	🔴 +2.6%	— / —
future-genetic	25	✅ 2038 ms (91 iters)	✅ 2027 ms (92 iters)	≈ -0.5% (±2.6%)	— / —
naive-bayes	21	✅ 1264 ms (135 iters)	✅ 1273 ms (134 iters)	≈ +0.7% (±32.6%)	— / —
naive-bayes	25	✅ 975 ms (175 iters)	✅ 984 ms (173 iters)	≈ +0.9% (±31.8%)	— / —
reactors	21	✅ 16879 ms (15 iters)	✅ 16257 ms (15 iters)	≈ -3.7% (±6.4%)	— / —
reactors	25	✅ 18594 ms (15 iters)	✅ 18489 ms (15 iters)	≈ -0.6% (±5.2%)	— / —

Internal counter details (ddprof)

ddprof internal counters, latest / dev (✅ = 0, · = unavailable):

Benchmark	JDK	Dropped rec	Dropped jvmti	Dropped trace	Skipped WC	AGCT fail	Unwind fail
akka-uct	21	✅ / ✅	✅ / ✅	5 / ✅	1958 / 2013	✅ / ✅	✅ / ✅
akka-uct	25	✅ / ✅	✅ / ✅	1 / 2	2362 / 2213	✅ / ✅	✅ / ✅
finagle-chirper	21	✅ / ✅	✅ / ✅	1 / 4	8457 / 8027	✅ / ✅	✅ / ✅
finagle-chirper	25	✅ / ✅	✅ / ✅	2 / ✅	8212 / 8454	✅ / ✅	✅ / ✅
fj-kmeans	21	✅ / ✅	✅ / ✅	✅ / ✅	✅ / ✅	✅ / ✅	✅ / ✅
fj-kmeans	25	✅ / ✅	✅ / ✅	3 / 2	1255 / 1238	✅ / ✅	✅ / ✅
future-genetic	21	✅ / ✅	✅ / ✅	2 / ✅	3008 / 2999	✅ / ✅	✅ / ✅
future-genetic	25	✅ / ✅	✅ / ✅	6 / 3	2856 / 2871	✅ / ✅	✅ / ✅
naive-bayes	21	✅ / ✅	✅ / ✅	8 / 7	3501 / 3494	✅ / ✅	✅ / ✅
naive-bayes	25	✅ / ✅	✅ / ✅	3 / 6	3478 / 3462	✅ / ✅	✅ / ✅
reactors	21	✅ / ✅	✅ / ✅	✅ / ✅	1843 / 1642	✅ / ✅	✅ / ✅
reactors	25	✅ / ✅	✅ / ✅	1 / ✅	1897 / 1838	✅ / ✅	✅ / ✅

Copilot AI review requested due to automatic review settings July 28, 2026 11:41

Copilot AI reviewed Jul 28, 2026

jbachorik added the AI label Jul 28, 2026

jbachorik mentioned this pull request Jul 28, 2026

Guard Recording::writeElement against SIGSEGV on a corrupted metadata tree #692

Open

3 tasks

jbachorik changed the title ~~Fix memory leak in JfrMetadata::reset() (split from PROF-15075)~~ Fix memory leak in JfrMetadata::reset() Jul 28, 2026

Merge branch 'main' into fix/jfrmetadata-reset-leak

64c7b44

Copilot AI review requested due to automatic review settings August 4, 2026 10:25

Copilot started reviewing on behalf of jbachorik August 4, 2026 10:26 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread ddprof-lib/src/test/cpp/jfrMetadata_ut.cpp

Comment thread ddprof-lib/src/test/cpp/jfrMetadata_ut.cpp

jbachorik marked this pull request as ready for review August 4, 2026 11:15

jbachorik requested a review from a team as a code owner August 4, 2026 11:15

Navigation Menu

Uh oh!

Fix memory leak in JfrMetadata::reset() - #694

Fix memory leak in JfrMetadata::reset()#694
jbachorik wants to merge 2 commits into
mainfrom
fix/jfrmetadata-reset-leak

jbachorik commented Jul 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

dd-octo-sts Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Jul 28, 2026

Uh oh!

jbachorik commented Aug 4, 2026

Uh oh!

dd-octo-sts Bot commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jbachorik commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Test Results

Status Overview

Uh oh!

dd-octo-sts Bot commented Jul 28, 2026

Benchmark Results (commit 008d688)

⚠️ Significant outliers

Uh oh!

jbachorik commented Aug 4, 2026

Uh oh!

dd-octo-sts Bot commented Aug 4, 2026

Scan-Build Report

Bug Summary

Reports

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Aug 4, 2026

Benchmark Results (commit 64c7b44)

⚠️ Significant outliers

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jbachorik commented Jul 28, 2026 •

edited

Loading

dd-octo-sts Bot commented Jul 28, 2026 •

edited

Loading

Benchmark Results (commit `008d688`)

Benchmark Results (commit `64c7b44`)