fix: restore trivial approval action pins - #710
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99af0139bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Check for an existing exact approval | ||
| id: existing | ||
| uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b # 9.0.0 | ||
| uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # 9.0.0 |
There was a problem hiding this comment.
Because this change modifies the workflow while the file still contains no Datadog copyright notice, it violates the repository requirement to add one to any modified file that lacks it; add a Copyright 2026, Datadog, Inc. comment header.
AGENTS.md reference: AGENTS.md:L372-L374
Useful? React with 👍 / 👎.
| fail "approval workflow does not conditionally validate release bumps" | ||
| [[ "$APPROVAL_WORKFLOW" == *"commit_id: process.env.EXPECTED_HEAD_SHA"* ]] || | ||
| fail "approval is not pinned to the validated SHA" | ||
| while IFS= read -r action_ref; do |
There was a problem hiding this comment.
Because this change modifies the test script while the file still contains no Datadog copyright notice, it violates the repository requirement to add one to any modified file that lacks it; add a Copyright 2026, Datadog, Inc. comment after the shebang.
AGENTS.md reference: AGENTS.md:L372-L374
Useful? React with 👍 / 👎.
CI Test ResultsRun: #34239424130 | Commit:
Summary: Total: 0 | Passed: 0 | Failed: 0 Updated: 2026-09-08 16:28:23 UTC |
Benchmark Results (commit 99af013)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128555991 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10297 ms (21 iters) | ✅ 10417 ms (21 iters) | ≈ +1.2% (±11.4%) | — / — |
| akka-uct | 25 | ✅ 8882 ms (24 iters) | ✅ 8823 ms (24 iters) | ≈ -0.7% (±9.8%) | — / — |
| finagle-chirper | 21 | ✅ 6017 ms (33 iters) | ✅ 6039 ms (33 iters) | ≈ +0.4% (±24.9%) | |
| finagle-chirper | 25 | ✅ 5428 ms (36 iters) | ✅ 5409 ms (36 iters) | ≈ -0.4% (±24.4%) | |
| fj-kmeans | 21 | ✅ 2728 ms (68 iters) | ✅ 2650 ms (70 iters) | 🟢 -2.9% | — / — |
| fj-kmeans | 25 | ✅ 2824 ms (66 iters) | ✅ 2810 ms (67 iters) | ≈ -0.5% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2034 ms (91 iters) | ✅ 2055 ms (90 iters) | ≈ +1% (±2.5%) | — / — |
| future-genetic | 25 | ✅ 2074 ms (90 iters) | ✅ 2083 ms (89 iters) | ≈ +0.4% (±2.6%) | — / — |
| naive-bayes | 21 | ✅ 1229 ms (139 iters) | ✅ 1260 ms (135 iters) | ≈ +2.5% (±33.5%) | — / — |
| naive-bayes | 25 | ✅ 1017 ms (168 iters) | ✅ 1011 ms (169 iters) | ≈ -0.6% (±31.7%) | — / — |
| reactors | 21 | ✅ 16143 ms (15 iters) | ✅ 16290 ms (15 iters) | ≈ +0.9% (±7.7%) | — / — |
| reactors | 25 | ✅ 18524 ms (15 iters) | ✅ 18674 ms (15 iters) | ≈ +0.8% (±3.5%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 4 | 1979 / 1922 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 2248 / 2223 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 3 | 8592 / 9142 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 8798 / 8330 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 5 | 1260 / 1247 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 4 | 1292 / 1286 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 2992 / 2939 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 2893 / 2862 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 3496 / 3480 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 3 | 1805 / 1815 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1882 / 1866 | ✅ / ✅ | ✅ / ✅ |
Summary
Why
PR #698 accidentally truncated both actions/github-script pins from 40 to 39 characters. GitHub cannot resolve shortened action SHAs, so the pull_request_target workflow fails during job setup before it can auto-approve any PR, including the release/1.48 backport.
Validation