Add disabled regression test for unprimed native threads - #712
Open
jbachorik wants to merge 3 commits into
Open
Conversation
jbachorik
force-pushed
the
jb/integ_tests_unknown
branch
from
August 3, 2026 15:34
9026837 to
314e3e6
Compare
jbachorik
changed the title
Contributor
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
jbachorik
force-pushed
the
jb/integ_tests_unknown
branch
from
August 3, 2026 15:37
314e3e6 to
778a07d
Compare
jbachorik
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8433098ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ddprof-test/src/test/java/com/datadoghq/profiler/cpu/NativeThreadPrimingTest.java:40
- When this test is eventually re-enabled, it will still be invoked on J9 and Zing unless you add an explicit platform gate. This is risky because the CStackInjector’s
@ValueSourcefiltering falls back to the first declared value when none are “safe” (so J9 would still run with cstack=vm), and Zing forces cstack=no, making the test semantics invalid. Consider overriding isPlatformSupported() now to skip these JVMs so the future re-enable doesn’t introduce CI flakes/hangs.
public NativeThreadPrimingTest(@CStack String cstack) {
super(cstack);
}
@TestTemplate
Contributor
CI Test ResultsRun: #30918733018 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 31 | Failed: 0 | Cancelled: 1 Updated: 2026-08-04 18:22:40 UTC |
Contributor
Benchmark Results (commit b843309)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128634899 Commit: ✅ Within expected boundariesNo significant runtime deltas (all within run-to-run noise) and no internal-counter outliers. Runtime details (per benchmark × JDK)
Internal counter details (ddprof)ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ddprof-test/src/test/java/com/datadoghq/profiler/cpu/NativeThreadPrimingTest.java:62
STACK_TRACE_STRINGaccessors and members can be null in this test suite (see e.g. ClinitResolutionTest / VtableReceiverFrameTest). Here the code assumes both the accessor and the returned stack trace are non-null, which can lead to intermittent NPEs when iterating events.
Consider skipping iterables where the accessor is null, and guarding stackTrace before calling contains() / matches().
IMemberAccessor<String, IItem> frameAccessor =
JdkAttributes.STACK_TRACE_STRING.getAccessor(cpuSamples.getType());
for (IItem sample : cpuSamples) {
totalSamples++;
String stackTrace = frameAccessor.getMember(sample);
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (3)
build-logic/conventions/src/main/kotlin/com/datadoghq/native/tasks/NativeCompileTask.kt:266
architectureArgsis always computed on macOS and then injected into the compiler command line. This uses Apple Clang’s-archflag and will fail for compilers/linkers that don’t support it (e.g., Homebrew GCC likeg++-13, or other non-Clang toolchains selected via-Pnative.forceCompiler). Consider gating the injection based on the selected compiler executable name so macOS builds don’t break when a non-Clang compiler is used.
// Build base compiler arguments with convenience properties
val baseArgs = (architectureArgs + compilerArgs.get()).toMutableList()
build-logic/conventions/src/main/kotlin/com/datadoghq/native/tasks/NativeLinkTask.kt:284
architectureArgsadds Apple Clang’s-archflag unconditionally on macOS. If the linker is not a Clang driver (e.g., Homebrew GCC selected via-Pnative.forceCompiler), the link step will fail with an “unknown option: -arch” style error. Consider only adding these flags when the linker executable is a Clang-like driver (or Apple’sg++wrapper).
val cmdLine = mutableListOf<String>().apply {
add(linker.get())
add(sharedFlag)
addAll(architectureArgs)
addAll(objectPaths)
build-logic/conventions/src/main/kotlin/com/datadoghq/native/tasks/NativeLinkExecutableTask.kt:150
architectureArgsis always appended to the linker command line on macOS. This uses Apple Clang’s-archflag, which can break builds when a non-Clang linker/driver is selected (e.g. Homebrew GCC via-Pnative.forceCompiler). Consider gating the flag injection based on the linker executable name.
val cmdLine = mutableListOf<String>().apply {
add(linker.get())
addAll(architectureArgs)
addAll(objectPaths)
addAll(linkerArgs.get())
Contributor
Benchmark Results (commit a309570)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128812057 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10422 ms (21 iters) | ✅ 10382 ms (21 iters) | ≈ -0.4% (±11.8%) | — / — |
| finagle-chirper | 21 | ✅ 6035 ms (33 iters) | ✅ 5962 ms (33 iters) | ≈ -1.2% (±25.4%) | |
| finagle-chirper | 25 | ✅ 5439 ms (36 iters) | ✅ 5454 ms (36 iters) | ≈ +0.3% (±24.2%) | |
| future-genetic | 25 | ✅ 1990 ms (93 iters) | ✅ 2074 ms (89 iters) | 🔴 +4.2% | — / — |
| naive-bayes | 21 | ✅ 1302 ms (132 iters) | ✅ 1269 ms (135 iters) | ≈ -2.5% (±31.9%) | — / — |
| naive-bayes | 25 | ✅ 1022 ms (168 iters) | ✅ 1004 ms (170 iters) | ≈ -1.8% (±31.3%) | — / — |
| reactors | 21 | ✅ 16294 ms (15 iters) | ✅ 16713 ms (15 iters) | ≈ +2.6% (±7.7%) | — / — |
| reactors | 25 | ✅ 18444 ms (15 iters) | ✅ 18459 ms (15 iters) | ≈ +0.1% (±4.3%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 2024 / 2008 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 8704 / 8205 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 8214 / 8437 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 2917 / 2947 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 6 / 3 | 3507 / 3570 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 5 | 3480 / 3444 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1864 / 1862 | ✅ / ✅ | ✅ / ✅ |
jbachorik
force-pushed
the
jb/integ_tests_unknown
branch
2 times, most recently
from
August 4, 2026 11:44
fd83b39 to
f397c04
Compare
jbachorik
force-pushed
the
jb/integ_tests_unknown
branch
from
August 4, 2026 12:17
f397c04 to
4d79271
Compare
Contributor
Benchmark Results (commit f397c04)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128820925 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10315 ms (21 iters) | ✅ 10231 ms (21 iters) | ≈ -0.8% (±11.1%) | — / — |
| akka-uct | 25 | ✅ 8970 ms (24 iters) | ✅ 8923 ms (24 iters) | ≈ -0.5% (±10.4%) | — / — |
| finagle-chirper | 21 | ✅ 5951 ms (33 iters) | ✅ 6061 ms (32 iters) | ≈ +1.8% (±25.8%) | |
| finagle-chirper | 25 | ✅ 5444 ms (36 iters) | ✅ 5496 ms (36 iters) | ≈ +1% (±24.3%) | |
| fj-kmeans | 21 | ✅ 2733 ms (68 iters) | ✅ 2672 ms (70 iters) | ≈ -2.2% (±2.6%) | — / — |
| fj-kmeans | 25 | ✅ 2818 ms (66 iters) | ✅ 2752 ms (68 iters) | ≈ -2.3% (±2.7%) | — / — |
| future-genetic | 21 | ✅ 2141 ms (87 iters) | ✅ 2132 ms (87 iters) | ≈ -0.4% (±2.6%) | — / — |
| future-genetic | 25 | ✅ 1976 ms (94 iters) | ✅ 2049 ms (91 iters) | 🔴 +3.7% | — / — |
| naive-bayes | 21 | ✅ 1268 ms (135 iters) | ✅ 1241 ms (138 iters) | ≈ -2.1% (±32.3%) | — / — |
| naive-bayes | 25 | ✅ 1014 ms (168 iters) | ✅ 1007 ms (170 iters) | ≈ -0.7% (±32%) | — / — |
| reactors | 21 | ✅ 16741 ms (15 iters) | ✅ 15781 ms (15 iters) | ≈ -5.7% (±7.9%) | — / — |
| reactors | 25 | ✅ 18423 ms (15 iters) | ✅ 18595 ms (15 iters) | ≈ +0.9% (±5.1%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 2010 / 1983 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 3 | 2331 / 2190 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 5 / 2 | 8567 / 8672 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 8253 / 8829 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 1250 / 1249 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 1278 / 1288 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 4 / 1 | 2926 / 3086 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2858 / 2952 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 10 / 2 | 3527 / 3494 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 3422 / 3473 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1706 / 1486 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1907 / 1849 | ✅ / ✅ | ✅ / ✅ |
Contributor
Benchmark Results (commit 4d79271)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128826578 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10371 ms (21 iters) | ✅ 10176 ms (21 iters) | ≈ -1.9% (±11.4%) | — / — |
| akka-uct | 25 | ✅ 8802 ms (24 iters) | ✅ 8900 ms (24 iters) | ≈ +1.1% (±9.8%) | — / — |
| finagle-chirper | 21 | ✅ 5953 ms (33 iters) | ✅ 6005 ms (33 iters) | ≈ +0.9% (±25.1%) | |
| finagle-chirper | 25 | ✅ 5338 ms (36 iters) | ✅ 5413 ms (36 iters) | ≈ +1.4% (±24.4%) | |
| fj-kmeans | 21 | ✅ 2689 ms (70 iters) | ✅ 2612 ms (72 iters) | 🟢 -2.9% | — / — |
| fj-kmeans | 25 | ✅ 2817 ms (66 iters) | ✅ 2813 ms (66 iters) | ≈ -0.1% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2114 ms (87 iters) | ✅ 2091 ms (89 iters) | ≈ -1.1% (±2.6%) | — / — |
| future-genetic | 25 | ✅ 2062 ms (90 iters) | ✅ 2081 ms (89 iters) | ≈ +0.9% (±2.6%) | — / — |
| naive-bayes | 21 | ✅ 1245 ms (137 iters) | ✅ 1277 ms (134 iters) | ≈ +2.6% (±33.2%) | — / — |
| naive-bayes | 25 | ✅ 1009 ms (169 iters) | ✅ 982 ms (173 iters) | ≈ -2.7% (±31.4%) | — / — |
| reactors | 25 | ✅ 18750 ms (14 iters) | ✅ 18645 ms (15 iters) | ≈ -0.6% (±4.3%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 4 | 1942 / 1958 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 1988 / 2386 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 5 / 2 | 8472 / 8325 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 8061 / 8514 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 4 | 1301 / 1280 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 5 | 1289 / 1273 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 2967 / 2966 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 2948 / 2928 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 5 | 3496 / 3488 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 7 | 3447 / 3456 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | · / ✅ | · / ✅ | · / ✅ | · / 1808 | · / ✅ | · / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 1575 / 1882 | ✅ / ✅ | ✅ / ✅ |
Fixes PR review feedback: macosArchitectureArgs() unconditionally added Apple Clang's -arch flag, breaking g++ builds via -Pnative.forceCompiler. Also removes an unused @cstack parameter from a test template method. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ddprof-test/src/test/java/com/datadoghq/profiler/cpu/NativeThreadPrimingTest.java:61
frameAccessor.getMember(sample)may return null; this code unconditionally callscontains()/ regex matching onstackTrace, which can throw an NPE. Other ExecutionSample tests in this repo guard against null stack traces (e.g.,VtableReceiverFrameTest). Add a null check (and optionally skip the sample) before inspecting the string.
totalSamples++;
String stackTrace = frameAccessor.getMember(sample);
if (stackTrace.contains(UNKNOWN_NATIVE_THREAD_FRAME)
|| NO_JAVA_FRAME_ONLY.matcher(stackTrace).matches()) {
syntheticSamples++;
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (1)
build-logic/conventions/src/main/kotlin/com/datadoghq/native/util/PlatformUtils.kt:236
isClangLikeDriver()recompiles theRegex(...)on every call. This method is called from compile/link task argument construction, so repeatedly allocating/compiling the regex is unnecessary work during builds. Hoist the regex into a singleprivate valand reuse it.
private fun isClangLikeDriver(driver: String): Boolean {
val name = File(driver).name
return !Regex("""^(gcc|g\+\+)(-\d+(\.\d+)*)?$""").matches(name)
}
Contributor
Benchmark Results (commit c583077)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128857753 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10289 ms (21 iters) | ✅ 10274 ms (21 iters) | ≈ -0.1% (±11.4%) | — / — |
| akka-uct | 25 | ✅ 8911 ms (24 iters) | ✅ 8841 ms (24 iters) | ≈ -0.8% (±9.6%) | — / — |
| finagle-chirper | 21 | ✅ 5972 ms (33 iters) | ✅ 5957 ms (33 iters) | ≈ -0.3% (±24.7%) | |
| finagle-chirper | 25 | ✅ 5425 ms (36 iters) | ✅ 5456 ms (36 iters) | ≈ +0.6% (±24.7%) | |
| fj-kmeans | 21 | ✅ 2707 ms (70 iters) | ✅ 2726 ms (68 iters) | ≈ +0.7% (±2.7%) | — / — |
| fj-kmeans | 25 | ✅ 2807 ms (66 iters) | ✅ 2797 ms (67 iters) | ≈ -0.4% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2110 ms (88 iters) | ✅ 2064 ms (90 iters) | ≈ -2.2% (±2.6%) | — / — |
| future-genetic | 25 | ✅ 2005 ms (93 iters) | ✅ 2118 ms (87 iters) | 🔴 +5.6% | — / — |
| naive-bayes | 21 | ✅ 1298 ms (132 iters) | ✅ 1281 ms (134 iters) | ≈ -1.3% (±32.4%) | — / — |
| naive-bayes | 25 | ✅ 1013 ms (169 iters) | ✅ 1020 ms (168 iters) | ≈ +0.7% (±31.8%) | — / — |
| reactors | 21 | ✅ 16224 ms (15 iters) | ✅ 16956 ms (15 iters) | ≈ +4.5% (±7.5%) | — / — |
| reactors | 25 | ✅ 18184 ms (15 iters) | ✅ 18593 ms (15 iters) | ≈ +2.2% (±4.9%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 4 | 2441 / 2310 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 1 | 8435 / 8807 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 8 / 1 | 1308 / 1244 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 1261 / 1267 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 3 | 2951 / 2891 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 2912 / 2878 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 3471 / 3509 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 5 / 1 | 3475 / 3487 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 2 | 1601 / 1751 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 1893 / 1958 | ✅ / ✅ | ✅ / ✅ |
Contributor
Benchmark Results (commit b53c3c3)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/128866997 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10323 ms (21 iters) | ✅ 10356 ms (21 iters) | ≈ +0.3% (±10.9%) | — / — |
| akka-uct | 25 | ✅ 8830 ms (24 iters) | ✅ 8780 ms (24 iters) | ≈ -0.6% (±9.6%) | — / — |
| finagle-chirper | 21 | ✅ 5961 ms (33 iters) | ✅ 5953 ms (33 iters) | ≈ -0.1% (±24.7%) | |
| finagle-chirper | 25 | ✅ 5469 ms (36 iters) | ✅ 5407 ms (36 iters) | ≈ -1.1% (±24.1%) | |
| fj-kmeans | 21 | ✅ 2733 ms (68 iters) | ✅ 2652 ms (70 iters) | 🟢 -3% | — / — |
| fj-kmeans | 25 | ✅ 2838 ms (66 iters) | ✅ 2702 ms (70 iters) | 🟢 -4.8% | — / — |
| future-genetic | 21 | ✅ 2101 ms (88 iters) | ✅ 2169 ms (85 iters) | 🔴 +3.2% | — / — |
| future-genetic | 25 | ✅ 2060 ms (90 iters) | ✅ 2010 ms (93 iters) | ≈ -2.4% (±2.7%) | — / — |
| naive-bayes | 21 | ✅ 1250 ms (137 iters) | ✅ 1297 ms (132 iters) | ≈ +3.8% (±33.4%) | — / — |
| naive-bayes | 25 | ✅ 1018 ms (168 iters) | ✅ 1024 ms (167 iters) | ≈ +0.6% (±31.7%) | — / — |
| reactors | 21 | ✅ 15582 ms (15 iters) | ✅ 17507 ms (15 iters) | 🔴 +12.4% | — / — |
| reactors | 25 | ✅ 18192 ms (15 iters) | ✅ 18154 ms (15 iters) | ≈ -0.2% (±4.1%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2015 / 1958 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2239 / 2060 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 2 | 8795 / 8422 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 2 | 8381 / 8098 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 4 | 1259 / 1234 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 5 / 4 | 1269 / 1303 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 2922 / 2995 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2939 / 2897 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 8 / ✅ | 3469 / 3493 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 3 | 3468 / 3476 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 1506 / 1751 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 1877 / 1851 | ✅ / ✅ | ✅ / ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Motivation:
Existing compiler and GC threads expose missing thread priming through sole synthetic frames. The macOS change also ensures Apple Clang targets the JVM architecture under Rosetta.
Additional Notes:
NativeThreadPrimingTestis intentionally disabled until thread priming is reintroduced.For Datadog employees: