bootstrap: add reusable opt-in consumer setup - #195
Merged
Conversation
Add the missing bzl_library metadata for pin_files.bzl and wire it into the actions that load the provider so Stardoc can traverse the rules_go Starlark graph. Regenerate the v0.60.0 base patch metadata and include the BUILD file in the workspace_runtime profile. Testing: python3 tools/dev/materialize_rules_go_fork.py check --all Testing: PYTHONUNBUFFERED=1 timeout 600 python3 tools/dev/verify_rules_go_profiles.py --upstream v0_60_0 --public-denylist tools/dev/private_leak_public_denylist.txt Testing: PYTHONUNBUFFERED=1 timeout 600 python3 tools/dev/verify_rules_go_profiles.py --upstream v0_61_1 --public-denylist tools/dev/private_leak_public_denylist.txt Testing: python3 tools/dev/verify_rules_go_profiles.py --skip-functional-smoke --public-denylist tools/dev/private_leak_public_denylist.txt
There was a problem hiding this comment.
The orch_transition no longer writes @rules_go//go/private/orchestrion:enabled=true; the bool_flag defaults to False. Existing consumers who upgrade the module without re-running the bootstrap tool will silently build orch_go_test targets without Orchestrion instrumentation — tests still pass, so nothing surfaces the regression. All 22 adversarial scenarios (9 Go, 13 Python) passed; no unintended behavioral regressions found elsewhere.
📊 Validated against 22 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 14d4964 · What is Autotest? · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--config=test-optimizationas the single user-facing opt-inenabled_by_env = Truetest_optimization_manifest_syncWORKSPACE rule and Bzlmod extension for invocation-scoped Go/Python monorepo onboardingexamples.bzl, Gazelle extension, inventory, or ownership gaterules_gov0.62.0fork/profile materialization while retainingv0.60.0as the default andv0.61.1compatibilityBehavioral contract
--config=test-optimization, manifest sync ignores the internal manifest handoff, performs no metadata requests, and emits stable disabled exports.DD_TEST_OPTIMIZATION_SERVICES_MANIFESTis an internal command-to-Bazel handoff, not a public rollout switch.Validation
The manifest/bootstrap implementation passed:
rules_goprofilesv0.60.0,v0.61.1, andv0.62.0git diff --check80ee9674de5a2d09d532ec40bdf0757d9ada2c25The current head was also consumed by
rules_test_optimization_testsheadb1426b0c3289e110776d8fb188a8eba79662f24c. Local WORKSPACE and Bzlmodv0.62.0E2E paths passed with metadata fetch, instrumented test execution, payload generation, doctor validation, and uploader dry-run enrichment.On macOS, Bazel tests use
--noexperimental_split_xml_generationbecause Bazel 8.5.1's experimental split-XML generator can segfault ingenerate-xml.sh.Downstream