enhancement(dogstatsd): add missing telemetry required for AMCC dashboard

[andrewqian2001datadog]

Summary

Source

This PR implements this bullet point "Implement telemetry needed in ADP to drive AMCC dashboard"

It adds news telemetry required to be added to the dashboard

const METRIC_FILTERLIST_SIZE_METRIC: &str = "adp.metric_filterlist_size";
const METRIC_FILTERLIST_UPDATES_METRIC: &str = "adp.metric_filterlist_updates_total";
const LISTENER_FILTERED_POINTS_METRIC: &str = "adp.dogstatsd_listener_filtered_points_total";

TODO: remap the name?

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

References

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Target: 4dd143e (baseline) vs 59645bd (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 37.09 MiB
Comparison Size: 37.10 MiB
Size Change: +2.71 KiB (+0.01%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module	File Size	Symbols
otlp_protos::otlp_include::opentelemetry	+74.26 KiB	124
prost	-60.55 KiB	104
core	+47.26 KiB	917
hyper_util	-45.11 KiB	10
hyper	+41.33 KiB	108
figment	-22.77 KiB	135
saluki_components::common::otlp	+19.16 KiB	28
serde_core	-17.34 KiB	169
alloc	-13.59 KiB	82
piecemeal	+12.51 KiB	17
http_body_util	-10.68 KiB	23
tokio	-10.50 KiB	77
saluki_components::sources::otlp	-10.43 KiB	29
tonic	-10.09 KiB	67
rustls	-9.12 KiB	5
datadog_protos::trace_piecemeal_include::datadog	-8.47 KiB	13
saluki_components::destinations::dsd_stats	+7.57 KiB	2
axum	-7.53 KiB	59
bytes	+7.53 KiB	25
tokio_rustls	+6.39 KiB	11

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +32.1Ki  [NEW] +32.0Ki    saluki_components::transforms::apm_stats::ApmStats::process_trace::h35b27988ab1a3818
  [NEW] +17.9Ki  [NEW] +17.8Ki    saluki_components::common::otlp::OtlpServerBuilder::build::_{{closure}}::h5a91c6514d5f04f3
  [NEW] +14.5Ki  [NEW] +14.4Ki    h2::server::Connection<T,B>::poll_closed::h960dc8b85a720654
  [NEW] +13.2Ki  [NEW] +13.1Ki    saluki_components::transforms::trace_sampler::TraceSampler::process_trace::h124d66f0f5772b3c
  [NEW] +13.2Ki  [NEW] +13.1Ki    h2::server::Connection<T,B>::poll_closed::hfc2be50d2b21bfb7
  [NEW] +13.1Ki  [NEW] +13.0Ki    h2::server::Connection<T,B>::poll_closed::hf2e5b377d21dc9da
  [NEW] +12.5Ki  [NEW] +12.4Ki    _<core::pin::Pin<P> as core::future::future::Future>::poll::h257fa99803413734
  +497% +8.36Ki  +527% +8.36Ki    tokio_rustls::common::Stream<IO,C>::read_io::h187c3e729c51cdb1
  [NEW] +7.69Ki  [NEW] +7.47Ki    _<saluki_components::transforms::dogstatsd_prefix_filter::DogStatsDPrefixFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::ha3655e5f42192d83
  +656% +7.51Ki  +770% +7.51Ki    _<saluki_components::destinations::dsd_stats::DogStatsDAPIHandler as saluki_api::APIHandler>::generate_routes::h0ec80ba79b55b6b1
  [NEW] +7.33Ki  [NEW] +7.21Ki    hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch::h70748a2b4ee2e790
  [DEL] -7.41Ki  [DEL] -7.30Ki    saluki_components::transforms::apm_stats::statsraw::RawBucket::export::h9755d212a133beaa
 -97.2% -8.50Ki -99.5% -8.50Ki    _<saluki_components::transforms::trace_sampler::TraceSampler as saluki_core::components::transforms::SynchronousTransform>::transform_buffer::h329ef393819f6a24
  [DEL] -8.62Ki  [DEL] -8.51Ki    rustls::conn::ConnectionCore<Data>::process_new_packets::h4b64157179e63bd1
  [DEL] -9.98Ki  [DEL] -9.86Ki    saluki_components::transforms::apm_stats::statsraw::RawBucket::handle_span::h0f845a56bde9488e
  [DEL] -10.4Ki  [DEL] -10.1Ki    _<saluki_components::transforms::dogstatsd_prefix_filter::DogStatsDPrefixFilter as saluki_core::components::transforms::Transform>::run::_{{closure}}::h6dd4a335d92937dd
  [DEL] -11.4Ki  [DEL]    -355    _<figment::value::de::MapDe<D,F> as serde_core::de::MapAccess>::next_value_seed::h4c05907830883f1b
 -59.0% -11.7Ki -59.5% -11.7Ki    _<saluki_components::sources::otlp::Otlp as saluki_core::components::sources::Source>::run::_{{closure}}::h6a3901a6b8553281
 -30.7% -14.8Ki -30.9% -14.8Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h3ea5d2d9c7bad8a2
  [DEL] -18.2Ki  [DEL] -18.0Ki    _<hyper_util::server::conn::auto::Connection<I,S,E> as core::future::future::Future>::poll::h0a8720a96625a9b6
  -0.7% -43.8Ki  -1.4% -69.5Ki    [5321 Others]
  +0.0% +2.71Ki  -0.0% -12.4Ki    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 2bc00b0f-76af-4c5a-9c10-2bfc137661e7

Baseline: 4dd143e
Comparison: 59645bd
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	+0.02	[-0.11, +0.14]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	-1.35	[-5.82, +3.12]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_memory	memory utilization	-1.86	[-2.18, -1.53]	1	(metrics) (profiles) (logs)

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	dsd_uds_1mb_3k_contexts_cpu	% cpu utilization	+5.41	[-49.63, +60.44]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_cpu	% cpu utilization	+3.23	[-53.31, +59.77]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_memory	memory utilization	+2.64	[+2.45, +2.84]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_throughput	ingress throughput	+2.54	[+2.40, +2.68]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_cpu	% cpu utilization	+1.95	[-4.64, +8.55]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_cpu	% cpu utilization	+1.27	[-0.14, +2.69]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_cpu	% cpu utilization	+0.68	[-1.40, +2.77]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_memory	memory utilization	+0.63	[+0.47, +0.79]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_memory	memory utilization	+0.59	[+0.45, +0.73]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_memory	memory utilization	+0.57	[+0.41, +0.73]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_memory	memory utilization	+0.56	[+0.42, +0.71]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_cpu	% cpu utilization	+0.38	[-29.89, +30.65]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_idle	memory utilization	+0.35	[+0.31, +0.38]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_cpu	% cpu utilization	+0.21	[-2.02, +2.45]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_low	memory utilization	+0.18	[+0.01, +0.35]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_memory	memory utilization	+0.15	[-0.09, +0.40]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_heavy	memory utilization	+0.12	[-0.01, +0.26]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_memory	memory utilization	+0.07	[-0.09, +0.23]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_memory	memory utilization	+0.04	[-0.11, +0.19]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_ultraheavy	memory utilization	+0.03	[-0.09, +0.15]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_throughput	ingress throughput	+0.02	[-0.01, +0.06]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	+0.02	[-0.11, +0.14]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_throughput	ingress throughput	+0.02	[-0.18, +0.22]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_throughput	ingress throughput	+0.00	[-0.05, +0.05]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_throughput	ingress throughput	-0.00	[-0.06, +0.06]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_throughput	ingress throughput	-0.01	[-0.15, +0.14]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_medium	memory utilization	-0.07	[-0.23, +0.10]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_throughput	ingress throughput	-0.12	[-0.20, -0.05]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_throughput	ingress throughput	-0.18	[-0.26, -0.10]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_memory	memory utilization	-0.18	[-0.34, -0.03]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_throughput	ingress throughput	-0.40	[-0.47, -0.32]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	-1.35	[-5.82, +3.12]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_cpu	% cpu utilization	-1.56	[-7.60, +4.47]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_cpu	% cpu utilization	-1.62	[-3.75, +0.51]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_memory	memory utilization	-1.86	[-2.18, -1.53]	1	(metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gates_rss_dsd_heavy	memory_usage	10/10	118.89MiB ≤ 140MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_low	memory_usage	10/10	39.64MiB ≤ 50MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_medium	memory_usage	10/10	60.49MiB ≤ 75MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	174.67MiB ≤ 200MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_idle	memory_usage	10/10	26.96MiB ≤ 40MiB	(metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".