fix: use extension registry for CLI text parsing#100
Merged
wackywendell merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
benbellick
approved these changes
Apr 15, 2026
Contributor
benbellick
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Though I wonder if there is a way to test this. Maybe we could have some dummy protos inside of this repo for testing purposes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI's
convert -f textandvalidatecommands didn't pass theExtensionRegistryto the text parser, so plans containing custom extensions (registered viarun_with_extensions) failed to parse from text input.This PR:
parse_with_registry()tolib.rsas the symmetric counterpart toformat_with_registry()Format::read_planfor text input to use the registry-aware parserrun_validate_with_ioto reuseFormat::read_plan/write_planinstead of duplicating the parse/format logicType of Change
Testing
Checklist
Related Issues
Closes #95