Draft
Conversation
wackywendell
force-pushed
the
wendell/lalrpop
branch
from
2a48806 to
76afd04
Compare
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76afd04a49
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Merged
…ering pipeline Replace the Pest PEG parser with a LALRPOP LR(1) grammar, introducing a two-phase parse-then-lower architecture. The grammar produces typed AST nodes that are lowered to Substrait protobuf with relation-specific semantic validation. Includes extension declaration parsing via LALRPOP, extraction of the extension lowering module, FromStr/From trait implementations, and in-code documentation for all major modules.
Add sections for import organization, pattern matching depth, unused parameter handling, parser pipeline pattern, extension handling guidelines, and rustdoc markdown formatting.
Add ordered_float dependency and implement manual Eq/Hash for LiteralValue (delegating to OrderedFloat for f64), then derive Eq + Hash on the full AST type chain.
wackywendell
force-pushed
the
wendell/lalrpop
branch
from
489877b to
3901c44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches from Pest to lalrpop, to clean up the code substantially:
ParsePair,ScopedParsePair,RuleIter,unreachable!().line_grammar.lalrpopis not quite as readable as the pest grammar, but it's not bad.See
adrs/lalrpop.mdto see the reasoning for this,parser/line_grammar.lalrpopfor the grammar, andparser/ast.rsfor the AST.This is a draft PR because I'm a bit undecided still, and haven't fully reviewed it. This was all done via @codex partly in the cloud and partly locally.