Skip to content

Conversation

@annacai21
Copy link

@annacai21 annacai21 commented Dec 8, 2025

Motivation

The released decorator was crashing when the tested dd_apm_inject version was set to a non-semver string like "N/A (Windows IIS)" (set by Windows tests). When the decorator tried to compare versions, it failed with:
ValueError: Version string lacks a numerical component: 'N/A (Windows IIS)'.

Changes

Wrap the version comparison in a try-except to handle unparseable version strings by skipping the version check.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

CODEOWNERS have been resolved as:

utils/_decorators.py                                                    @DataDog/system-tests-core

@annacai21 annacai21 marked this pull request as ready for review December 8, 2025 20:23
@annacai21 annacai21 requested a review from a team as a code owner December 8, 2025 20:23
@nccatoni nccatoni self-requested a review December 9, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants