fix: Enable C++ unit tests for macOS release builds#16
Merged
Conversation
- Remove Debug-only restriction for test builds on macOS - Tests now run in both Debug and Release configurations - Aligns macOS behavior with Linux where tests run for all build types - Only cross-compilation still skips tests (can't execute foreign binaries)
- Add build-system and tool.setuptools sections to pyproject.toml - Set packages = [] to prevent auto-discovery of fixtures/ and api_configuration/ - Fixes CI failure: "Multiple top-level packages discovered in flat-layout"
jrosskopf
force-pushed
the
fix/macos-test-enablement
branch
from
95822e8 to
4a306c8
Compare
… key - CachingFileProvider::ReadFile: use emplace instead of operator[] so concurrent threads that both miss the cache don't double-count current_entries (fixes test_vfs_cache concurrent reads on macOS) - test/integration/pyproject.toml: remove duplicate [tool.setuptools] section introduced by rebase (caused uv TOML parse error in CI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testnow correctly discovers and runs all 397 unit tests on macOSBackground
The CMakeLists.txt had a condition that only added the test subdirectory for Debug builds on macOS. This caused
make test(which depends on the release build) to report "No tests were found!!!" while Linux worked correctly.Test plan
make testruns all 397 tests on macOS (arm64)