Merged
Conversation
- Update duckdb submodule to v1.5.0 tag (3a3967aa81) - Set DUCKDB_EXPLICIT_VERSION to 1.5.0 in CMakeLists.txt - Add dummy_static_extension_loader to link libraries (new in 1.5.0) - Switch arrow_serializer.hpp ZSTD from duckdb_zstd:: namespace to vcpkg zstd (global namespace) — duckdb_zstd header no longer in transitive include path with 1.5.0 - Update DuckDB version references in AGENTS.md, Readme.md, docs/CONFIG_REFERENCE.md
…5.0 /MT compatibility - DuckDB 1.5.0 unconditionally sets CMAKE_MSVC_RUNTIME_LIBRARY to MultiThreaded (/MT) - Previously used x64-windows-static-md (/MD) caused LNK2038 mismatch errors - x64-windows-static uses /MT, aligning with DuckDB 1.5.0's CRT requirement
…1.5.0 The vcpkg triplet x64-windows-static ensures packages use /MT, but vcpkg's toolchain does not propagate CMAKE_MSVC_RUNTIME_LIBRARY to the host project. Without an explicit setting, flapi's own targets default to /MD, causing LNK2038 when linking against duckdb_static.lib (which forces /MT).
keytar is a native Node.js addon that has no prebuilt binary for darwin-arm64 when installing from a Linux host, causing bun install to fail in the flapii-build CI job. keytar was never imported or used anywhere in the CLI source code, so this is a clean removal.
- Update duckdb submodule to v1.5.1 tag - Bump DUCKDB_EXPLICIT_VERSION in CMakeLists.txt - Update version references in docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duckdbsubmodule from v1.4.3 to v1.5.0DUCKDB_EXPLICIT_VERSIONin CMakeLists.txt to matchdummy_static_extension_loader— in 1.5.0,ExtensionHelper::LoadAllExtensionswas extracted into this separate static library and must be linked explicitlyarrow_serializer.hppusedduckdb_zstd::ZSTD_*from DuckDB's bundled zstd, but that header is no longer in the transitive include path; switched to the already-linked vcpkg ZSTD (global namespace)Test plan
make debug— builds successfullymake integration-test— manual verification with running server recommended