Open
Conversation
…dsuet data output format.
… specifications as all default values in model for now.
…ead handle the warning in the initialization of the output file. This is 'safer' for outputs that specify legacy, but do not actually make a file. Update tests to hide warnings.
…t that will be mostly invisible to users. Only breaking change will be output files have time dimension called 'seconds' instead of 'time'. Old behavior is maintained with legacy_netcdf=True.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #299 +/- ##
===========================================
+ Coverage 78.49% 78.72% +0.22%
===========================================
Files 12 12
Lines 2674 2726 +52
===========================================
+ Hits 2099 2146 +47
- Misses 575 580 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… tests accordingly. Test also to check for warning emitted.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Format the default pyDeltaRCM output to be compliant with the sandpiper-toolchain sandsuet data specification.
Previous output format (2.1.9) is maintained via the
legacy_netcdf=Truespecification and this backwards compatibility will be maintained for at least one minor version. Drops support for what was the legacy version (outputs prior to 2.1.0; #233); this change was announced with #293.Changes to the output file:
secondsinstead oftimeauxdatainstead ofmeta(note: the internal model reference for this subgroup is stillmetaandmetadata; this could be addressed in a future?)Changes to the model i/o:
long_namefield of the netcdf fileTODO:
This PR starts a process of specifying the attributes of output data (e.g., this output info) as a dictionary instead of a list. I think this would be much easier to document and explain. I will try to make this a non-breaking change slated for deprecation, and if successful, may include it in this PR.infrastructure is implemented, but will make change in next PR (does not directly affect sandsuet). See specifying the attributes of output data as dictionary instead of list #301rename the internalNot necessary, just stylisticmetalisting and references to metadata toauxdata. At first, we should just makemetaan alias toauxdatainternally, and then could maintain backwards compatability for any custom subclasses.