Feature: Show/Hide Suppressed Findings on Vulnerability Audit Grouped View #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
4 tasks
* Addresses issue 4507 * Added showSuppressed filtering mirroring getAllFindings() * Differs from getAllFindings in that pagination is handled via SQL instead of retrieving all records then sublisting results * Added getAllFindingsGroupedByVulnerabilityCount method to support the above pagination behaviour * Added second ordering clause by vulnID such that results maintain consistent ordering beyond the primary user-selected sort column * Removed unused processAggregatedDateRangeFilter method * Added tests covering the above Signed-off-by: colinfyfe <[email protected]>
colinfyfe
force-pushed
the
fix-issue-4507-suppressed-vulns
branch
from
4d11e12 to
bc76e7c
Compare
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to exclude suppressed findings from the Vulnerability Audit "Grouped Vulnerabilities" tab, mirroring the functionality in the "Vulnerabilities By Occurrence" tab. Defaults to hiding suppressed findings.
Existing behaviour with suppressed findings visible:
New behaviour with suppressed findings hidden:
Addressed Issue
Resolves #4507
Additional Details
Added showSuppressed filtering based on getAllFindings(). Differs from that method though in that pagination is handled via SQL instead of retrieving all records then sublisting results which should be more performant on large result sets.
This PR covers the API changes - the Frontend changes are covered in DependencyTrack/frontend#1320
Checklist
[ ] This PR introduces changes to the database model, and I have added corresponding update logic