feat(drop-down): 下拉菜单新增right-click触发方式 (#294) #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplelegant
requested changes
Mar 29, 2025
| } | ||
| @HostListener('contextmenu', ['$event']) | ||
| toggleOnContextMenu(event: MouseEvent) { | ||
| if (!this.disabled && this.dropdown.trigger === 'right-click') { |
Collaborator
There was a problem hiding this comment.
发现一个问题，trigger为'right-click'时点击左键也会打开下拉按钮，此种场景下应该要排查左键点击
Contributor
Author
There was a problem hiding this comment.
最新提交已经修复,hover保持原样
修改的部分涉及到原本hover时,也可以通过click触发,增加了右击的判断
Simplelegant
previously approved these changes
Mar 31, 2025
foolmadao
approved these changes
Mar 31, 2025
| | --------------------- |----------------------------------------------| ------- |-------------------------------------------------------------------------------| ------------------------------------------------------ | ---------- | | ||
| | isOpen | `boolean` | false | 可选，可以显示指定 dropdown 是否打开 | [设置 isOpen 控制下拉](demo#dropdown-set-is-open) | | | ||
| | disabled | `boolean` | false | 可选，设置为 true 禁用 dropdown | | | | ||
| | trigger | `'click'\|'hover'\|'manually\|'right-click'` | 'click' | 可选，dropdown 触发方式, click 为点击，hover 为悬停（也包含点击）、manually 为完全手动控制、right-click 为右击 | [悬浮下拉](demo#suspension-drop-down) | | |
| } | ||
| return false; | ||
| } | ||
| @HostListener('contextmenu', ['$event']) |
There was a problem hiding this comment.
mac的contextmenu事件早于点击触发，可能会导致下拉触发后，宿主的点击事件冒泡下去触发关闭逻辑导致下拉打不开，我这没有mac电脑，有条件可以测试下，或者toggle里防御一下
Contributor
Author
There was a problem hiding this comment.
在mac中使用chrome验证通过,触控板右击不会触发click,只会触发contextmenu
foolmadao
approved these changes
Apr 1, 2025
Simplelegant
approved these changes
Apr 1, 2025
GreatZPP
approved these changes
Apr 1, 2025
GreatZPP
added a commit
that referenced
this pull request
May 22, 2025
feat(drop-down): 下拉菜单新增right-click触发方式 (#294) (#364) Created-by: GreatZP Commit-by: xucr11;锐来锐好;caoxicheng Merged-by: GreatZP Description: feat(drop-down): 下拉菜单新增right-click触发方式 (#294) (#364) fix(module:date-picker-pro): tab type demo fix(module:date-picker-pro): border radius style fix(module:modal): empty modal footer style fix(module:modal): empty modal footer style See merge request: DevCloudFE/ng-devui!6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.