Skip to content

feat: switch to @protobuf-ts lib from protobufjs #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: switch to @protobuf-ts lib from protobufjs #1043

wants to merge 4 commits into from

Conversation

@jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Apr 10, 2025 •
edited
Loading

  • switch to @protobuf-ts from protobufjs, better TS support and no eval use

@vercel
Copy link

vercel bot commented Apr 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 5:35pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 5:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Apr 14, 2025 5:35pm

jonathannorris
jonathannorris commented Apr 10, 2025
View reviewed changes
sdk/nodejs/src/utils/userBucketingHelper.ts
variableType: type,
shouldTrackEvent: true,
}
const err = VariableForUserParams_PB.verify(params)
Copy link
Member Author

@jonathannorris jonathannorris Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: confirm verify behaviour isn't needed.

@jonathannorris jonathannorris marked this pull request as draft April 11, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathannorris