Skip to content

Conversation

@jonathannorris
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-next-js ❌ Failed (Inspect) Oct 24, 2023 8:05pm
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:05pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:05pm

@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch from b17a73e to 20f66d9 Compare September 29, 2023 18:26
@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch 2 times, most recently from cd30000 to 16d5c3b Compare October 2, 2023 19:34
export const EVENT_URL = 'https://events'
export const EVENTS_PATH = '/v1/events/batch'

export async function publishEvents(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving common event publishing route to the shared lib.

readonly evalReason?: unknown
}

export interface DevCycleEvent {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to request lib where it is used

import { publishEvents } from './request'
import { DevCycleEvent, DVCPopulatedUser } from '@devcycle/js-cloud-server-sdk'

export const AggregateEventTypes: Record<string, string> = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to common place in request lib.

export const EVENT_URL = 'https://events'
export const EVENTS_PATH = '/v1/events/batch'

export async function publishEvents(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to request lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants