Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the CI/CD infrastructure by adding comprehensive testing workflows and fixing a cross-platform path handling issue. The changes introduce a multi-OS CI matrix for unit tests and a dedicated integration testing workflow that supports both local (act) and GitHub runner execution, while ensuring RC tags trigger integration validation but skip releases.
Changes:
- Add
.github/workflows/ci.ymlfor cross-platform unit testing (Linux, Windows, macOS) on PRs and pushes to main - Add
.github/workflows/integration.ymlfor E2E integration tests triggered by workflow_dispatch or RC tags, with smart act/GitHub runner differentiation - Update
.github/workflows/release.ymlto skip RC tags using!contains(github.ref_name, '-rc') - Fix cross-platform path construction in
cmd/deploy_local.goby replacing hardcoded Windows path separator withfilepath.Join
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
New cross-platform unit test workflow running build/vet/test on Linux, Windows, and macOS for PRs and main branch pushes |
.github/workflows/integration.yml |
New integration test workflow with deploy/health/migration smoke tests (act) and full connection/scope/project E2E (GitHub runners) |
.github/workflows/release.yml |
Add RC tag filter to prevent release workflow from running on pre-release tags |
cmd/deploy_local.go |
Replace hardcoded Windows path separator with filepath.Join for cross-platform compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes