fix(foreman): US English spelling + retire QA Enforcer from reference diagrams by Copilot · Pull Request #80 · DevExpGbb/gh-devlake

Copilot · 2026-03-02T13:08:16Z

Fix "behaviour" → "behavior" in github-foreman.agent.md (US English consistency)
Update foreman-workflows.md diagrams to replace QA Enforcer with CI Gate
Update remaining MCP: edge labels to github/* style in interaction graph
Update INST node label to .github/copilot-instructions.md (accurate path)
Update CI gate sequence step to github/pull_request_read (method: "get_checks")

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…agrams Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot

Pull request overview

Updates GitHub Foreman documentation to align with the current workflow (post–QA Enforcer removal) and standardize US English spelling in agent guidance.

Changes:

Standardizes spelling in the Foreman agent doc (behaviour → behavior).
Updates Foreman workflow reference diagrams to remove QA Enforcer and add CI as the automated gate.
Renumbers and rewrites the sequence diagram phases to reflect the newer iterative review + CI gating loop.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`.github/agents/references/foreman-workflows.md`	Updates Mermaid diagrams to reflect CI replacing QA Enforcer and the newer phase structure/tool naming.
`.github/agents/github-foreman.agent.md`	US English spelling consistency update in severity bucket description.

Comments suppressed due to low confidence (1)

.github/agents/references/foreman-workflows.md:151

The CI gate polling step in the sequence diagram uses get_status (check runs), but the Foreman agent guidance specifies polling check runs via github/pull_request_read with method: "get_checks". Updating this label to match the actual tool/method names will keep the reference diagram aligned with the current workflow docs.

    Note over Foreman,CI: ═══ PHASE 4: CI GATE (automatic) ═══
    CI->>PRs: go build / go vet / go test (Linux/Windows/macOS)
    loop Poll every 2min until checks complete
        Foreman->>PRs: get_status (check runs)
        alt All green

Copilot · 2026-03-02T16:38:01Z

.github/agents/references/foreman-workflows.md

    %% Foreman triggers code review
-    F -->|"MCP: request_copilot_review"| CRA
+    F -->|"github/request_copilot_review"| CRA
    CRA -->|"review comments"| PR1
    CRA -->|"review comments"| PR2
-    CRA -.->|"reads review guidance"| CI
+    CRA -.->|"reads review guidance"| INST


In the interaction graph, tool labels are partially migrated to the github/* style (e.g., github/request_copilot_review), but the earlier edges still use the old MCP: prefix for list_issues/issue_read and assign_copilot_to_issue. This leaves the diagram inconsistent and contradicts the PR description’s claim that tool labels were updated where applicable; consider updating those remaining edge labels to github/list_issues, github/issue_read, and github/assign_copilot_to_issue for consistency.

This issue also appears on line 147 of the same file.

Fixed in commit 62361a0 — updated the remaining MCP: edge labels to github/list_issues, github/issue_read, and github/assign_copilot_to_issue for consistency with the rest of the diagram.

ewega · 2026-03-02T16:43:31Z

@copilot apply changes based on the comments in this thread

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-02T17:11:57Z

.github/agents/references/foreman-workflows.md

+    Note over Foreman,CI: ═══ PHASE 4: CI GATE (automatic) ═══
+    CI->>PRs: go build / go vet / go test (Linux/Windows/macOS)
+    loop Poll every 2min until checks complete
+        Foreman->>PRs: get_status (check runs)


In the sequence diagram’s CI gate, Foreman->>PRs: get_status (check runs) doesn’t match the actual Phase 4 guidance in github-foreman.agent.md, which uses github/pull_request_read with method: "get_checks". Update the diagram step to use the same method name (and ideally mention github/pull_request_read) so the reference diagrams stay consistent with the authoritative workflow doc.

Suggested change

Foreman->>PRs: get_status (check runs)

Foreman->>PRs: github/pull_request_read (method: "get_checks")

Fixed in commit 85dc1bc — updated to github/pull_request_read (method: "get_checks").

Copilot · 2026-03-02T17:11:57Z

.github/agents/references/foreman-workflows.md

        PR1["PR #1<br/>copilot/issue-X"]
        PR2["PR #2<br/>copilot/issue-Y"]
-        CI["copilot-instructions.md"]
+        INST["copilot-instructions.md"]


The interaction graph node label INST["copilot-instructions.md"] is a bit misleading since the file in this repo is .github/copilot-instructions.md (and other agent docs reference the full path). Consider updating the node label to .github/copilot-instructions.md for accuracy.

Suggested change

INST["copilot-instructions.md"]

INST[".github/copilot-instructions.md"]

Fixed in commit 85dc1bc — node label updated to .github/copilot-instructions.md.

ewega · 2026-03-02T17:13:35Z

@copilot apply changes based on the comments in this thread

…step Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

* refactor(foreman): iterative review loop, CI gate, phase renumber * fix(foreman): remove Explore agent (no file backing), update mcp_github_ refs in phases 1/1b/2/2b * fix(foreman): US English spelling + retire QA Enforcer from reference diagrams (#80) * Initial plan * fix(foreman): behavior spelling, remove QA Enforcer from reference diagrams Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * fix(foreman): update remaining MCP: edge labels to github/* style Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * fix(foreman): accurate node label + github/pull_request_read CI gate step Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * Update .github/agents/github-foreman.agent.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/agents/github-foreman.agent.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix interaction diagram to reflect ruleset-driven code review trigger (#81) * Initial plan * Update interaction diagram to reflect ruleset-driven code review trigger Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * Update .github/agents/references/foreman-workflows.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> Co-authored-by: Eldrick Wega <ewega@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

df425cb

Copilot AI assigned Copilot and ewega Mar 2, 2026

Copilot AI mentioned this pull request Mar 2, 2026

refactor(foreman): iterative review loop + CI gate phases #78

Merged

Copilot started work on behalf of ewega March 2, 2026 13:08 View session

fix(foreman): behavior spelling, remove QA Enforcer from reference di…

e395532

…agrams Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor GitHub Foreman workflow for iterative review~~ fix(foreman): US English spelling + retire QA Enforcer from reference diagrams Mar 2, 2026

Copilot finished work on behalf of ewega March 2, 2026 13:12

ewega marked this pull request as ready for review March 2, 2026 16:34

ewega requested a review from Copilot March 2, 2026 16:34

Copilot started reviewing on behalf of ewega March 2, 2026 16:35 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Copilot started work on behalf of ewega March 2, 2026 16:43 View session

fix(foreman): update remaining MCP: edge labels to github/* style

62361a0

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot finished work on behalf of ewega March 2, 2026 16:45

ewega requested a review from Copilot March 2, 2026 17:09

Copilot started reviewing on behalf of ewega March 2, 2026 17:10 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Copilot started work on behalf of ewega March 2, 2026 17:13 View session

fix(foreman): accurate node label + github/pull_request_read CI gate …

85dc1bc

…step Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot finished work on behalf of ewega March 2, 2026 17:15

ewega requested a review from Copilot March 2, 2026 17:17

Copilot started reviewing on behalf of ewega March 2, 2026 17:18 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

ewega merged commit fc68ffd into feat/foreman-review-phases Mar 2, 2026
4 checks passed

ewega deleted the copilot/sub-pr-78 branch March 2, 2026 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(foreman): US English spelling + retire QA Enforcer from reference diagrams#80

fix(foreman): US English spelling + retire QA Enforcer from reference diagrams#80
ewega merged 4 commits intofeat/foreman-review-phasesfrom
copilot/sub-pr-78

Copilot AI commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

ewega commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

ewega commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Foreman->>PRs: get_status (check runs)
	Foreman->>PRs: github/pull_request_read (method: "get_checks")

	INST["copilot-instructions.md"]
	INST[".github/copilot-instructions.md"]

Conversation

Copilot AI commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ewega commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ewega commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 2, 2026 •

edited

Loading