Fix interaction diagram to reflect ruleset-driven code review trigger#81
Merged
ewega merged 3 commits intofeat/foreman-review-phasesfrom Mar 2, 2026
Merged
Fix interaction diagram to reflect ruleset-driven code review trigger#81ewega merged 3 commits intofeat/foreman-review-phasesfrom
ewega merged 3 commits intofeat/foreman-review-phasesfrom
Conversation
Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes based on feedback for iterative review loop
Fix interaction diagram to reflect ruleset-driven code review trigger
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Foreman workflow reference diagram so it reflects the primary, ruleset-driven “ready for review” trigger for the Code Review Agent, while retaining Foreman’s manual review request as a fallback.
Changes:
- Replaces the single Foreman → Code Review Agent trigger with PR → Code Review Agent triggers based on “mark ready for review” ruleset behavior.
- Relabels the Foreman → Code Review Agent arrow as a fallback trigger.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ewega
added a commit
that referenced
this pull request
Mar 2, 2026
* refactor(foreman): iterative review loop, CI gate, phase renumber * fix(foreman): remove Explore agent (no file backing), update mcp_github_ refs in phases 1/1b/2/2b * fix(foreman): US English spelling + retire QA Enforcer from reference diagrams (#80) * Initial plan * fix(foreman): behavior spelling, remove QA Enforcer from reference diagrams Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * fix(foreman): update remaining MCP: edge labels to github/* style Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * fix(foreman): accurate node label + github/pull_request_read CI gate step Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * Update .github/agents/github-foreman.agent.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/agents/github-foreman.agent.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix interaction diagram to reflect ruleset-driven code review trigger (#81) * Initial plan * Update interaction diagram to reflect ruleset-driven code review trigger Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> * Update .github/agents/references/foreman-workflows.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ewega <26189114+ewega@users.noreply.github.com> Co-authored-by: Eldrick Wega <ewega@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent interaction diagram showed Foreman as the sole trigger for code review via
github/request_copilot_review, contradicting the Phase 3 sequential flow which describes the ruleset-driven ready-for-review mechanism as primary.Changes
foreman-workflows.md— interaction diagram (lines 57–61): Replaced the single Foreman→CRA arrow with two PR→CRA arrows (mark ready for review / ruleset assigns Code Review Agent) as the primary path, and relabeled the Foreman→CRA arrow as(fallback trigger).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.