List: expose NoDataText to screen readers when empty (T1329047)#33657
Open
dmlvr wants to merge 3 commits into
Open
List: expose NoDataText to screen readers when empty (T1329047)#33657dmlvr wants to merge 3 commits into
dmlvr wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility gap in dxList where the empty-state message (noDataText) was not being exposed to screen readers via an aria-label on the scroll view content (focus target). It updates the List’s internal empty-message rendering to synchronize aria-label with the empty state and adjusts/extends widget test coverage accordingly.
Changes:
- Update
ListBaseto set/clear the focus target’saria-labelbased on whether the list is in the empty state, using the empty message text. - Export the
dx-empty-collectionCSS class constant fromcollection_widget.base.tsfor reuse inListBase. - Add/update accessibility tests for List, SelectBox, and Lookup to validate the new
aria-labelbehavior on empty lists.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js | Adds coverage ensuring scrollview content gets aria-label=noDataText in empty-state scenarios (init, runtime changes, clearing). |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/selectBox.tests.js | Updates ARIA assertions to expect the list’s empty-state aria-label on the scrollview content. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js | Updates ARIA assertions to expect the list’s empty-state aria-label and verifies it toggles with data presence. |
| packages/devextreme/js/__internal/ui/list/list.base.ts | Implements empty-state aria-label synchronization on the list focus target (scrollview content). |
| packages/devextreme/js/__internal/ui/collection/collection_widget.base.ts | Exports EMPTY_COLLECTION constant so List can reliably detect empty state via the shared class name. |
pharret31
reviewed
May 21, 2026
pharret31
reviewed
May 21, 2026
pharret31
previously approved these changes
May 21, 2026
r-farkhutdinov
previously approved these changes
May 21, 2026
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.