PivotGrid - A11y - fix KBN in area items#33778
Open
Tucchhaa wants to merge 2 commits into
Open
Conversation
Tucchhaa
force-pushed
the
pg_sorting_kbn_26_1
branch
from
ffd8c13 to
f9a1fd0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves PivotGrid keyboard accessibility (KBN) for field/area items by making area fields keyboard-focusable, handling Enter/Space activation, and restoring focus after rerenders/updates. It also adds end-to-end TestCafe coverage for tab traversal and focus persistence in both PivotGrid field panels and the FieldChooser.
Changes:
- Make PivotGrid/FieldChooser area field items focusable and keyboard-activatable (Enter/Space) and restore focus after updates.
- Restore field focus after header rendering and after scrollable updates/dimension recalculation.
- Add comprehensive TestCafe KBN tests for tab navigation, sorting activation, and header-filter focus restoration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/pivotGrid/fieldChooser.ts | Adds a selector helper for data-area items in the FieldChooser model. |
| packages/devextreme/js/__internal/grids/pivot_grid/m_widget.ts | Calls restoreFieldFocus() after header rendering and after scrollable updates to keep focus stable. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser.ts | Restores field focus on data source changed events in the FieldChooser. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts | Adds tabindex to field items, keyboard handling, and focus-tracking/restoration logic. |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | New E2E coverage for field focusability, tab traversal, Enter/Space behavior, and header filter focus restoration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.