Test: migrate demos tests to Playwrite#33848
Draft
EugeniyKiyashko wants to merge 8 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Playwright-based visual regression test runner for demos (common screenshots) and wires it into the monorepo (Nx target + package scripts) and CI (new GitHub Actions workflow), replacing/augmenting the existing TestCafe-driven approach for this scenario.
Changes:
- Introduces Playwright common-screenshots spec + supporting utilities (demo discovery, page prep, screenshot comparison + diff artifacts).
- Adds Playwright configuration and Nx/script entry points to run the new suite.
- Adds a dedicated GitHub Actions workflow to build DevExtreme artifacts and execute Playwright screenshots in a matrix.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks the new Playwright dependency and resulting transitive dependency graph changes. |
| apps/demos/utils/visual-tests/playwright/screenshot-comparer.ts | Implements screenshot capture + looks-same comparison with diff/mask handling and artifact copying. |
| apps/demos/utils/visual-tests/playwright/common-screenshots.spec.ts | Playwright test suite that iterates demos/frameworks and validates screenshots. |
| apps/demos/utils/visual-tests/playwright/common-screenshots-utils.ts | Shared utilities for filtering/selection, client script injection, URL building, and page prep. |
| apps/demos/tsconfig.json | Includes playwright.*.ts files in TypeScript compilation for the demos app. |
| apps/demos/tsconfig.eslint.json | Includes playwright.*.ts files for ESLint type-aware linting. |
| apps/demos/project.json | Adds Nx target test-playwright-common-screenshots. |
| apps/demos/playwright.common-screenshots.config.ts | Playwright runner configuration (workers, retries, chromium args/channel, artifact output dirs). |
| apps/demos/package.json | Adds @playwright/test dependency and test-playwright-common-screenshots script. |
| .github/workflows/visual-tests-demos-playwright.yml | New CI workflow to run Playwright common screenshots in a theme/partition matrix. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
EugeniyKiyashko
force-pushed
the
26_1_migrate_to_playwrite
branch
from
11b4eb0 to
eb84386
Compare
EugeniyKiyashko
force-pushed
the
26_1_migrate_to_playwrite
branch
from
eb84386 to
8887cdf
Compare
…ent) Apply the comparer overrides from theme-utils.js#testScreenshot universally so fluent and material both use textDiffTreshold: 0.2 along with the existing tolerance/antialiasingTolerance: 20. The previous code only applied textDiffTreshold for material, which kept fluent stricter than TestCafe. Set PLAYWRIGHT_LEGACY_SCREENSHOT=1 for the common-screenshots and common-accessibility jobs so chromium uses the legacy CDP screenshot surface. Playwright 1.49+ enables CDPScreenshotNewSurface by default, which renders text antialiasing differently from TestCafe's chrome:headless path and causes massive material diffs against the existing etalons. Also bring in the accessibility scaffolding (workflow job, nx target, playwright spec/utils) that was queued up alongside this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.