[Visual Regression Tests] Fix xUnit error for updates & improve test workflow#556
Merged
Anna Malchow-Perryman (apman) merged 4 commits intoJun 18, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Anna Malchow-Perryman (apman)
June 18, 2026 19:09
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the visual regression testing workflow by preventing xUnit v3 startup/protocol issues caused by writing warning banners to stdout, while also adding an optional wrapper script to make visual regression failures easier to scan.
Changes:
- Moved
UPDATE_BASELINES=truewarning output to stderr and deduplicated it across xUnit discovery/execution via a temp-file sentinel. - Refactored screenshot capture/compare to use a helper method and updated failure reporting to support the wrapper’s summary parsing.
- Added
scripts/test.shwrapper fordotnet testto support shorthand filters and print a deduplicated visual-regression summary; documented it inREADME.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Devolutions.AvaloniaControls.VisualTests/VisualRegressionTests.cs | Refactors capture/compare and moves baseline-update warnings to stderr with deduplication logic. |
| scripts/test.sh | Adds an optional dotnet test wrapper that normalizes filters and prints a deduplicated visual-regression summary. |
| README.md | Documents the new wrapper script usage for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anna Malchow-Perryman (apman)
changed the title
Make baseline-update banner sentinel file handling best-effort so module initialization cannot fail when temp file I/O is unavailable. Also remove duplicate stderr emission from visual test failures and rely on Assert.Fail messages, which keeps both raw dotnet output and scripts/test.sh summary output less noisy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Anna Malchow-Perryman (apman)
June 18, 2026 19:58
View session
Anna Malchow-Perryman (apman)
deleted the
agents/xunit-update-baselines-issue
branch
Anna Malchow-Perryman (apman)
added a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Error fixed
UPDATE_BASELINES=trueby moving startup warning output off stdout.Improved usability of test commands
scripts/test.shwrapper to rundotnet testwith:--filter EditableCombo=>DisplayName~EditableCombo)README.mdtest usage to document the new wrapper script.Why
Reviewer notes
scripts/test.shis optional; rawdotnet testbehavior is unchanged.dotnet testexit code and supports explicit filter expressions unchanged.