[MacOS] Fix dark-mode invisible MenuItem icons#566
Merged
Anna Malchow-Perryman (apman) merged 6 commits intoJun 26, 2026
Merged
[MacOS] Fix dark-mode invisible MenuItem icons#566Anna Malchow-Perryman (apman) merged 6 commits into
Anna Malchow-Perryman (apman) merged 6 commits into
Conversation
Copilot started reviewing on behalf of
Anna Malchow-Perryman (apman)
June 25, 2026 22:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MenuItem SVG icon coloring on macOS (notably in dark mode) by removing the non-reactive binding+converter approach and switching to DynamicResource-backed CSS string resources, aligning the macOS theme with the simpler CSS-string pattern already used by the DevExpress and Linux themes.
Changes:
- macOS: Replace converter-based SVG fill styling with
SvgMenuItem*CssDynamicResources, including a pointer-over variant. - macOS: Add light/dark
SvgMenuItemDefaultCss,SvgMenuItemPointerOverCss, andSvgMenuItemDisabledCssresources and remove now-unused icon color/brush resources. - DevExpress & Linux: Remove unused SVG icon color/brush resources and remove now-outdated explanatory comment blocks in GlobalStyles.
Reviewed changes
Copilot reviewed 6 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Devolutions.AvaloniaTheme.MacOS/GlobalStyles.axaml | Switch MenuItem SVG styling to DynamicResource CSS strings and add pointer-over styling. |
| src/Devolutions.AvaloniaTheme.MacOS/Accents/ThemeResources.axaml | Introduce theme-variant CSS string resources for MenuItem SVG fills; remove unused icon brush/color resources. |
| src/Devolutions.AvaloniaTheme.Linux/GlobalStyles.axaml | Remove outdated header commentary related to the prior icon-coloring approach. |
| src/Devolutions.AvaloniaTheme.Linux/Accents/ThemeResources.axaml | Remove unused SVG icon color/brush resources (CSS resources remain). |
| src/Devolutions.AvaloniaTheme.DevExpress/GlobalStyles.axaml | Remove outdated header commentary related to the prior icon-coloring approach. |
| src/Devolutions.AvaloniaTheme.DevExpress/Accents/ThemeResources.axaml | Remove unused SVG icon color/brush resources (CSS resources remain). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anna Malchow-Perryman (apman)
changed the title
Anna Malchow-Perryman (apman)
deleted the
agents/menuitem-svg-fill-consistency-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by icon colouring issues in RDM I decided to remove the inconsistent approaches between themes for setting the fill colour, and noticed that the MacOS mechanism (using a converter) was actually broken, rendering dark-mode icons largely invisible!
This fixes the dark-mode colours and brings MacOS in line with DevExpress & Linux using a much simpler fill colour logic.